refactor: improve system service removal

Signed-off-by: Dominik Willner <th33xitus@gmail.com>

docs/changelog.md

@@ -2,54 +2,13 @@
 
 This document covers possible important changes to KIAUH.
 
-### 2024-08-31 (v6.0.0-alpha.1)
-Long time no see, but here we are again!
-A lot has happened in the background, but now it is time to take it out into the wild.
-
-#### KIAUH has now reached version 6! Well, at least in an alpha state...
-
-The project has seen a complete rewrite of the script from scratch in Python.
-It requires Python 3.8 or newer to run. Because this update is still in an alpha state, bugs may or will occur.
-During startup, you will be asked if you want to start the new version 6 or the old version 5.
-As long as version 6 is in a pre-release state, version 5 will still be available. If there are any critical issues
-with the new version that were overlooked, you can always switch back to the old version.
-
-In case you selected not to get asked about which version to start (option 3 or 4 in the startup dialog) and you want to
-revert that decision, you will find a line called `version_to_launch=` within the `.kiauh.ini` file in your home directory.
-Just delete that line, save the file and restart KIAUH. KIAUH will then ask you again which version you want to start.
-
-Here is a list of the most important changes to KIAUH in regard to version 6:
-- The majority of features available in KIAUH v5 are still available; they just got migrated from Bash to Python.
-- It is now possible to add new/remove instances to/from existing multi-instance installations of Klipper and Moonraker
-- KIAUH now has an Extension-System. This allows contributors to add new installers to KIAUH without having to modify the main script.
-    - You will now find some of the features that were previously available in the Installer-Menu in the Extensions-Menu.
-    - The current extensions are:
-        - G-Code Shell Command (previously found in the Advanced-Menu)
-        - Mainsail Theme Installer (previously found in the Advanced-Menu)
-        - Klipper-Backup (new in v6!)
-        - Moonraker Telegram Bot (previously found in the Installer-Menu)
-        - PrettyGCode for Klipper (previously found in the Installer-Menu)
-        - Obico for Klipper (previously found in the Installer-Menu)
-    - The following additional extensions are planned, but not yet available:
-        - Spoolman (available in v5 in the Installer-Menu)
-        - OctoApp (available in v5 in the Installer-Menu)
-- KIAUH has its own config file now
-    - The file has some default values for the currently supported options
-    - There might be more options in the future
-    - It is located in KIAUH's root directory and is called `default.kiauh.cfg`
-        - DO NOT EDIT the default file directly, instead make a copy of it and call it `kiauh.cfg`
-        - Settings changed via the Advanced-Menu will be written to the `kiauh.cfg`
-- Support for OctoPrint was removed
-
-Feel free to give version 6 a try and report any bugs or issues you encounter! Every feedback is appreciated.
-
 ### 2023-06-17
-KIAUH has now added support for installing Mobileraker's companion!
+KIAUH has now added support for installing Mobileraker's companion! 
 Mobileraker is a free and Open Source Android and iOS App for Klipper, utilizing the Moonraker API, allowing you
 to control your printer. Thank you to [Clon1998](https://github.com/Clon1998) for adding this feature!
 
 ### 2023-02-03
-The installer for MJPG-Streamer got replaced by crowsnest. It is an improved webcam service, utilizing ustreamer.
+The installer for MJPG-Streamer got replaced by crowsnest. It is an improved webcam service, utilizing ustreamer. 
 Please have a look here for additional info about crowsnest and how to configure it: https://github.com/mainsail-crew/crowsnest \
 It's unsure if the previous MJPG-Streamer installer will be updated and make its way back into KIAUH.
 A big thanks to [KwadFan](https://github.com/KwadFan) for writing the crowsnest implementation.
@@ -156,7 +115,7 @@ membership for example caused issues when installing mjpg-streamer while not usi
 Other issues could occur when trying to flash an MCU on Debian or Ubuntu distributions where a user might not be part
 of the dialout group by default. A check for the tty group is also done. The tty group is needed for setting
 up a linux MCU (currently not yet supported by KIAUH).
-* There is an issue when trying to install Mainsail or Fluidd on Ubuntu 21.10. Permissions on that distro seem to have seen a rework
+* There is an issue when trying to install Mainsail or Fluidd on Ubuntu 21.10. Permissions on that distro seem to have seen a rework 
  in comparison to 20.04 and users will be greeted with an "Error 403 - Permission denied" message after installing one of Klippers webinterfaces.
 I still have to figure out a viable solution for that.
 

kiauh.sh

@@ -164,6 +164,7 @@ function main() {
   fi
 }
 
+
 check_if_ratos
 check_euid
 init_logfile
@@ -172,3 +173,4 @@ kiauh_update_dialog
 read_kiauh_ini
 init_ini
 main
+

kiauh/components/crowsnest/crowsnest.py

@@ -28,9 +28,9 @@ from components.crowsnest import (
 from components.klipper.klipper import Klipper
 from core.backup_manager.backup_manager import BackupManager
 from core.constants import CURRENT_USER
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import DialogType, Logger
 from core.settings.kiauh_settings import KiauhSettings
-from core.types import ComponentStatus
 from utils.common import (
     check_install_dependencies,
     get_install_status,
@@ -40,11 +40,11 @@ from utils.git_utils import (
     git_pull_wrapper,
 )
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     cmd_sysctl_service,
     parse_packages_from_file,
 )
+from core.types import ComponentStatus
 
 
 def install_crowsnest() -> None:
@@ -55,7 +55,8 @@ def install_crowsnest() -> None:
     check_install_dependencies({"make"})
 
     # Step 3: Check for Multi Instance
-    instances: List[Klipper] = get_instances(Klipper)
+    im = InstanceManager(Klipper)
+    instances: List[Klipper] = im.instances
 
     if len(instances) > 1:
         print_multi_instance_warning(instances)
@@ -94,7 +95,7 @@ def print_multi_instance_warning(instances: List[Klipper]) -> None:
             "this instance to set up your 'crowsnest.conf' and steering it's service.",
             "\n\n",
             "The following instances were found:",
-            *[f"● {instance.data_dir.name}" for instance in instances],
+            *[f"● {instance.data_dir_name}" for instance in instances],
         ],
     )
 

kiauh/components/klipper/klipper.py

@@ -8,9 +8,9 @@
 # ======================================================================= #
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
-from subprocess import CalledProcessError
+from subprocess import CalledProcessError, run
 
 from components.klipper import (
     KLIPPER_CFG_NAME,
@@ -23,36 +23,29 @@ from components.klipper import (
     KLIPPER_SERVICE_TEMPLATE,
     KLIPPER_UDS_NAME,
 )
-from core.constants import CURRENT_USER
 from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
-from utils.fs_utils import create_folders, get_data_dir
-from utils.sys_utils import get_service_file_path
 
 
 # noinspection PyMethodMayBeStatic
-@dataclass(repr=True)
-class Klipper:
-    suffix: str
-    base: BaseInstance = field(init=False, repr=False)
-    service_file_path: Path = field(init=False)
-    log_file_name: str = KLIPPER_LOG_NAME
+@dataclass
+class Klipper(BaseInstance):
     klipper_dir: Path = KLIPPER_DIR
     env_dir: Path = KLIPPER_ENV_DIR
-    data_dir: Path = field(init=False)
-    cfg_file: Path = field(init=False)
-    serial: Path = field(init=False)
-    uds: Path = field(init=False)
+    cfg_file: Path | None = None
+    log: Path | None = None
+    serial: Path | None = None
+    uds: Path | None = None
 
-    def __post_init__(self):
-        self.base: BaseInstance = BaseInstance(Klipper, self.suffix)
-        self.base.log_file_name = self.log_file_name
+    def __init__(self, suffix: str = "") -> None:
+        super().__init__(suffix=suffix)
 
-        self.service_file_path: Path = get_service_file_path(Klipper, self.suffix)
-        self.data_dir: Path = get_data_dir(Klipper, self.suffix)
-        self.cfg_file: Path = self.base.cfg_dir.joinpath(KLIPPER_CFG_NAME)
-        self.serial: Path = self.base.comms_dir.joinpath(KLIPPER_SERIAL_NAME)
-        self.uds: Path = self.base.comms_dir.joinpath(KLIPPER_UDS_NAME)
+    def __post_init__(self) -> None:
+        super().__post_init__()
+        self.cfg_file = self.cfg_dir.joinpath(KLIPPER_CFG_NAME)
+        self.log = self.log_dir.joinpath(KLIPPER_LOG_NAME)
+        self.serial = self.comms_dir.joinpath(KLIPPER_SERIAL_NAME)
+        self.uds = self.comms_dir.joinpath(KLIPPER_UDS_NAME)
 
     def create(self) -> None:
         from utils.sys_utils import create_env_file, create_service_file
@@ -60,15 +53,15 @@ class Klipper:
         Logger.print_status("Creating new Klipper Instance ...")
 
         try:
-            create_folders(self.base.base_folders)
+            self.create_folders()
 
             create_service_file(
-                name=self.service_file_path.name,
+                name=self.get_service_file_name(extension=True),
                 content=self._prep_service_file_content(),
             )
 
             create_env_file(
-                path=self.base.sysd_dir.joinpath(KLIPPER_ENV_FILE_NAME),
+                path=self.sysd_dir.joinpath(KLIPPER_ENV_FILE_NAME),
                 content=self._prep_env_file_content(),
             )
 
@@ -79,6 +72,21 @@ class Klipper:
             Logger.print_error(f"Error creating env file: {e}")
             raise
 
+    def delete(self) -> None:
+        service_file = self.get_service_file_name(extension=True)
+        service_file_path = self.get_service_file_path()
+
+        Logger.print_status(f"Removing Klipper Instance: {service_file}")
+
+        try:
+            command = ["sudo", "rm", "-f", service_file_path]
+            run(command, check=True)
+            self.delete_logfiles(KLIPPER_LOG_NAME)
+            Logger.print_ok("Instance successfully removed!")
+        except CalledProcessError as e:
+            Logger.print_error(f"Error removing instance: {e}")
+            raise
+
     def _prep_service_file_content(self) -> str:
         template = KLIPPER_SERVICE_TEMPLATE
 
@@ -91,7 +99,7 @@ class Klipper:
 
         service_content = template_content.replace(
             "%USER%",
-            CURRENT_USER,
+            self.user,
         )
         service_content = service_content.replace(
             "%KLIPPER_DIR%",
@@ -103,7 +111,7 @@ class Klipper:
         )
         service_content = service_content.replace(
             "%ENV_FILE%",
-            self.base.sysd_dir.joinpath(KLIPPER_ENV_FILE_NAME).as_posix(),
+            self.sysd_dir.joinpath(KLIPPER_ENV_FILE_NAME).as_posix(),
         )
         return service_content
 
@@ -122,7 +130,7 @@ class Klipper:
         )
         env_file_content = env_file_content.replace(
             "%CFG%",
-            f"{self.base.cfg_dir}/{KLIPPER_CFG_NAME}",
+            f"{self.cfg_dir}/{KLIPPER_CFG_NAME}",
         )
         env_file_content = env_file_content.replace(
             "%SERIAL%",
@@ -130,7 +138,7 @@ class Klipper:
         )
         env_file_content = env_file_content.replace(
             "%LOG%",
-            self.base.log_dir.joinpath(self.log_file_name).as_posix(),
+            self.log.as_posix() if self.log else "",
         )
         env_file_content = env_file_content.replace(
             "%UDS%",

kiauh/components/klipper/klipper_dialogs.py

@@ -17,7 +17,7 @@ from core.constants import (
     COLOR_YELLOW,
     RESET_FORMAT,
 )
-from core.instance_type import InstanceType
+from core.instance_manager.base_instance import BaseInstance
 from core.menus.base_menu import print_back_footer
 
 
@@ -28,7 +28,7 @@ class DisplayType(Enum):
 
 
 def print_instance_overview(
-    instances: List[InstanceType],
+    instances: List[BaseInstance],
     display_type: DisplayType = DisplayType.SERVICE_NAME,
     show_headline=True,
     show_index=False,
@@ -53,7 +53,7 @@ def print_instance_overview(
 
     for i, s in enumerate(instances):
         if display_type is DisplayType.SERVICE_NAME:
-            name = s.service_file_path.stem
+            name = s.get_service_file_name()
         else:
             name = s.data_dir
         line = f"{COLOR_CYAN}{f'{i + start_index})' if show_index else '●'} {name}{RESET_FORMAT}"

kiauh/components/klipper/klipper_remove.py

@@ -17,8 +17,7 @@ from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from utils.fs_utils import run_remove_routines
 from utils.input_utils import get_selection_input
-from utils.instance_utils import get_instances
-from utils.sys_utils import unit_file_exists
+from utils.sys_utils import cmd_sysctl_manage
 
 
 def run_klipper_removal(
@@ -26,17 +25,17 @@ def run_klipper_removal(
     remove_dir: bool,
     remove_env: bool,
 ) -> None:
-    klipper_instances: List[Klipper] = get_instances(Klipper)
+    im = InstanceManager(Klipper)
 
     if remove_service:
         Logger.print_status("Removing Klipper instances ...")
-        if klipper_instances:
-            instances_to_remove = select_instances_to_remove(klipper_instances)
-            remove_instances(instances_to_remove)
+        if im.instances:
+            instances_to_remove = select_instances_to_remove(im.instances)
+            remove_instances(im, instances_to_remove)
         else:
             Logger.print_info("No Klipper Services installed! Skipped ...")
 
-    if (remove_dir or remove_env) and unit_file_exists("klipper", suffix="service"):
+    if (remove_dir or remove_env) and im.instances:
         Logger.print_info("There are still other Klipper services installed:")
         Logger.print_info(f"● '{KLIPPER_DIR}' was not removed.", prefix=False)
         Logger.print_info(f"● '{KLIPPER_ENV_DIR}' was not removed.", prefix=False)
@@ -75,20 +74,26 @@ def select_instances_to_remove(instances: List[Klipper]) -> List[Klipper] | None
 
 
 def remove_instances(
+    instance_manager: InstanceManager,
     instance_list: List[Klipper] | None,
 ) -> None:
     if not instance_list:
         return
 
     for instance in instance_list:
-        Logger.print_status(f"Removing instance {instance.service_file_path.stem} ...")
-        InstanceManager.remove(instance)
+        Logger.print_status(f"Removing instance {instance.get_service_file_name()} ...")
+        instance_manager.current_instance = instance
+        instance_manager.stop_instance()
+        instance_manager.disable_instance()
+        instance_manager.delete_instance()
+
+    cmd_sysctl_manage("daemon-reload")
 
 
 def delete_klipper_logs(instances: List[Klipper]) -> None:
     all_logfiles = []
     for instance in instances:
-        all_logfiles = list(instance.base.log_dir.glob("klippy.log*"))
+        all_logfiles = list(instance.log_dir.glob("klippy.log*"))
     if not all_logfiles:
         Logger.print_info("No Klipper logs found. Skipped ...")
         return

kiauh/components/klipper/klipper_setup.py

@@ -40,10 +40,8 @@ from core.settings.kiauh_settings import KiauhSettings
 from utils.common import check_install_dependencies
 from utils.git_utils import git_clone_wrapper, git_pull_wrapper
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     cmd_sysctl_manage,
-    cmd_sysctl_service,
     create_python_venv,
     install_python_requirements,
     parse_packages_from_file,
@@ -53,8 +51,8 @@ from utils.sys_utils import (
 def install_klipper() -> None:
     Logger.print_status("Installing Klipper ...")
 
-    klipper_list: List[Klipper] = get_instances(Klipper)
-    moonraker_list: List[Moonraker] = get_instances(Moonraker)
+    klipper_list: List[Klipper] = InstanceManager(Klipper).instances
+    moonraker_list: List[Moonraker] = InstanceManager(Moonraker).instances
     match_moonraker: bool = False
 
     # if there are more moonraker instances than klipper instances, ask the user to
@@ -96,7 +94,7 @@ def install_klipper() -> None:
 
 
 def run_klipper_setup(
-    klipper_list: List[Klipper], name_dict: Dict[int, str], create_example_cfg: bool
+    klipper_list: List[Klipper], name_dict: Dict[int, str], example_cfg: bool
 ) -> None:
     if not klipper_list:
         setup_klipper_prerequesites()
@@ -106,16 +104,7 @@ def run_klipper_setup(
         if name_dict[i] in [n.suffix for n in klipper_list]:
             continue
 
-        instance = Klipper(suffix=name_dict[i])
-        instance.create()
-        cmd_sysctl_service(instance.service_file_path.name, "enable")
-
-        if create_example_cfg:
-            # if a client-config is installed, include it in the new example cfg
-            clients = get_existing_clients()
-            create_example_printer_cfg(instance, clients)
-
-        cmd_sysctl_service(instance.service_file_path.name, "start")
+        create_klipper_instance(name_dict[i], example_cfg)
 
     cmd_sysctl_manage("daemon-reload")
 
@@ -200,8 +189,8 @@ def update_klipper() -> None:
     if settings.kiauh.backup_before_update:
         backup_klipper_dir()
 
-    instances = get_instances(Klipper)
-    InstanceManager.stop_all(instances)
+    instance_manager = InstanceManager(Klipper)
+    instance_manager.stop_all_instance()
 
     git_pull_wrapper(repo=settings.klipper.repo_url, target_dir=KLIPPER_DIR)
 
@@ -210,7 +199,20 @@ def update_klipper() -> None:
     # install possible new python dependencies
     install_python_requirements(KLIPPER_ENV_DIR, KLIPPER_REQ_FILE)
 
-    InstanceManager.start_all(instances)
+    instance_manager.start_all_instance()
+
+
+def create_klipper_instance(name: str, create_example_cfg: bool) -> None:
+    kl_im = InstanceManager(Klipper)
+    new_instance = Klipper(suffix=name)
+    kl_im.current_instance = new_instance
+    kl_im.create_instance()
+    kl_im.enable_instance()
+    if create_example_cfg:
+        # if a client-config is installed, include it in the new example cfg
+        clients = get_existing_clients()
+        create_example_printer_cfg(new_instance, clients)
+    kl_im.start_instance()
 
 
 def use_custom_names_or_go_back() -> bool | None:
@@ -229,11 +231,13 @@ def display_moonraker_info(moonraker_list: List[Moonraker]) -> bool:
         DialogType.INFO,
         [
             "Existing Moonraker instances detected:",
-            *[f"● {m.service_file_path.stem}" for m in moonraker_list],
+            *[f"● {m.get_service_file_name()}" for m in moonraker_list],
             "\n\n",
             "The following Klipper instances will be installed:",
             *[f"● klipper-{m.suffix}" for m in moonraker_list],
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
     _input: bool = get_confirm("Proceed with installation?")
     return _input

kiauh/components/klipper/klipper_utils.py

@@ -31,16 +31,15 @@ from components.webui_client.client_config.client_config_setup import (
 )
 from core.backup_manager.backup_manager import BackupManager
 from core.constants import CURRENT_USER
-from core.instance_manager.base_instance import SUFFIX_BLACKLIST
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import DialogType, Logger
 from core.submodules.simple_config_parser.src.simple_config_parser.simple_config_parser import (
     SimpleConfigParser,
 )
-from core.types import ComponentStatus
 from utils.common import get_install_status
 from utils.input_utils import get_confirm, get_number_input, get_string_input
-from utils.instance_utils import get_instances
 from utils.sys_utils import cmd_sysctl_service
+from core.types import ComponentStatus
 
 
 def get_klipper_status() -> ComponentStatus:
@@ -48,7 +47,7 @@ def get_klipper_status() -> ComponentStatus:
 
 
 def add_to_existing() -> bool | None:
-    kl_instances: List[Klipper] = get_instances(Klipper)
+    kl_instances: List[Klipper] = InstanceManager(Klipper).instances
     print_instance_overview(kl_instances)
     _input: bool | None = get_confirm("Add new instances?", allow_go_back=True)
     return _input
@@ -61,7 +60,7 @@ def get_install_count() -> int | None:
     user selected to go back, otherwise an integer greater or equal than 1 |
     :return: Integer >= 1 or None
     """
-    kl_instances = get_instances(Klipper)
+    kl_instances = InstanceManager(Klipper).instances
     print_select_instance_count_dialog()
     question = (
         f"Number of"
@@ -74,7 +73,7 @@ def get_install_count() -> int | None:
 
 def assign_custom_name(key: int, name_dict: Dict[int, str]) -> None:
     existing_names = []
-    existing_names.extend(SUFFIX_BLACKLIST)
+    existing_names.extend(Klipper.blacklist())
     existing_names.extend(name_dict[n] for n in name_dict)
     pattern = r"^[a-zA-Z0-9]+$"
 
@@ -103,6 +102,7 @@ def check_user_groups() -> None:
             "INFO:",
             "Relog required for group assignments to take effect!",
         ],
+        padding_bottom=0,
     )
 
     if not get_confirm(f"Add user '{CURRENT_USER}' to group(s) now?"):
@@ -160,7 +160,7 @@ def handle_disruptive_system_packages() -> None:
 def create_example_printer_cfg(
     instance: Klipper, clients: List[BaseWebClient] | None = None
 ) -> None:
-    Logger.print_status(f"Creating example printer.cfg in '{instance.base.cfg_dir}'")
+    Logger.print_status(f"Creating example printer.cfg in '{instance.cfg_dir}'")
     if instance.cfg_file.is_file():
         Logger.print_info(f"'{instance.cfg_file}' already exists.")
         return
@@ -175,7 +175,7 @@ def create_example_printer_cfg(
 
     scp = SimpleConfigParser()
     scp.read(target)
-    scp.set("virtual_sdcard", "path", str(instance.base.gcodes_dir))
+    scp.set("virtual_sdcard", "path", str(instance.gcodes_dir))
 
     # include existing client configs in the example config
     if clients is not None and len(clients) > 0:
@@ -187,7 +187,7 @@ def create_example_printer_cfg(
 
     scp.write(target)
 
-    Logger.print_ok(f"Example printer.cfg created in '{instance.base.cfg_dir}'")
+    Logger.print_ok(f"Example printer.cfg created in '{instance.cfg_dir}'")
 
 
 def backup_klipper_dir() -> None:

kiauh/components/klipper/menus/klipper_remove_menu.py

@@ -35,11 +35,11 @@ class KlipperRemoveMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "a": Option(method=self.toggle_all),
-            "1": Option(method=self.toggle_remove_klipper_service),
-            "2": Option(method=self.toggle_remove_klipper_dir),
-            "3": Option(method=self.toggle_remove_klipper_env),
-            "c": Option(method=self.run_removal_process),
+            "a": Option(method=self.toggle_all, menu=False),
+            "1": Option(method=self.toggle_remove_klipper_service, menu=False),
+            "2": Option(method=self.toggle_remove_klipper_dir, menu=False),
+            "3": Option(method=self.toggle_remove_klipper_env, menu=False),
+            "c": Option(method=self.run_removal_process, menu=False),
         }
 
     def print_menu(self) -> None:

kiauh/components/klipper_firmware/firmware_utils.py

@@ -19,7 +19,6 @@ from components.klipper_firmware.flash_options import (
 )
 from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
-from utils.instance_utils import get_instances
 from utils.sys_utils import log_process
 
 
@@ -118,13 +117,13 @@ def start_flash_process(flash_options: FlashOptions) -> None:
         else:
             raise Exception("Invalid value for flash_method!")
 
-        instances = get_instances(Klipper)
-        InstanceManager.stop_all(instances)
+        instance_manager = InstanceManager(Klipper)
+        instance_manager.stop_all_instance()
 
         process = Popen(cmd, cwd=KLIPPER_DIR, stdout=PIPE, stderr=STDOUT, text=True)
         log_process(process)
 
-        InstanceManager.start_all(instances)
+        instance_manager.start_all_instance()
 
         rc = process.returncode
         if rc != 0:

kiauh/components/klipper_firmware/menus/klipper_build_menu.py

@@ -47,10 +47,10 @@ class KlipperBuildFirmwareMenu(BaseMenu):
     def set_options(self) -> None:
         if len(self.missing_deps) == 0:
             self.input_label_txt = "Press ENTER to continue"
-            self.default_option = Option(method=self.start_build_process)
+            self.default_option = Option(method=self.start_build_process, menu=False)
         else:
             self.input_label_txt = "Press ENTER to install dependencies"
-            self.default_option = Option(method=self.install_missing_deps)
+            self.default_option = Option(method=self.install_missing_deps, menu=False)
 
     def print_menu(self) -> None:
         header = " [ Build Firmware Menu ] "

kiauh/components/klipper_firmware/menus/klipper_flash_error_menu.py

@@ -32,7 +32,7 @@ class KlipperNoFirmwareErrorMenu(BaseMenu):
         self.previous_menu = previous_menu
 
     def set_options(self) -> None:
-        self.default_option = Option(method=self.go_back)
+        self.default_option = Option(self.go_back, False)
 
     def print_menu(self) -> None:
         header = "!!! NO FIRMWARE FILE FOUND !!!"
@@ -79,7 +79,7 @@ class KlipperNoBoardTypesErrorMenu(BaseMenu):
         self.previous_menu = previous_menu
 
     def set_options(self) -> None:
-        self.default_option = Option(method=self.go_back)
+        self.default_option = Option(self.go_back, False)
 
     def print_menu(self) -> None:
         header = "!!! ERROR GETTING BOARD LIST !!!"

kiauh/components/klipper_firmware/menus/klipper_flash_menu.py

@@ -61,8 +61,8 @@ class KlipperFlashMethodMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(self.select_regular),
-            "2": Option(self.select_sdcard),
+            "1": Option(self.select_regular, menu=False),
+            "2": Option(self.select_sdcard, menu=False),
         }
 
     def print_menu(self) -> None:
@@ -123,10 +123,10 @@ class KlipperFlashCommandMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(self.select_flash),
-            "2": Option(self.select_serialflash),
+            "1": Option(self.select_flash, menu=False),
+            "2": Option(self.select_serialflash, menu=False),
         }
-        self.default_option = Option(self.select_flash)
+        self.default_option = Option(self.select_flash, menu=False)
 
     def print_menu(self) -> None:
         menu = textwrap.dedent(
@@ -174,9 +174,9 @@ class KlipperSelectMcuConnectionMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.select_usb),
-            "2": Option(method=self.select_dfu),
-            "3": Option(method=self.select_usb_dfu),
+            "1": Option(method=self.select_usb, menu=False),
+            "2": Option(method=self.select_dfu, menu=False),
+            "3": Option(method=self.select_usb_dfu, menu=False),
         }
 
     def print_menu(self) -> None:
@@ -260,7 +260,8 @@ class KlipperSelectMcuIdMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            f"{i}": Option(self.flash_mcu, f"{i}") for i in range(len(self.mcu_list))
+            f"{i}": Option(self.flash_mcu, False, f"{i}")
+            for i in range(len(self.mcu_list))
         }
 
     def print_menu(self) -> None:
@@ -322,7 +323,7 @@ class KlipperSelectSDFlashBoardMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            f"{i}": Option(self.board_select, f"{i}")
+            f"{i}": Option(self.board_select, False, f"{i}")
             for i in range(len(self.available_boards))
         }
 
@@ -392,11 +393,11 @@ class KlipperFlashOverviewMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "Y": Option(self.execute_flash),
-            "N": Option(self.abort_process),
+            "Y": Option(self.execute_flash, menu=False),
+            "N": Option(self.abort_process, menu=False),
         }
 
-        self.default_option = Option(self.execute_flash)
+        self.default_option = Option(self.execute_flash, menu=False)
 
     def print_menu(self) -> None:
         header = "!!! ATTENTION !!!"

kiauh/components/klipperscreen/klipperscreen.py

@@ -42,7 +42,6 @@ from utils.git_utils import (
     git_pull_wrapper,
 )
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     check_python_version,
     cmd_sysctl_service,
@@ -57,7 +56,8 @@ def install_klipperscreen() -> None:
     if not check_python_version(3, 7):
         return
 
-    mr_instances = get_instances(Moonraker)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances = mr_im.instances
     if not mr_instances:
         Logger.print_dialog(
             DialogType.WARNING,
@@ -68,6 +68,8 @@ def install_klipperscreen() -> None:
                 "KlipperScreens update manager configuration for Moonraker "
                 "will not be added to any moonraker.conf.",
             ],
+            padding_top=0,
+            padding_bottom=0,
         )
         if not get_confirm(
             "Continue KlipperScreen installation?",
@@ -84,7 +86,7 @@ def install_klipperscreen() -> None:
         run(KLIPPERSCREEN_INSTALL_SCRIPT.as_posix(), shell=True, check=True)
         if mr_instances:
             patch_klipperscreen_update_manager(mr_instances)
-            InstanceManager.restart_all(mr_instances)
+            mr_im.restart_all_instance()
         else:
             Logger.print_info(
                 "Moonraker is not installed! Cannot add "
@@ -172,15 +174,17 @@ def remove_klipperscreen() -> None:
             remove_with_sudo(logfile)
             Logger.print_ok("KlipperScreen log file successfully removed!")
 
-        kl_instances: List[Klipper] = get_instances(Klipper)
+        kl_im = InstanceManager(Klipper)
+        kl_instances: List[Klipper] = kl_im.instances
         for instance in kl_instances:
-            logfile = instance.base.log_dir.joinpath(KLIPPERSCREEN_LOG_NAME)
+            logfile = instance.log_dir.joinpath(KLIPPERSCREEN_LOG_NAME)
             if logfile.exists():
                 Logger.print_status(f"Removing {logfile} ...")
                 Path(logfile).unlink()
                 Logger.print_ok(f"{logfile} successfully removed!")
 
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
         if mr_instances:
             Logger.print_status("Removing KlipperScreen from update manager ...")
             remove_config_section("update_manager KlipperScreen", mr_instances)

kiauh/components/log_uploads/log_upload_utils.py

@@ -13,14 +13,13 @@ from typing import List
 
 from components.klipper.klipper import Klipper
 from components.log_uploads import LogFile
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
-from utils.instance_utils import get_instances
 
 
 def get_logfile_list() -> List[LogFile]:
-    log_dirs: List[Path] = [
-        instance.base.log_dir for instance in get_instances(Klipper)
-    ]
+    cm = InstanceManager(Klipper)
+    log_dirs: List[Path] = [instance.log_dir for instance in cm.instances]
 
     logfiles: List[LogFile] = []
     for _dir in log_dirs:

kiauh/components/log_uploads/menus/log_upload_menu.py

@@ -32,7 +32,7 @@ class LogUploadMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            f"{index}": Option(self.upload, opt_index=f"{index}")
+            f"{index}": Option(self.upload, False, opt_index=f"{index}")
             for index in range(len(self.logfile_list))
         }
 

kiauh/components/mobileraker/mobileraker.py

@@ -37,7 +37,6 @@ from utils.git_utils import (
     git_pull_wrapper,
 )
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     check_python_version,
     cmd_sysctl_service,
@@ -52,7 +51,8 @@ def install_mobileraker() -> None:
     if not check_python_version(3, 7):
         return
 
-    mr_instances = get_instances(Moonraker)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances = mr_im.instances
     if not mr_instances:
         Logger.print_dialog(
             DialogType.WARNING,
@@ -78,7 +78,7 @@ def install_mobileraker() -> None:
         run(MOBILERAKER_INSTALL_SCRIPT.as_posix(), shell=True, check=True)
         if mr_instances:
             patch_mobileraker_update_manager(mr_instances)
-            InstanceManager.restart_all(mr_instances)
+            mr_im.restart_all_instance()
         else:
             Logger.print_info(
                 "Moonraker is not installed! Cannot add Mobileraker's "
@@ -163,15 +163,17 @@ def remove_mobileraker() -> None:
         if MOBILERAKER_SERVICE_FILE.exists():
             remove_system_service(MOBILERAKER_SERVICE_NAME)
 
-        kl_instances: List[Klipper] = get_instances(Klipper)
+        kl_im = InstanceManager(Klipper)
+        kl_instances: List[Klipper] = kl_im.instances
         for instance in kl_instances:
-            logfile = instance.base.log_dir.joinpath(MOBILERAKER_LOG_NAME)
+            logfile = instance.log_dir.joinpath(MOBILERAKER_LOG_NAME)
             if logfile.exists():
                 Logger.print_status(f"Removing {logfile} ...")
                 Path(logfile).unlink()
                 Logger.print_ok(f"{logfile} successfully removed!")
 
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
         if mr_instances:
             Logger.print_status(
                 "Removing Mobileraker's companion from update manager ..."

kiauh/components/moonraker/menus/moonraker_remove_menu.py

@@ -35,12 +35,12 @@ class MoonrakerRemoveMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "a": Option(method=self.toggle_all),
-            "1": Option(method=self.toggle_remove_moonraker_service),
-            "2": Option(method=self.toggle_remove_moonraker_dir),
-            "3": Option(method=self.toggle_remove_moonraker_env),
-            "4": Option(method=self.toggle_remove_moonraker_polkit),
-            "c": Option(method=self.run_removal_process),
+            "a": Option(method=self.toggle_all, menu=False),
+            "1": Option(method=self.toggle_remove_moonraker_service, menu=False),
+            "2": Option(method=self.toggle_remove_moonraker_dir, menu=False),
+            "3": Option(method=self.toggle_remove_moonraker_env, menu=False),
+            "4": Option(method=self.toggle_remove_moonraker_polkit, menu=False),
+            "c": Option(method=self.run_removal_process, menu=False),
         }
 
     def print_menu(self) -> None:

kiauh/components/moonraker/moonraker.py

@@ -8,11 +8,10 @@
 # ======================================================================= #
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
-from subprocess import CalledProcessError
+from subprocess import CalledProcessError, run
 
-from components.klipper.klipper import Klipper
 from components.moonraker import (
     MOONRAKER_CFG_NAME,
     MOONRAKER_DIR,
@@ -22,58 +21,50 @@ from components.moonraker import (
     MOONRAKER_LOG_NAME,
     MOONRAKER_SERVICE_TEMPLATE,
 )
-from core.constants import CURRENT_USER
 from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
 from core.submodules.simple_config_parser.src.simple_config_parser.simple_config_parser import (
     SimpleConfigParser,
 )
-from utils.fs_utils import create_folders
-from utils.sys_utils import get_service_file_path
 
 
 # noinspection PyMethodMayBeStatic
 @dataclass
-class Moonraker:
-    suffix: str
-    base: BaseInstance = field(init=False, repr=False)
-    service_file_path: Path = field(init=False)
-    log_file_name: str = MOONRAKER_LOG_NAME
+class Moonraker(BaseInstance):
     moonraker_dir: Path = MOONRAKER_DIR
     env_dir: Path = MOONRAKER_ENV_DIR
-    data_dir: Path = field(init=False)
-    cfg_file: Path = field(init=False)
-    backup_dir: Path = field(init=False)
-    certs_dir: Path = field(init=False)
-    db_dir: Path = field(init=False)
-    port: int | None = field(init=False)
+    cfg_file: Path | None = None
+    port: int | None = None
+    backup_dir: Path | None = None
+    certs_dir: Path | None = None
+    db_dir: Path | None = None
+    log: Path | None = None
 
-    def __post_init__(self):
-        self.base: BaseInstance = BaseInstance(Klipper, self.suffix)
-        self.base.log_file_name = self.log_file_name
+    def __init__(self, suffix: str = ""):
+        super().__init__(suffix=suffix)
 
-        self.service_file_path: Path = get_service_file_path(Moonraker, self.suffix)
-        self.data_dir: Path = self.base.data_dir
-        self.cfg_file: Path = self.base.cfg_dir.joinpath(MOONRAKER_CFG_NAME)
-        self.backup_dir: Path = self.base.data_dir.joinpath("backup")
-        self.certs_dir: Path = self.base.data_dir.joinpath("certs")
-        self.db_dir: Path = self.base.data_dir.joinpath("database")
-        self.port: int | None = self._get_port()
+    def __post_init__(self) -> None:
+        super().__post_init__()
+        self.cfg_file = self.cfg_dir.joinpath(MOONRAKER_CFG_NAME)
+        self.port = self._get_port()
+        self.backup_dir = self.data_dir.joinpath("backup")
+        self.certs_dir = self.data_dir.joinpath("certs")
+        self.db_dir = self.data_dir.joinpath("database")
+        self.log = self.log_dir.joinpath(MOONRAKER_LOG_NAME)
 
-    def create(self) -> None:
+    def create(self, create_example_cfg: bool = False) -> None:
         from utils.sys_utils import create_env_file, create_service_file
 
         Logger.print_status("Creating new Moonraker Instance ...")
 
         try:
-            create_folders(self.base.base_folders)
-
+            self.create_folders([self.backup_dir, self.certs_dir, self.db_dir])
             create_service_file(
-                name=self.service_file_path.name,
+                name=self.get_service_file_name(extension=True),
                 content=self._prep_service_file_content(),
             )
             create_env_file(
-                path=self.base.sysd_dir.joinpath(MOONRAKER_ENV_FILE_NAME),
+                path=self.sysd_dir.joinpath(MOONRAKER_ENV_FILE_NAME),
                 content=self._prep_env_file_content(),
             )
 
@@ -84,6 +75,21 @@ class Moonraker:
             Logger.print_error(f"Error creating env file: {e}")
             raise
 
+    def delete(self) -> None:
+        service_file = self.get_service_file_name(extension=True)
+        service_file_path = self.get_service_file_path()
+
+        Logger.print_status(f"Removing Moonraker Instance: {service_file}")
+
+        try:
+            command = ["sudo", "rm", "-f", service_file_path]
+            run(command, check=True)
+            self.delete_logfiles(MOONRAKER_LOG_NAME)
+            Logger.print_ok("Instance successfully removed!")
+        except CalledProcessError as e:
+            Logger.print_error(f"Error removing instance: {e}")
+            raise
+
     def _prep_service_file_content(self) -> str:
         template = MOONRAKER_SERVICE_TEMPLATE
 
@@ -96,7 +102,7 @@ class Moonraker:
 
         service_content = template_content.replace(
             "%USER%",
-            CURRENT_USER,
+            self.user,
         )
         service_content = service_content.replace(
             "%MOONRAKER_DIR%",
@@ -108,7 +114,7 @@ class Moonraker:
         )
         service_content = service_content.replace(
             "%ENV_FILE%",
-            self.base.sysd_dir.joinpath(MOONRAKER_ENV_FILE_NAME).as_posix(),
+            self.sysd_dir.joinpath(MOONRAKER_ENV_FILE_NAME).as_posix(),
         )
         return service_content
 
@@ -128,7 +134,7 @@ class Moonraker:
         )
         env_file_content = env_file_content.replace(
             "%PRINTER_DATA%",
-            self.base.data_dir.as_posix(),
+            self.data_dir.as_posix(),
         )
 
         return env_file_content

kiauh/components/moonraker/moonraker_dialogs.py

@@ -37,8 +37,8 @@ def print_moonraker_overview(
         dialog += "║                                                       ║\n"
 
     instance_map = {
-        k.service_file_path.stem: (
-            k.service_file_path.stem.replace("klipper", "moonraker")
+        k.get_service_file_name(): (
+            k.get_service_file_name().replace("klipper", "moonraker")
             if k.suffix in [m.suffix for m in moonraker_instances]
             else ""
         )

kiauh/components/moonraker/moonraker_remove.py

@@ -18,8 +18,7 @@ from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from utils.fs_utils import run_remove_routines
 from utils.input_utils import get_selection_input
-from utils.instance_utils import get_instances
-from utils.sys_utils import unit_file_exists
+from utils.sys_utils import cmd_sysctl_manage
 
 
 def run_moonraker_removal(
@@ -28,18 +27,17 @@ def run_moonraker_removal(
     remove_env: bool,
     remove_polkit: bool,
 ) -> None:
-    instances = get_instances(Moonraker)
+    im = InstanceManager(Moonraker)
 
     if remove_service:
         Logger.print_status("Removing Moonraker instances ...")
-        if instances:
-            instances_to_remove = select_instances_to_remove(instances)
-            remove_instances(instances_to_remove)
+        if im.instances:
+            instances_to_remove = select_instances_to_remove(im.instances)
+            remove_instances(im, instances_to_remove)
         else:
             Logger.print_info("No Moonraker Services installed! Skipped ...")
 
-    delete_remaining: bool = remove_polkit or remove_dir or remove_env
-    if delete_remaining and unit_file_exists("moonraker", suffix="service"):
+    if (remove_polkit or remove_dir or remove_env) and im.instances:
         Logger.print_info("There are still other Moonraker services installed")
         Logger.print_info(
             "●  Moonraker PolicyKit rules were not removed.", prefix=False
@@ -86,14 +84,20 @@ def select_instances_to_remove(
 
 
 def remove_instances(
+    instance_manager: InstanceManager,
     instance_list: List[Moonraker] | None,
 ) -> None:
     if not instance_list:
         Logger.print_info("No Moonraker instances found. Skipped ...")
         return
     for instance in instance_list:
-        Logger.print_status(f"Removing instance {instance.service_file_path.stem} ...")
-        InstanceManager.remove(instance)
+        Logger.print_status(f"Removing instance {instance.get_service_file_name()} ...")
+        instance_manager.current_instance = instance
+        instance_manager.stop_instance()
+        instance_manager.disable_instance()
+        instance_manager.delete_instance()
+
+    cmd_sysctl_manage("daemon-reload")
 
 
 def remove_polkit_rules() -> None:
@@ -114,7 +118,7 @@ def remove_polkit_rules() -> None:
 def delete_moonraker_logs(instances: List[Moonraker]) -> None:
     all_logfiles = []
     for instance in instances:
-        all_logfiles = list(instance.base.log_dir.glob("moonraker.log*"))
+        all_logfiles = list(instance.log_dir.glob("moonraker.log*"))
     if not all_logfiles:
         Logger.print_info("No Moonraker logs found. Skipped ...")
         return

kiauh/components/moonraker/moonraker_setup.py

@@ -47,11 +47,9 @@ from utils.input_utils import (
     get_confirm,
     get_selection_input,
 )
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     check_python_version,
     cmd_sysctl_manage,
-    cmd_sysctl_service,
     create_python_venv,
     install_python_requirements,
     parse_packages_from_file,
@@ -59,17 +57,18 @@ from utils.sys_utils import (
 
 
 def install_moonraker() -> None:
-    klipper_list: List[Klipper] = get_instances(Klipper)
-
-    if not check_moonraker_install_requirements(klipper_list):
+    if not check_moonraker_install_requirements():
         return
 
-    moonraker_list: List[Moonraker] = get_instances(Moonraker)
-    instances: List[Moonraker] = []
+    klipper_list: List[Klipper] = InstanceManager(Klipper).instances
+    mr_im = InstanceManager(Moonraker)
+    moonraker_list: List[Moonraker] = mr_im.instances
+
+    instance_names = []
     selected_option: str | Klipper
 
-    if len(klipper_list) == 1:
-        instances.append(Moonraker(klipper_list[0].suffix))
+    if len(klipper_list) == 0:
+        instance_names.append(klipper_list[0].suffix)
     else:
         print_moonraker_overview(
             klipper_list,
@@ -88,12 +87,12 @@ def install_moonraker() -> None:
             return
 
         if selected_option == "a":
-            instances.extend([Moonraker(k.suffix) for k in klipper_list])
+            instance_names.extend([k.suffix for k in klipper_list])
         else:
             klipper_instance: Klipper | None = options.get(selected_option)
             if klipper_instance is None:
                 raise Exception("Error selecting instance!")
-            instances.append(Moonraker(klipper_instance.suffix))
+            instance_names.append(klipper_instance.suffix)
 
     create_example_cfg = get_confirm("Create example moonraker.conf?")
 
@@ -103,23 +102,26 @@ def install_moonraker() -> None:
         install_moonraker_polkit()
 
         used_ports_map = {m.suffix: m.port for m in moonraker_list}
-        for instance in instances:
-            instance.create()
-            cmd_sysctl_service(instance.service_file_path.name, "enable")
+        for name in instance_names:
+            current_instance = Moonraker(suffix=name)
+
+            mr_im.current_instance = current_instance
+            mr_im.create_instance()
+            mr_im.enable_instance()
 
             if create_example_cfg:
                 # if a webclient and/or it's config is installed, patch
                 # its update section to the config
                 clients = get_existing_clients()
-                create_example_moonraker_conf(instance, used_ports_map, clients)
+                create_example_moonraker_conf(current_instance, used_ports_map, clients)
 
-            cmd_sysctl_service(instance.service_file_path.name, "start")
+            mr_im.start_instance()
 
         cmd_sysctl_manage("daemon-reload")
 
         # if mainsail is installed, and we installed
         # multiple moonraker instances, we enable mainsails remote mode
-        if MainsailData().client_dir.exists() and len(moonraker_list) > 1:
+        if MainsailData().client_dir.exists() and len(mr_im.instances) > 1:
             enable_mainsail_remotemode()
 
     except Exception as e:
@@ -127,9 +129,9 @@ def install_moonraker() -> None:
         return
 
 
-def check_moonraker_install_requirements(klipper_list: List[Klipper]) -> bool:
+def check_moonraker_install_requirements() -> bool:
     def check_klipper_instances() -> bool:
-        if len(klipper_list) >= 1:
+        if len(InstanceManager(Klipper).instances) >= 1:
             return True
 
         Logger.print_warn("Klipper not installed!")
@@ -206,8 +208,8 @@ def update_moonraker() -> None:
     if settings.kiauh.backup_before_update:
         backup_moonraker_dir()
 
-    instances = get_instances(Moonraker)
-    InstanceManager.stop_all(instances)
+    instance_manager = InstanceManager(Moonraker)
+    instance_manager.stop_all_instance()
 
     git_pull_wrapper(repo=settings.moonraker.repo_url, target_dir=MOONRAKER_DIR)
 
@@ -216,4 +218,4 @@ def update_moonraker() -> None:
     # install possible new python dependencies
     install_python_requirements(MOONRAKER_ENV_DIR, MOONRAKER_REQ_FILE)
 
-    InstanceManager.start_all(instances)
+    instance_manager.start_all_instance()

kiauh/components/moonraker/moonraker_utils.py

@@ -21,16 +21,16 @@ from components.moonraker import (
 from components.moonraker.moonraker import Moonraker
 from components.webui_client.base_data import BaseWebClient
 from core.backup_manager.backup_manager import BackupManager
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from core.submodules.simple_config_parser.src.simple_config_parser.simple_config_parser import (
     SimpleConfigParser,
 )
-from core.types import ComponentStatus
 from utils.common import get_install_status
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     get_ipv4_addr,
 )
+from core.types import ComponentStatus
 
 
 def get_moonraker_status() -> ComponentStatus:
@@ -42,7 +42,7 @@ def create_example_moonraker_conf(
     ports_map: Dict[str, int],
     clients: Optional[List[BaseWebClient]] = None,
 ) -> None:
-    Logger.print_status(f"Creating example moonraker.conf in '{instance.base.cfg_dir}'")
+    Logger.print_status(f"Creating example moonraker.conf in '{instance.cfg_dir}'")
     if instance.cfg_file.is_file():
         Logger.print_info(f"'{instance.cfg_file}' already exists.")
         return
@@ -74,7 +74,7 @@ def create_example_moonraker_conf(
 
     ip = get_ipv4_addr().split(".")[:2]
     ip.extend(["0", "0/16"])
-    uds = instance.base.comms_dir.joinpath("klippy.sock")
+    uds = instance.comms_dir.joinpath("klippy.sock")
 
     scp = SimpleConfigParser()
     scp.read(target)
@@ -123,7 +123,7 @@ def create_example_moonraker_conf(
                     scp.set(c_config_section, option[0], option[1])
 
     scp.write(target)
-    Logger.print_ok(f"Example moonraker.conf created in '{instance.base.cfg_dir}'")
+    Logger.print_ok(f"Example moonraker.conf created in '{instance.cfg_dir}'")
 
 
 def backup_moonraker_dir() -> None:
@@ -135,11 +135,12 @@ def backup_moonraker_dir() -> None:
 
 
 def backup_moonraker_db_dir() -> None:
-    instances: List[Moonraker] = get_instances(Moonraker)
+    im = InstanceManager(Moonraker)
+    instances: List[Moonraker] = im.instances
     bm = BackupManager()
 
     for instance in instances:
-        name = f"database-{instance.data_dir.name}"
+        name = f"database-{instance.data_dir_name}"
         bm.backup_directory(
             name, source=instance.db_dir, target=MOONRAKER_DB_BACKUP_DIR
         )

kiauh/components/octoeverywhere/octoeverywhere.py

@@ -8,57 +8,48 @@
 # ======================================================================= #
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
 from subprocess import CalledProcessError, run
 
 from components.moonraker import MOONRAKER_CFG_NAME
-from components.moonraker.moonraker import Moonraker
 from components.octoeverywhere import (
     OE_CFG_NAME,
     OE_DIR,
     OE_ENV_DIR,
     OE_INSTALL_SCRIPT,
     OE_LOG_NAME,
+    OE_STORE_DIR,
     OE_SYS_CFG_NAME,
     OE_UPDATE_SCRIPT,
 )
 from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
-from utils.sys_utils import get_service_file_path
 
 
 @dataclass
-class Octoeverywhere:
-    suffix: str
-    base: BaseInstance = field(init=False, repr=False)
-    service_file_path: Path = field(init=False)
-    log_file_name = OE_LOG_NAME
+class Octoeverywhere(BaseInstance):
     dir: Path = OE_DIR
     env_dir: Path = OE_ENV_DIR
-    data_dir: Path = field(init=False)
-    store_dir: Path = field(init=False)
-    cfg_file: Path = field(init=False)
-    sys_cfg_file: Path = field(init=False)
+    store_dir: Path = OE_STORE_DIR
+    cfg_file: Path | None = None
+    sys_cfg_file: Path | None = None
+    log: Path | None = None
+
+    def __init__(self, suffix: str = ""):
+        super().__init__(suffix=suffix)
 
     def __post_init__(self):
-        self.base: BaseInstance = BaseInstance(Moonraker, self.suffix)
-        self.base.log_file_name = self.log_file_name
-
-        self.service_file_path: Path = get_service_file_path(
-            Octoeverywhere, self.suffix
-        )
-        self.store_dir = self.base.data_dir.joinpath("store")
-        self.cfg_file = self.base.cfg_dir.joinpath(OE_CFG_NAME)
-        self.sys_cfg_file = self.base.cfg_dir.joinpath(OE_SYS_CFG_NAME)
-        self.data_dir = self.base.data_dir
-        self.sys_cfg_file = self.base.cfg_dir.joinpath(OE_SYS_CFG_NAME)
+        super().__post_init__()
+        self.cfg_file = self.cfg_dir.joinpath(OE_CFG_NAME)
+        self.sys_cfg_file = self.cfg_dir.joinpath(OE_SYS_CFG_NAME)
+        self.log = self.log_dir.joinpath(OE_LOG_NAME)
 
     def create(self) -> None:
         Logger.print_status("Creating OctoEverywhere for Klipper Instance ...")
 
         try:
-            cmd = f"{OE_INSTALL_SCRIPT} {self.base.cfg_dir}/{MOONRAKER_CFG_NAME}"
+            cmd = f"{OE_INSTALL_SCRIPT} {self.cfg_dir}/{MOONRAKER_CFG_NAME}"
             run(cmd, check=True, shell=True)
 
         except CalledProcessError as e:
@@ -73,3 +64,20 @@ class Octoeverywhere:
         except CalledProcessError as e:
             Logger.print_error(f"Error updating OctoEverywhere for Klipper: {e}")
             raise
+
+    def delete(self) -> None:
+        service_file: str = self.get_service_file_name(extension=True)
+        service_file_path: Path = self.get_service_file_path()
+
+        Logger.print_status(
+            f"Deleting OctoEverywhere for Klipper Instance: {service_file}"
+        )
+
+        try:
+            command = ["sudo", "rm", "-f", service_file_path.as_posix()]
+            run(command, check=True)
+            self.delete_logfiles(OE_LOG_NAME)
+            Logger.print_ok(f"Service file deleted: {service_file_path}")
+        except CalledProcessError as e:
+            Logger.print_error(f"Error deleting service file: {e}")
+            raise

kiauh/components/octoeverywhere/octoeverywhere_setup.py

@@ -23,7 +23,6 @@ from components.octoeverywhere import (
 from components.octoeverywhere.octoeverywhere import Octoeverywhere
 from core.instance_manager.instance_manager import InstanceManager
 from core.logger import DialogType, Logger
-from core.types import ComponentStatus
 from utils.common import (
     check_install_dependencies,
     get_install_status,
@@ -35,11 +34,12 @@ from utils.config_utils import (
 from utils.fs_utils import run_remove_routines
 from utils.git_utils import git_clone_wrapper
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
+    cmd_sysctl_manage,
     install_python_requirements,
     parse_packages_from_file,
 )
+from core.types import ComponentStatus
 
 
 def get_octoeverywhere_status() -> ComponentStatus:
@@ -54,7 +54,8 @@ def install_octoeverywhere() -> None:
         return
 
     force_clone = False
-    oe_instances: List[Octoeverywhere] = get_instances(Octoeverywhere)
+    oe_im = InstanceManager(Octoeverywhere)
+    oe_instances: List[Octoeverywhere] = oe_im.instances
     if oe_instances:
         Logger.print_dialog(
             DialogType.INFO,
@@ -63,6 +64,8 @@ def install_octoeverywhere() -> None:
                 "It is safe to run the installer again to link your "
                 "printer or repair any issues.",
             ],
+            padding_top=0,
+            padding_bottom=0,
         )
         if not get_confirm("Re-run OctoEverywhere installation?"):
             Logger.print_info("Exiting OctoEverywhere for Klipper installation ...")
@@ -71,9 +74,10 @@ def install_octoeverywhere() -> None:
             Logger.print_status("Re-Installing OctoEverywhere for Klipper ...")
             force_clone = True
 
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
 
-    mr_names = [f"● {moonraker.data_dir.name}" for moonraker in mr_instances]
+    mr_names = [f"● {moonraker.data_dir_name}" for moonraker in mr_instances]
     if len(mr_names) > 1:
         Logger.print_dialog(
             DialogType.INFO,
@@ -83,6 +87,8 @@ def install_octoeverywhere() -> None:
                 "\n\n",
                 "The setup will apply the same names to OctoEverywhere!",
             ],
+            padding_top=0,
+            padding_bottom=0,
         )
 
     if not get_confirm(
@@ -97,10 +103,10 @@ def install_octoeverywhere() -> None:
         git_clone_wrapper(OE_REPO, OE_DIR, force=force_clone)
 
         for moonraker in mr_instances:
-            instance = Octoeverywhere(suffix=moonraker.suffix)
-            instance.create()
+            oe_im.current_instance = Octoeverywhere(suffix=moonraker.suffix)
+            oe_im.create_instance()
 
-        InstanceManager.restart_all(mr_instances)
+        mr_im.restart_all_instance()
 
         Logger.print_dialog(
             DialogType.SUCCESS,
@@ -130,12 +136,13 @@ def update_octoeverywhere() -> None:
 
 def remove_octoeverywhere() -> None:
     Logger.print_status("Removing OctoEverywhere for Klipper ...")
-
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
-    ob_instances: List[Octoeverywhere] = get_instances(Octoeverywhere)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
+    ob_im = InstanceManager(Octoeverywhere)
+    ob_instances: List[Octoeverywhere] = ob_im.instances
 
     try:
-        remove_oe_instances(ob_instances)
+        remove_oe_instances(ob_im, ob_instances)
         remove_oe_dir()
         remove_oe_env()
         remove_config_section(f"include {OE_SYS_CFG_NAME}", mr_instances)
@@ -166,6 +173,7 @@ def install_oe_dependencies() -> None:
 
 
 def remove_oe_instances(
+    instance_manager: InstanceManager,
     instance_list: List[Octoeverywhere],
 ) -> None:
     if not instance_list:
@@ -173,8 +181,13 @@ def remove_oe_instances(
         return
 
     for instance in instance_list:
-        Logger.print_status(f"Removing instance {instance.service_file_path.stem} ...")
-        InstanceManager.remove(instance)
+        Logger.print_status(f"Removing instance {instance.get_service_file_name()} ...")
+        instance_manager.current_instance = instance
+        instance_manager.stop_instance()
+        instance_manager.disable_instance()
+        instance_manager.delete_instance()
+
+    cmd_sysctl_manage("daemon-reload")
 
 
 def remove_oe_dir() -> None:

kiauh/components/webui_client/client_config/client_config_remove.py

@@ -13,10 +13,10 @@ from typing import List
 from components.klipper.klipper import Klipper
 from components.moonraker.moonraker import Moonraker
 from components.webui_client.base_data import BaseWebClientConfig
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from utils.config_utils import remove_config_section
 from utils.fs_utils import run_remove_routines
-from utils.instance_utils import get_instances
 
 
 def run_client_config_removal(
@@ -36,8 +36,7 @@ def remove_client_config_dir(client_config: BaseWebClientConfig) -> None:
 
 
 def remove_client_config_symlink(client_config: BaseWebClientConfig) -> None:
-    instances: List[Klipper] = get_instances(Klipper)
+    im = InstanceManager(Klipper)
+    instances: List[Klipper] = im.instances
     for instance in instances:
-        run_remove_routines(
-            instance.base.cfg_dir.joinpath(client_config.config_filename)
-        )
+        run_remove_routines(instance.cfg_dir.joinpath(client_config.config_filename))

kiauh/components/webui_client/client_config/client_config_setup.py

@@ -31,7 +31,6 @@ from utils.config_utils import add_config_section, add_config_section_at_top
 from utils.fs_utils import create_symlink
 from utils.git_utils import git_clone_wrapper, git_pull_wrapper
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 
 
 def install_client_config(client_data: BaseWebClient) -> None:
@@ -49,8 +48,10 @@ def install_client_config(client_data: BaseWebClient) -> None:
         else:
             return
 
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
-    kl_instances = get_instances(Klipper)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
+    kl_im = InstanceManager(Klipper)
+    kl_instances = kl_im.instances
 
     try:
         download_client_config(client_config)
@@ -70,7 +71,7 @@ def install_client_config(client_data: BaseWebClient) -> None:
             ],
         )
         add_config_section_at_top(client_config.config_section, kl_instances)
-        InstanceManager.restart_all(kl_instances)
+        kl_im.restart_all_instance()
 
     except Exception as e:
         Logger.print_error(f"{display_name} installation failed!\n{e}")
@@ -112,12 +113,16 @@ def update_client_config(client: BaseWebClient) -> None:
 
 
 def create_client_config_symlink(
-    client_config: BaseWebClientConfig, klipper_instances: List[Klipper]
+    client_config: BaseWebClientConfig, klipper_instances: List[Klipper] | None = None
 ) -> None:
+    if klipper_instances is None:
+        kl_im = InstanceManager(Klipper)
+        klipper_instances = kl_im.instances
+
+    Logger.print_status(f"Create symlink for {client_config.config_filename} ...")
+    source = Path(client_config.config_dir, client_config.config_filename)
     for instance in klipper_instances:
-        Logger.print_status(f"Create symlink for {client_config.config_filename} ...")
-        source = Path(client_config.config_dir, client_config.config_filename)
-        target = instance.base.cfg_dir
+        target = instance.cfg_dir
         Logger.print_status(f"Linking {source} to {target}")
         try:
             create_symlink(source, target)

kiauh/components/webui_client/client_dialogs.py

@@ -24,6 +24,8 @@ def print_moonraker_not_found_dialog() -> None:
             "another machine in your network. Otherwise Mainsail will NOT work "
             "correctly.",
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
 
 
@@ -34,6 +36,8 @@ def print_client_already_installed_dialog(name: str) -> None:
             f"{name} seems to be already installed!",
             f"If you continue, your current {name} installation will be overwritten.",
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
 
 
@@ -53,6 +57,8 @@ def print_client_port_select_dialog(
             "The following ports were found to be in use already:",
             *[f"● {port}" for port in ports_in_use],
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
 
 
@@ -71,6 +77,8 @@ def print_install_client_config_dialog(client: BaseWebClient) -> None:
             "If you already use these macros skip this step. Otherwise you should "
             "consider to answer with 'Y' to download the recommended macros.",
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
 
 

kiauh/components/webui_client/client_remove.py

@@ -18,13 +18,13 @@ from components.webui_client.client_config.client_config_remove import (
 )
 from core.backup_manager.backup_manager import BackupManager
 from core.constants import NGINX_SITES_AVAILABLE, NGINX_SITES_ENABLED
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from utils.config_utils import remove_config_section
 from utils.fs_utils import (
     remove_with_sudo,
     run_remove_routines,
 )
-from utils.instance_utils import get_instances
 
 
 def run_client_removal(
@@ -33,8 +33,10 @@ def run_client_removal(
     remove_client_cfg: bool,
     backup_config: bool,
 ) -> None:
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
-    kl_instances: List[Klipper] = get_instances(Klipper)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
+    kl_im = InstanceManager(Klipper)
+    kl_instances: List[Klipper] = kl_im.instances
 
     if backup_config:
         bm = BackupManager()
@@ -79,7 +81,5 @@ def remove_client_nginx_logs(client: BaseWebClient, instances: List[Klipper]) ->
         return
 
     for instance in instances:
-        run_remove_routines(
-            instance.base.log_dir.joinpath(client.nginx_access_log.name)
-        )
-        run_remove_routines(instance.base.log_dir.joinpath(client.nginx_error_log.name))
+        run_remove_routines(instance.log_dir.joinpath(client.nginx_access_log.name))
+        run_remove_routines(instance.log_dir.joinpath(client.nginx_error_log.name))

kiauh/components/webui_client/client_setup.py

@@ -45,7 +45,6 @@ from utils.common import check_install_dependencies
 from utils.config_utils import add_config_section
 from utils.fs_utils import unzip
 from utils.input_utils import get_confirm, get_number_input
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     cmd_sysctl_service,
     download_file,
@@ -63,7 +62,8 @@ def install_client(client: BaseWebClient) -> None:
         )
         return
 
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
 
     enable_remotemode = False
     if not mr_instances:
@@ -80,7 +80,8 @@ def install_client(client: BaseWebClient) -> None:
     ):
         enable_remotemode = True
 
-    kl_instances = get_instances(Klipper)
+    kl_im = InstanceManager(Klipper)
+    kl_instances = kl_im.instances
     install_client_cfg = False
     client_config: BaseWebClientConfig = client.client_config
     if (
@@ -125,7 +126,7 @@ def install_client(client: BaseWebClient) -> None:
                     ("path", str(client.client_dir)),
                 ],
             )
-            InstanceManager.restart_all(mr_instances)
+            mr_im.restart_all_instance()
         if install_client_cfg and kl_instances:
             install_client_config(client)
 

kiauh/components/webui_client/client_utils.py

@@ -38,7 +38,7 @@ from core.types import ComponentStatus
 from utils.common import get_install_status
 from utils.fs_utils import create_symlink, remove_file
 from utils.git_utils import (
-    get_latest_remote_tag,
+    get_latest_tag,
     get_latest_unstable_tag,
 )
 
@@ -109,11 +109,11 @@ def symlink_webui_nginx_log(
     error_log = client.nginx_error_log
 
     for instance in klipper_instances:
-        desti_access = instance.base.log_dir.joinpath(access_log.name)
+        desti_access = instance.log_dir.joinpath(access_log.name)
         if not desti_access.exists():
             desti_access.symlink_to(access_log)
 
-        desti_error = instance.base.log_dir.joinpath(error_log.name)
+        desti_error = instance.log_dir.joinpath(error_log.name)
         if not desti_error.exists():
             desti_error.symlink_to(error_log)
 
@@ -137,7 +137,7 @@ def get_local_client_version(client: BaseWebClient) -> str | None:
 
 def get_remote_client_version(client: BaseWebClient) -> str | None:
     try:
-        if (tag := get_latest_remote_tag(client.repo_path)) != "":
+        if (tag := get_latest_tag(client.repo_path)) != "":
             return str(tag)
         return None
     except Exception:

kiauh/components/webui_client/menus/client_remove_menu.py

@@ -38,11 +38,11 @@ class ClientRemoveMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "a": Option(method=self.toggle_all),
-            "1": Option(method=self.toggle_rm_client),
-            "2": Option(method=self.toggle_rm_client_config),
-            "3": Option(method=self.toggle_backup_config_json),
-            "c": Option(method=self.run_removal_process),
+            "a": Option(method=self.toggle_all, menu=False),
+            "1": Option(method=self.toggle_rm_client, menu=False),
+            "2": Option(method=self.toggle_rm_client_config, menu=False),
+            "3": Option(method=self.toggle_backup_config_json, menu=False),
+            "c": Option(method=self.run_removal_process, menu=False),
         }
 
     def print_menu(self) -> None:

kiauh/core/instance_manager/base_instance.py

@@ -10,49 +10,115 @@
 from __future__ import annotations
 
 import re
+from abc import ABC, abstractmethod
 from dataclasses import dataclass, field
 from pathlib import Path
 from typing import List
 
-from utils.fs_utils import get_data_dir
-
-SUFFIX_BLACKLIST: List[str] = ["None", "mcu", "obico", "bambu", "companion"]
+from core.constants import CURRENT_USER, SYSTEMD
+from core.logger import Logger
 
 
-@dataclass(repr=True)
-class BaseInstance:
-    instance_type: type
+@dataclass
+class BaseInstance(ABC):
     suffix: str
-    log_file_name: str | None = None
-    data_dir: Path = field(init=False)
-    base_folders: List[Path] = field(init=False)
-    cfg_dir: Path = field(init=False)
-    log_dir: Path = field(init=False)
-    gcodes_dir: Path = field(init=False)
-    comms_dir: Path = field(init=False)
-    sysd_dir: Path = field(init=False)
-    is_legacy_instance: bool = field(init=False)
+    user: str = field(default=CURRENT_USER, init=False)
+    data_dir: Path | None = None
+    data_dir_name: str = ""
+    is_legacy_instance: bool = False
+    cfg_dir: Path | None = None
+    log_dir: Path | None = None
+    comms_dir: Path | None = None
+    sysd_dir: Path | None = None
+    gcodes_dir: Path | None = None
 
-    def __post_init__(self):
-        self.data_dir = get_data_dir(self.instance_type, self.suffix)
-        # the following attributes require the data_dir to be set
-        self.cfg_dir = self.data_dir.joinpath("config")
-        self.log_dir = self.data_dir.joinpath("logs")
-        self.gcodes_dir = self.data_dir.joinpath("gcodes")
-        self.comms_dir = self.data_dir.joinpath("comms")
-        self.sysd_dir = self.data_dir.joinpath("systemd")
-        self.is_legacy_instance = self._set_is_legacy_instance()
-        self.base_folders = [
+    def __post_init__(self) -> None:
+        self._set_data_dir()
+        self._set_is_legacy_instance()
+        if self.data_dir is not None:
+            self.cfg_dir = self.data_dir.joinpath("config")
+            self.log_dir = self.data_dir.joinpath("logs")
+            self.comms_dir = self.data_dir.joinpath("comms")
+            self.sysd_dir = self.data_dir.joinpath("systemd")
+            self.gcodes_dir = self.data_dir.joinpath("gcodes")
+
+    @classmethod
+    def blacklist(cls) -> List[str]:
+        return ["None", "mcu", "obico", "bambu", "companion"]
+
+    @abstractmethod
+    def create(self) -> None:
+        raise NotImplementedError("Subclasses must implement the create method")
+
+    @abstractmethod
+    def delete(self) -> None:
+        raise NotImplementedError("Subclasses must implement the delete method")
+
+    def create_folders(self, add_dirs: List[Path] | None = None) -> None:
+        dirs: List[Path | None] = [
             self.data_dir,
             self.cfg_dir,
             self.log_dir,
-            self.gcodes_dir,
             self.comms_dir,
             self.sysd_dir,
+            self.gcodes_dir,
         ]
 
-    def _set_is_legacy_instance(self) -> bool:
-        legacy_pattern = r"^(?!printer)(.+)_data"
-        match = re.search(legacy_pattern, self.data_dir.name)
+        if add_dirs:
+            dirs.extend(add_dirs)
 
-        return True if (match and self.suffix != "") else False
+        for _dir in dirs:
+            if _dir is None:
+                continue
+            _dir.mkdir(exist_ok=True)
+
+    # todo: refactor into a set method and access the value by accessing the property
+    def get_service_file_name(self, extension: bool = False) -> str:
+        from utils.common import convert_camelcase_to_kebabcase
+
+        name: str = convert_camelcase_to_kebabcase(self.__class__.__name__)
+        if self.suffix != "":
+            name += f"-{self.suffix}"
+
+        return name if not extension else f"{name}.service"
+
+    # todo: refactor into a set method and access the value by accessing the property
+    def get_service_file_path(self) -> Path:
+        path: Path = SYSTEMD.joinpath(self.get_service_file_name(extension=True))
+        return path
+
+    def delete_logfiles(self, log_name: str) -> None:
+        from utils.fs_utils import run_remove_routines
+
+        if not self.log_dir or not self.log_dir.exists():
+            return
+
+        files = self.log_dir.iterdir()
+        logs = [f for f in files if f.name.startswith(log_name)]
+        for log in logs:
+            Logger.print_status(f"Remove '{log}'")
+            run_remove_routines(log)
+
+    def _set_data_dir(self) -> None:
+        if self.suffix == "":
+            self.data_dir = Path.home().joinpath("printer_data")
+        else:
+            self.data_dir = Path.home().joinpath(f"printer_{self.suffix}_data")
+
+        if self.get_service_file_path().exists():
+            with open(self.get_service_file_path(), "r") as service_file:
+                service_content = service_file.read()
+                pattern = re.compile("^EnvironmentFile=(.+)(/systemd/.+\.env)")
+                match = re.search(pattern, service_content)
+                if match:
+                    self.data_dir = Path(match.group(1))
+
+    def _set_is_legacy_instance(self) -> None:
+        if (
+            self.suffix != ""
+            and not self.data_dir_name.startswith("printer_")
+            and not self.data_dir_name.endswith("_data")
+        ):
+            self.is_legacy_instance = True
+        else:
+            self.is_legacy_instance = False

kiauh/core/instance_manager/instance_manager.py

@@ -8,101 +8,189 @@
 # ======================================================================= #
 from __future__ import annotations
 
+import re
+import subprocess
 from pathlib import Path
-from subprocess import CalledProcessError
-from typing import List
+from typing import List, Type, TypeVar
 
-from core.instance_type import InstanceType
+from core.constants import SYSTEMD
+from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
 from utils.sys_utils import cmd_sysctl_service
 
+T = TypeVar("T", bound=BaseInstance, covariant=True)
 
+
+# noinspection PyMethodMayBeStatic
 class InstanceManager:
-    @staticmethod
-    def enable(instance: InstanceType) -> None:
-        service_name: str = instance.service_file_path.name
+    def __init__(self, instance_type: Type[T]) -> None:
+        self._instance_type = instance_type
+        self._current_instance: Type[T] | None = None
+        self._instance_suffix: str | None = None
+        self._instance_service: str | None = None
+        self._instance_service_full: str | None = None
+        self._instance_service_path: str | None = None
+        self._instances: List[T] = []
+
+    @property
+    def instance_type(self) -> Type[T]:
+        return self._instance_type
+
+    @instance_type.setter
+    def instance_type(self, value: Type[T]):
+        self._instance_type = value
+
+    @property
+    def current_instance(self) -> Type[T] | None:
+        return self._current_instance
+
+    @current_instance.setter
+    def current_instance(self, value: Type[T] | None) -> None:
+        self._current_instance = value
+        if value is not None:
+            self.instance_suffix = value.suffix
+            self.instance_service = value.get_service_file_name()
+            self.instance_service_path = value.get_service_file_path()
+
+    @property
+    def instance_suffix(self) -> str | None:
+        return self._instance_suffix
+
+    @instance_suffix.setter
+    def instance_suffix(self, value: str | None):
+        self._instance_suffix = value
+
+    @property
+    def instance_service(self) -> str | None:
+        return self._instance_service
+
+    @instance_service.setter
+    def instance_service(self, value: str | None) -> None:
+        self._instance_service = value
+
+    @property
+    def instance_service_full(self) -> str:
+        return f"{self._instance_service}.service"
+
+    @property
+    def instance_service_path(self) -> str | None:
+        return self._instance_service_path
+
+    @instance_service_path.setter
+    def instance_service_path(self, value: str | None) -> None:
+        self._instance_service_path = value
+
+    @property
+    def instances(self) -> List[Type[T]]:
+        return self.find_instances()
+
+    @instances.setter
+    def instances(self, value: List[T]) -> None:
+        self._instances = value
+
+    def create_instance(self) -> None:
+        if self.current_instance is not None:
+            try:
+                self.current_instance.create()
+            except (OSError, subprocess.CalledProcessError) as e:
+                Logger.print_error(f"Creating instance failed: {e}")
+                raise
+        else:
+            raise ValueError("current_instance cannot be None")
+
+    def delete_instance(self) -> None:
+        if self.current_instance is not None:
+            try:
+                self.current_instance.delete()
+            except (OSError, subprocess.CalledProcessError) as e:
+                Logger.print_error(f"Removing instance failed: {e}")
+                raise
+        else:
+            raise ValueError("current_instance cannot be None")
+
+    def enable_instance(self) -> None:
         try:
-            cmd_sysctl_service(service_name, "enable")
-        except CalledProcessError as e:
-            Logger.print_error(f"Error enabling service {service_name}:")
+            cmd_sysctl_service(self.instance_service_full, "enable")
+        except subprocess.CalledProcessError as e:
+            Logger.print_error(f"Error enabling service {self.instance_service_full}:")
             Logger.print_error(f"{e}")
 
-    @staticmethod
-    def disable(instance: InstanceType) -> None:
-        service_name: str = instance.service_file_path.name
+    def disable_instance(self) -> None:
         try:
-            cmd_sysctl_service(service_name, "disable")
-        except CalledProcessError as e:
-            Logger.print_error(f"Error disabling {service_name}: {e}")
+            cmd_sysctl_service(self.instance_service_full, "disable")
+        except subprocess.CalledProcessError as e:
+            Logger.print_error(f"Error disabling {self.instance_service_full}:")
+            Logger.print_error(f"{e}")
+
+    def start_instance(self) -> None:
+        try:
+            cmd_sysctl_service(self.instance_service_full, "start")
+        except subprocess.CalledProcessError as e:
+            Logger.print_error(f"Error starting {self.instance_service_full}:")
+            Logger.print_error(f"{e}")
+
+    def restart_instance(self) -> None:
+        try:
+            cmd_sysctl_service(self.instance_service_full, "restart")
+        except subprocess.CalledProcessError as e:
+            Logger.print_error(f"Error restarting {self.instance_service_full}:")
+            Logger.print_error(f"{e}")
+
+    def start_all_instance(self) -> None:
+        for instance in self.instances:
+            self.current_instance = instance
+            self.start_instance()
+
+    def restart_all_instance(self) -> None:
+        for instance in self.instances:
+            self.current_instance = instance
+            self.restart_instance()
+
+    def stop_instance(self) -> None:
+        try:
+            cmd_sysctl_service(self.instance_service_full, "stop")
+        except subprocess.CalledProcessError as e:
+            Logger.print_error(f"Error stopping {self.instance_service_full}:")
+            Logger.print_error(f"{e}")
             raise
 
-    @staticmethod
-    def start(instance: InstanceType) -> None:
-        service_name: str = instance.service_file_path.name
-        try:
-            cmd_sysctl_service(service_name, "start")
-        except CalledProcessError as e:
-            Logger.print_error(f"Error starting {service_name}: {e}")
-            raise
+    def stop_all_instance(self) -> None:
+        for instance in self.instances:
+            self.current_instance = instance
+            self.stop_instance()
 
-    @staticmethod
-    def stop(instance: InstanceType) -> None:
-        name: str = instance.service_file_path.name
-        try:
-            cmd_sysctl_service(name, "stop")
-        except CalledProcessError as e:
-            Logger.print_error(f"Error stopping {name}: {e}")
-            raise
+    def find_instances(self) -> List[Type[T]]:
+        from utils.common import convert_camelcase_to_kebabcase
 
-    @staticmethod
-    def restart(instance: InstanceType) -> None:
-        name: str = instance.service_file_path.name
-        try:
-            cmd_sysctl_service(name, "restart")
-        except CalledProcessError as e:
-            Logger.print_error(f"Error restarting {name}: {e}")
-            raise
+        name = convert_camelcase_to_kebabcase(self.instance_type.__name__)
+        pattern = re.compile(f"^{name}(-[0-9a-zA-Z]+)?.service$")
+        excluded = self.instance_type.blacklist()
 
-    @staticmethod
-    def start_all(instances: List[InstanceType]) -> None:
-        for instance in instances:
-            InstanceManager.start(instance)
+        service_list = [
+            Path(SYSTEMD, service)
+            for service in SYSTEMD.iterdir()
+            if pattern.search(service.name)
+            and not any(s in service.name for s in excluded)
+        ]
 
-    @staticmethod
-    def stop_all(instances: List[InstanceType]) -> None:
-        for instance in instances:
-            InstanceManager.stop(instance)
+        instance_list = [
+            self.instance_type(suffix=self._get_instance_suffix(name, service))
+            for service in service_list
+        ]
 
-    @staticmethod
-    def restart_all(instances: List[InstanceType]) -> None:
-        for instance in instances:
-            InstanceManager.restart(instance)
+        return sorted(instance_list, key=lambda x: self._sort_instance_list(x.suffix))
 
-    @staticmethod
-    def remove(instance: InstanceType) -> None:
-        from utils.fs_utils import run_remove_routines
-        from utils.sys_utils import remove_system_service
+    def _get_instance_suffix(self, name: str, file_path: Path) -> str:
+        # to get the suffix of the instance, we remove the name of the instance from
+        # the file name, if the remaining part an empty string we return it
+        # otherwise there is and hyphen left, and we return the part after the hyphen
+        suffix = file_path.stem[len(name) :]
+        return suffix[1:] if suffix else ""
 
-        try:
-            # remove the service file
-            service_file_path: Path = instance.service_file_path
-            if service_file_path is not None:
-                remove_system_service(service_file_path.name)
-
-            # then remove all the log files
-            if (
-                not instance.log_file_name
-                or not instance.base.log_dir
-                or not instance.base.log_dir.exists()
-            ):
-                return
-
-            files = instance.base.log_dir.iterdir()
-            logs = [f for f in files if f.name.startswith(instance.log_file_name)]
-            for log in logs:
-                Logger.print_status(f"Remove '{log}'")
-                run_remove_routines(log)
-
-        except Exception as e:
-            Logger.print_error(f"Error removing service: {e}")
-            raise
+    def _sort_instance_list(self, suffix: int | str | None):
+        if suffix is None:
+            return
+        elif isinstance(suffix, str) and suffix.isdigit():
+            return f"{int(suffix):04}"
+        else:
+            return suffix

kiauh/core/instance_manager/name_scheme.py

@@ -0,0 +1,8 @@
+from enum import Enum, unique
+
+
+@unique
+class NameScheme(Enum):
+    SINGLE = "SINGLE"
+    INDEX = "INDEX"
+    CUSTOM = "CUSTOM"

kiauh/core/instance_type.py

@@ -1,25 +0,0 @@
-# ======================================================================= #
-#  Copyright (C) 2020 - 2024 Dominik Willner <th33xitus@gmail.com>        #
-#                                                                         #
-#  This file is part of KIAUH - Klipper Installation And Update Helper    #
-#  https://github.com/dw-0/kiauh                                          #
-#                                                                         #
-#  This file may be distributed under the terms of the GNU GPLv3 license  #
-# ======================================================================= #
-
-from typing import TypeVar
-
-from components.klipper.klipper import Klipper
-from components.moonraker.moonraker import Moonraker
-from components.octoeverywhere.octoeverywhere import Octoeverywhere
-from extensions.obico.moonraker_obico import MoonrakerObico
-from extensions.telegram_bot.moonraker_telegram_bot import MoonrakerTelegramBot
-
-InstanceType = TypeVar(
-    "InstanceType",
-    Klipper,
-    Moonraker,
-    MoonrakerTelegramBot,
-    MoonrakerObico,
-    Octoeverywhere,
-)

kiauh/core/logger.py

@@ -92,8 +92,8 @@ class Logger:
         center_content: bool = False,
         custom_title: str | None = None,
         custom_color: DialogCustomColor | None = None,
-        margin_top: int = 0,
-        margin_bottom: int = 0,
+        padding_top: int = 1,
+        padding_bottom: int = 1,
     ) -> None:
         """
         Prints a dialog with the given title and content.
@@ -106,8 +106,8 @@ class Logger:
         :param center_content: Whether to center the content or not.
         :param custom_title: A custom title for the dialog.
         :param custom_color: A custom color for the dialog.
-        :param margin_top: The number of empty lines to print before the dialog.
-        :param margin_bottom: The number of empty lines to print after the dialog.
+        :param padding_top: The number of empty lines to print before the dialog.
+        :param padding_bottom: The number of empty lines to print after the dialog.
         """
         dialog_color = Logger._get_dialog_color(title, custom_color)
         dialog_title = Logger._get_dialog_title(title, custom_title)
@@ -116,12 +116,12 @@ class Logger:
         top = Logger._format_top_border(dialog_color)
         bottom = Logger._format_bottom_border()
 
-        print("\n" * margin_top)
+        print("\n" * padding_top)
         print(
             f"{top}{dialog_title_formatted}{dialog_content}{bottom}",
             end="",
         )
-        print("\n" * margin_bottom)
+        print("\n" * padding_bottom)
 
     @staticmethod
     def _get_dialog_title(

kiauh/core/menus/__init__.py

@@ -10,7 +10,7 @@ from __future__ import annotations
 
 from dataclasses import dataclass
 from enum import Enum
-from typing import Any, Callable, Type
+from typing import Any, Callable
 
 
 @dataclass
@@ -18,11 +18,13 @@ class Option:
     """
     Represents a menu option.
     :param method: Method that will be used to call the menu option
+    :param menu: Flag for singaling that another menu will be opened
     :param opt_index: Can be used to pass the user input to the menu option
     :param opt_data: Can be used to pass any additional data to the menu option
     """
 
-    method: Type[Callable] | None = None
+    method: Callable | None = None
+    menu: bool = False
     opt_index: str = ""
     opt_data: Any = None
 

kiauh/core/menus/advanced_menu.py

@@ -43,13 +43,13 @@ class AdvancedMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.build),
-            "2": Option(method=self.flash),
-            "3": Option(method=self.build_flash),
-            "4": Option(method=self.get_id),
-            "5": Option(method=self.klipper_rollback),
-            "6": Option(method=self.moonraker_rollback),
-            "7": Option(method=self.change_hostname),
+            "1": Option(method=self.build, menu=True),
+            "2": Option(method=self.flash, menu=False),
+            "3": Option(method=self.build_flash, menu=False),
+            "4": Option(method=self.get_id, menu=False),
+            "5": Option(method=self.klipper_rollback, menu=True),
+            "6": Option(method=self.moonraker_rollback, menu=True),
+            "7": Option(method=self.change_hostname, menu=True),
         }
 
     def print_menu(self) -> None:

kiauh/core/menus/backup_menu.py

@@ -43,15 +43,15 @@ class BackupMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.backup_klipper),
-            "2": Option(method=self.backup_moonraker),
-            "3": Option(method=self.backup_printer_config),
-            "4": Option(method=self.backup_moonraker_db),
-            "5": Option(method=self.backup_mainsail),
-            "6": Option(method=self.backup_fluidd),
-            "7": Option(method=self.backup_mainsail_config),
-            "8": Option(method=self.backup_fluidd_config),
-            "9": Option(method=self.backup_klipperscreen),
+            "1": Option(method=self.backup_klipper, menu=False),
+            "2": Option(method=self.backup_moonraker, menu=False),
+            "3": Option(method=self.backup_printer_config, menu=False),
+            "4": Option(method=self.backup_moonraker_db, menu=False),
+            "5": Option(method=self.backup_mainsail, menu=False),
+            "6": Option(method=self.backup_fluidd, menu=False),
+            "7": Option(method=self.backup_mainsail_config, menu=False),
+            "8": Option(method=self.backup_fluidd_config, menu=False),
+            "9": Option(method=self.backup_klipperscreen, menu=False),
         }
 
     def print_menu(self) -> None:

kiauh/core/menus/base_menu.py

@@ -123,12 +123,12 @@ class BaseMenu(metaclass=PostInitCaller):
 
         # conditionally add options based on footer type
         if self.footer_type is FooterType.QUIT:
-            self.options["q"] = Option(method=self.__exit)
+            self.options["q"] = Option(method=self.__exit, menu=False)
         if self.footer_type is FooterType.BACK:
-            self.options["b"] = Option(method=self.__go_back)
+            self.options["b"] = Option(method=self.__go_back, menu=False)
         if self.footer_type is FooterType.BACK_HELP:
-            self.options["b"] = Option(method=self.__go_back)
-            self.options["h"] = Option(method=self.__go_to_help)
+            self.options["b"] = Option(method=self.__go_back, menu=False)
+            self.options["h"] = Option(method=self.__go_to_help, menu=False)
         # if defined, add the default option to the options dict
         if self.default_option is not None:
             self.options[""] = self.default_option
@@ -184,10 +184,7 @@ class BaseMenu(metaclass=PostInitCaller):
         :return: Option, str or None
         """
         usr_input = usr_input.lower()
-        option = self.options.get(
-            usr_input,
-            Option(method=None, opt_index="", opt_data=None),
-        )
+        option = self.options.get(usr_input, Option(None, False, "", None))
 
         # if option/usr_input is None/empty string, we execute the menus default option if specified
         if (option is None or usr_input == "") and self.default_option is not None:

kiauh/core/menus/install_menu.py

@@ -40,16 +40,16 @@ class InstallMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.install_klipper),
-            "2": Option(method=self.install_moonraker),
-            "3": Option(method=self.install_mainsail),
-            "4": Option(method=self.install_fluidd),
-            "5": Option(method=self.install_mainsail_config),
-            "6": Option(method=self.install_fluidd_config),
-            "7": Option(method=self.install_klipperscreen),
-            "8": Option(method=self.install_mobileraker),
-            "9": Option(method=self.install_crowsnest),
-            "10": Option(method=self.install_octoeverywhere),
+            "1": Option(method=self.install_klipper, menu=False),
+            "2": Option(method=self.install_moonraker, menu=False),
+            "3": Option(method=self.install_mainsail, menu=False),
+            "4": Option(method=self.install_fluidd, menu=False),
+            "5": Option(method=self.install_mainsail_config, menu=False),
+            "6": Option(method=self.install_fluidd_config, menu=False),
+            "7": Option(method=self.install_klipperscreen, menu=False),
+            "8": Option(method=self.install_mobileraker, menu=False),
+            "9": Option(method=self.install_crowsnest, menu=False),
+            "10": Option(method=self.install_octoeverywhere, menu=False),
         }
 
     def print_menu(self) -> None:

kiauh/core/menus/main_menu.py

@@ -42,9 +42,8 @@ from core.menus.install_menu import InstallMenu
 from core.menus.remove_menu import RemoveMenu
 from core.menus.settings_menu import SettingsMenu
 from core.menus.update_menu import UpdateMenu
-from core.types import ComponentStatus, StatusMap, StatusText
 from extensions.extensions_menu import ExtensionsMenu
-from utils.common import get_kiauh_version
+from core.types import ComponentStatus, StatusMap, StatusText
 
 
 # noinspection PyUnusedLocal
@@ -56,7 +55,6 @@ class MainMenu(BaseMenu):
         self.header: bool = True
         self.footer_type: FooterType = FooterType.QUIT
 
-        self.version = ""
         self.kl_status = self.kl_repo = self.mr_status = self.mr_repo = ""
         self.ms_status = self.fl_status = self.ks_status = self.mb_status = ""
         self.cn_status = self.cc_status = self.oe_status = ""
@@ -68,14 +66,14 @@ class MainMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "0": Option(method=self.log_upload_menu),
-            "1": Option(method=self.install_menu),
-            "2": Option(method=self.update_menu),
-            "3": Option(method=self.remove_menu),
-            "4": Option(method=self.advanced_menu),
-            "5": Option(method=self.backup_menu),
-            "e": Option(method=self.extension_menu),
-            "s": Option(method=self.settings_menu),
+            "0": Option(method=self.log_upload_menu, menu=True),
+            "1": Option(method=self.install_menu, menu=True),
+            "2": Option(method=self.update_menu, menu=True),
+            "3": Option(method=self.remove_menu, menu=True),
+            "4": Option(method=self.advanced_menu, menu=True),
+            "5": Option(method=self.backup_menu, menu=True),
+            "e": Option(method=self.extension_menu, menu=True),
+            "s": Option(method=self.settings_menu, menu=True),
         }
 
     def _init_status(self) -> None:
@@ -88,7 +86,6 @@ class MainMenu(BaseMenu):
             )
 
     def _fetch_status(self) -> None:
-        self.version = get_kiauh_version()
         self._get_component_status("kl", get_klipper_status)
         self._get_component_status("mr", get_moonraker_status)
         self._get_component_status("ms", get_client_status, MainsailData())
@@ -128,7 +125,7 @@ class MainMenu(BaseMenu):
         self._fetch_status()
 
         header = " [ Main Menu ] "
-        footer1 = f"{COLOR_CYAN}{self.version}{RESET_FORMAT}"
+        footer1 = f"{COLOR_CYAN}KIAUH v6.0.0{RESET_FORMAT}"
         footer2 = f"Changelog: {COLOR_MAGENTA}https://git.io/JnmlX{RESET_FORMAT}"
         color = COLOR_CYAN
         count = 62 - len(color) - len(RESET_FORMAT)

kiauh/core/menus/remove_menu.py

@@ -41,14 +41,14 @@ class RemoveMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.remove_klipper),
-            "2": Option(method=self.remove_moonraker),
-            "3": Option(method=self.remove_mainsail),
-            "4": Option(method=self.remove_fluidd),
-            "5": Option(method=self.remove_klipperscreen),
-            "6": Option(method=self.remove_mobileraker),
-            "7": Option(method=self.remove_crowsnest),
-            "8": Option(method=self.remove_octoeverywhere),
+            "1": Option(method=self.remove_klipper, menu=True),
+            "2": Option(method=self.remove_moonraker, menu=True),
+            "3": Option(method=self.remove_mainsail, menu=True),
+            "4": Option(method=self.remove_fluidd, menu=True),
+            "5": Option(method=self.remove_klipperscreen, menu=True),
+            "6": Option(method=self.remove_mobileraker, menu=True),
+            "7": Option(method=self.remove_crowsnest, menu=True),
+            "8": Option(method=self.remove_octoeverywhere, menu=True),
         }
 
     def print_menu(self) -> None:

kiauh/core/menus/settings_menu.py

@@ -25,7 +25,6 @@ from core.menus.base_menu import BaseMenu
 from core.settings.kiauh_settings import KiauhSettings
 from utils.git_utils import git_clone_wrapper
 from utils.input_utils import get_confirm, get_string_input
-from utils.instance_utils import get_instances
 
 
 # noinspection PyUnusedLocal
@@ -48,11 +47,11 @@ class SettingsMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "1": Option(method=self.set_klipper_repo),
-            "2": Option(method=self.set_moonraker_repo),
-            "3": Option(method=self.toggle_mainsail_release),
-            "4": Option(method=self.toggle_fluidd_release),
-            "5": Option(method=self.toggle_backup_before_update),
+            "1": Option(method=self.set_klipper_repo, menu=True),
+            "2": Option(method=self.set_moonraker_repo, menu=True),
+            "3": Option(method=self.toggle_mainsail_release, menu=True),
+            "4": Option(method=self.toggle_fluidd_release, menu=False),
+            "5": Option(method=self.toggle_backup_before_update, menu=False),
         }
 
     def print_menu(self) -> None:
@@ -178,14 +177,14 @@ class SettingsMenu(BaseMenu):
         if target_dir.exists():
             shutil.rmtree(target_dir)
 
-        instances = get_instances(_type)
-        InstanceManager.stop_all(instances)
+        im = InstanceManager(_type)
+        im.stop_all_instance()
 
         repo = self.settings.get(name, "repo_url")
         branch = self.settings.get(name, "branch")
         git_clone_wrapper(repo, target_dir, branch)
 
-        InstanceManager.start_all(instances)
+        im.start_all_instance()
 
     def set_klipper_repo(self, **kwargs) -> None:
         self._set_repo("klipper")

kiauh/core/menus/update_menu.py

@@ -50,13 +50,13 @@ from core.logger import DialogType, Logger
 from core.menus import Option
 from core.menus.base_menu import BaseMenu
 from core.spinner import Spinner
-from core.types import ComponentStatus
 from utils.input_utils import get_confirm
 from utils.sys_utils import (
     get_upgradable_packages,
     update_system_package_lists,
     upgrade_system_packages,
 )
+from core.types import ComponentStatus
 
 
 # noinspection PyUnusedLocal
@@ -102,18 +102,18 @@ class UpdateMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            "a": Option(self.update_all),
-            "1": Option(self.update_klipper),
-            "2": Option(self.update_moonraker),
-            "3": Option(self.update_mainsail),
-            "4": Option(self.update_fluidd),
-            "5": Option(self.update_mainsail_config),
-            "6": Option(self.update_fluidd_config),
-            "7": Option(self.update_klipperscreen),
-            "8": Option(self.update_mobileraker),
-            "9": Option(self.update_crowsnest),
-            "10": Option(self.update_octoeverywhere),
-            "11": Option(self.upgrade_system_packages),
+            "a": Option(self.update_all, menu=False),
+            "1": Option(self.update_klipper, menu=False),
+            "2": Option(self.update_moonraker, menu=False),
+            "3": Option(self.update_mainsail, menu=False),
+            "4": Option(self.update_fluidd, menu=False),
+            "5": Option(self.update_mainsail_config, menu=False),
+            "6": Option(self.update_fluidd_config, menu=False),
+            "7": Option(self.update_klipperscreen, menu=False),
+            "8": Option(self.update_mobileraker, menu=False),
+            "9": Option(self.update_crowsnest, menu=False),
+            "10": Option(self.update_octoeverywhere, menu=False),
+            "11": Option(self.upgrade_system_packages, menu=False),
         }
 
     def print_menu(self) -> None:
@@ -281,6 +281,8 @@ class UpdateMenu(BaseMenu):
                 DialogType.CUSTOM,
                 ["The following packages will be upgraded:", "\n\n", pkgs],
                 custom_title="UPGRADABLE SYSTEM UPDATES",
+                padding_top=0,
+                padding_bottom=0,
             )
             if not get_confirm("Continue?"):
                 return

kiauh/extensions/extensions_menu.py

@@ -38,7 +38,9 @@ class ExtensionsMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            i: Option(self.extension_submenu, opt_data=self.extensions.get(i))
+            i: Option(
+                self.extension_submenu, menu=True, opt_data=self.extensions.get(i)
+            )
             for i in self.extensions
         }
 
@@ -117,12 +119,12 @@ class ExtensionSubmenu(BaseMenu):
         )
 
     def set_options(self) -> None:
-        self.options["1"] = Option(self.extension.install_extension)
+        self.options["1"] = Option(self.extension.install_extension, menu=False)
         if self.extension.metadata.get("updates"):
-            self.options["2"] = Option(self.extension.update_extension)
-            self.options["3"] = Option(self.extension.remove_extension)
+            self.options["2"] = Option(self.extension.update_extension, menu=False)
+            self.options["3"] = Option(self.extension.remove_extension, menu=False)
         else:
-            self.options["2"] = Option(self.extension.remove_extension)
+            self.options["2"] = Option(self.extension.remove_extension, menu=False)
 
     def print_menu(self) -> None:
         header = f" [ {self.extension.metadata.get('display_name')} ] "

kiauh/extensions/gcode_shell_cmd/gcode_shell_cmd_extension.py

@@ -28,7 +28,6 @@ from extensions.gcode_shell_cmd import (
 )
 from utils.fs_utils import check_file_exist
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 
 
 # noinspection PyMethodMayBeStatic
@@ -56,8 +55,8 @@ class GcodeShellCmdExtension(BaseExtension):
             Logger.print_warn("Installation aborted due to user request.")
             return
 
-        instances = get_instances(Klipper)
-        InstanceManager.stop_all(instances)
+        im = InstanceManager(Klipper)
+        im.stop_all_instance()
 
         try:
             Logger.print_status(f"Copy extension to '{KLIPPER_EXTRAS}' ...")
@@ -67,9 +66,9 @@ class GcodeShellCmdExtension(BaseExtension):
             return
 
         if install_example:
-            self.install_example_cfg(instances)
+            self.install_example_cfg(im.instances)
 
-        InstanceManager.start_all(instances)
+        im.start_all_instance()
 
         Logger.print_ok("Installing G-Code Shell Command extension successful!")
 
@@ -95,7 +94,7 @@ class GcodeShellCmdExtension(BaseExtension):
             Logger.print_warn("Make sure to remove them from the printer.cfg!")
 
     def install_example_cfg(self, instances: List[Klipper]):
-        cfg_dirs = [instance.base.cfg_dir for instance in instances]
+        cfg_dirs = [instance.cfg_dir for instance in instances]
         # copy extension to klippy/extras
         for cfg_dir in cfg_dirs:
             Logger.print_status(f"Create shell_command.cfg in '{cfg_dir}' ...")

kiauh/extensions/klipper_backup/klipper_backup_extension.py

@@ -12,9 +12,9 @@
 import os
 import shutil
 import subprocess
+
 from core.constants import SYSTEMD
 from core.logger import Logger
-from pathlib import Path
 from extensions.base_extension import BaseExtension
 from extensions.klipper_backup import (
     KLIPPERBACKUP_CONFIG_DIR,
@@ -22,106 +22,152 @@ from extensions.klipper_backup import (
     KLIPPERBACKUP_REPO_URL,
     MOONRAKER_CONF,
 )
-from utils.fs_utils import check_file_exist, remove_with_sudo
-from utils.git_utils import git_cmd_clone
+from utils.fs_utils import check_file_exist
 from utils.input_utils import get_confirm
-from utils.sys_utils import cmd_sysctl_manage, remove_system_service, unit_file_exists
+from utils.sys_utils import unit_file_exists
 
 
+# noinspection PyMethodMayBeStatic
 class KlipperbackupExtension(BaseExtension):
 
     def remove_extension(self, **kwargs) -> None:
-        if not check_file_exist(KLIPPERBACKUP_DIR):
-            Logger.print_info("Extension does not seem to be installed! Skipping ...")
-            return
-
         def uninstall_service(service_name: str, unit_type: str) -> bool:
             try:
                 full_service_name = f"{service_name}.{unit_type}"
-                if unit_type == "service":
-                    remove_system_service(full_service_name)
-                elif unit_type == "timer":
-                    full_service_path: Path = SYSTEMD.joinpath(full_service_name)
-                    Logger.print_status(f"Removing {full_service_name} ...")
-                    remove_with_sudo(full_service_path)
-                    Logger.print_ok(f"{service_name}.{unit_type} successfully removed!")
-                    cmd_sysctl_manage("daemon-reload")
-                    cmd_sysctl_manage("reset-failed")
-                else:
-                    Logger.print_error(f"Unknown unit type {unit_type} of {full_service_name}")
-            except:
-                Logger.print_error(f"Failed to remove {full_service_name}: {str(e)}")
+                subprocess.run(["sudo", "systemctl", "stop", full_service_name], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                subprocess.run(["sudo", "systemctl", "disable", full_service_name], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                service_path = f"{SYSTEMD}/{full_service_name}"
+                subprocess.run(["sudo", "rm", service_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                subprocess.run(["sudo", "systemctl", "daemon-reload"], check=True)
+                subprocess.run(["sudo", "systemctl", "reset-failed"], check=True)
+                return True
+            except subprocess.CalledProcessError:
+                return False
 
         def check_crontab_entry(entry) -> bool:
             try:
-                crontab_content = subprocess.check_output(["crontab", "-l"], stderr=subprocess.DEVNULL, text=True)
+                crontab_content = subprocess.check_output(
+                    ["crontab", "-l"], stderr=subprocess.DEVNULL, text=True
+                )
             except subprocess.CalledProcessError:
                 return False
-            return any(entry in line for line in crontab_content.splitlines())
+            for line in crontab_content.splitlines():
+                if entry in line:
+                    return True
+            return False
+
+        extension_installed = check_file_exist(KLIPPERBACKUP_DIR)
+        if not extension_installed:
+            Logger.print_info("Extension does not seem to be installed! Skipping ...")
+            return
 
         def remove_moonraker_entry():
             original_file_path = MOONRAKER_CONF
-            comparison_file_path = os.path.join(str(KLIPPERBACKUP_DIR), "install-files", "moonraker.conf")
-            if not (os.path.exists(original_file_path) and os.path.exists(comparison_file_path)):
+            comparison_file_path = os.path.join(
+                str(KLIPPERBACKUP_DIR), "install-files", "moonraker.conf"
+            )
+            if not os.path.exists(original_file_path) or not os.path.exists(
+                comparison_file_path
+            ):
                 return False
-            with open(original_file_path, "r") as original_file, open(comparison_file_path, "r") as comparison_file:
+            with open(original_file_path, "r") as original_file, open(
+                comparison_file_path, "r"
+            ) as comparison_file:
                 original_content = original_file.read()
                 comparison_content = comparison_file.read()
             if comparison_content in original_content:
-                Logger.print_status("Removing Klipper-Backup moonraker entry ...")
-                modified_content = original_content.replace(comparison_content, "").strip()
-                modified_content = "\n".join(line for line in modified_content.split("\n") if line.strip())
+                modified_content = original_content.replace(
+                    comparison_content, ""
+                ).strip()
+                modified_content = "\n".join(
+                    line for line in modified_content.split("\n") if line.strip()
+                )
                 with open(original_file_path, "w") as original_file:
                     original_file.write(modified_content)
-                Logger.print_ok("Klipper-Backup moonraker entry successfully removed!")
-                return True
-            return False
+                    return True
+            else:
+                return False
+
+        question = "Do you really want to remove the extension?"
+        if get_confirm(question, True, False):
+            # Remove Klipper-Backup services
+            service_names = [
+                "klipper-backup-on-boot",
+                "klipper-backup-filewatch",
+                "klipper-backup",
+            ]
 
-        if get_confirm("Do you really want to remove the extension?", True, False):
-            # Remove systemd timer and services
-            service_names = ["klipper-backup-on-boot", "klipper-backup-filewatch", "klipper-backup"]
             unit_types = ["timer", "service"]
 
             for service_name in service_names:
-                for unit_type in unit_types:
-                    if unit_file_exists(service_name, unit_type):
-                        uninstall_service(service_name, unit_type)
+                try:
+                    Logger.print_status(f"Check whether a {service_name} unit is installed ...")
 
-            # Remnove crontab entry
+                    for unit_type in unit_types:
+                        full_service_name = f"{service_name}.{unit_type}"
+                        Logger.print_info(f"Checking for {unit_type} unit {full_service_name}")
+
+                        if unit_file_exists(service_name, unit_type):
+                            Logger.print_info(f"{unit_type.capitalize()} unit {full_service_name} detected.")
+
+                            if uninstall_service(service_name, unit_type):
+                                Logger.print_ok(f"The {unit_type} unit {full_service_name} has been successfully uninstalled.")
+                            else:
+                                Logger.print_error(f"Error uninstalling {full_service_name}.")
+                        else:
+                            Logger.print_info(f"No {unit_type} unit for {full_service_name} detected.")
+                except Exception as e:
+                    Logger.print_error(f"Unable to remove the {service_name} service: {e}")
+
+            # Remove Klipper-Backup cron
+            Logger.print_status("Check for Klipper-Backup cron entry ...")
+            entry_to_check = "/klipper-backup/script.sh"
             try:
-                if check_crontab_entry("/klipper-backup/script.sh"):
-                    Logger.print_status("Removing Klipper-Backup crontab entry ...")
-                    crontab_content = subprocess.check_output(["crontab", "-l"], text=True)
-                    modified_content = "\n".join(line for line in crontab_content.splitlines() if "/klipper-backup/script.sh" not in line)
-                    subprocess.run(["crontab", "-"], input=modified_content + "\n", text=True, check=True)
-                    Logger.print_ok("Klipper-Backup crontab entry successfully removed!")
+                if check_crontab_entry(entry_to_check):
+                    crontab_content = subprocess.check_output(
+                        ["crontab", "-l"], text=True
+                    )
+                    modified_content = "\n".join(
+                        line
+                        for line in crontab_content.splitlines()
+                        if entry_to_check not in line
+                    )
+                    if not modified_content.endswith("\n"):
+                        modified_content += "\n"
+
+                    subprocess.run(
+                        ["crontab", "-"], input=modified_content, text=True, check=True
+                    )
+                    Logger.print_ok("The Klipper-Backup entry has been removed from the crontab.")
+                else:
+                    Logger.print_info("The Klipper-Backup entry is not present in the crontab. Skipping ...")
             except subprocess.CalledProcessError:
                 Logger.print_error("Unable to remove the Klipper-Backup cron entry")
 
-            # Remove moonraker entry
-            try:
-                remove_moonraker_entry()
-            except:
-                Logger.print_error("Unable to remove the Klipper-Backup moonraker entry")
 
-            # Remove Klipper-backup extension
-            Logger.print_status("Removing Klipper-Backup extension ...")
+            # Remove Klipper-Backup
+            Logger.print_status(f"Removing '{KLIPPERBACKUP_DIR}' ...")
             try:
-                remove_with_sudo(KLIPPERBACKUP_DIR)
-                if check_file_exist(KLIPPERBACKUP_CONFIG_DIR):
-                    remove_with_sudo(KLIPPERBACKUP_CONFIG_DIR)
+                shutil.rmtree(KLIPPERBACKUP_DIR)
+                config_backup_exists = check_file_exist(KLIPPERBACKUP_CONFIG_DIR)
+                if config_backup_exists:
+                    shutil.rmtree(KLIPPERBACKUP_CONFIG_DIR)
                 Logger.print_ok("Extension Klipper-Backup successfully removed!")
-            except:
-                Logger.print_error(f"Unable to remove Klipper-Backup extension")
+            except OSError as e:
+                Logger.print_error(f"Unable to remove extension: {e}")
 
     def install_extension(self, **kwargs) -> None:
         if not KLIPPERBACKUP_DIR.exists():
-            git_cmd_clone(KLIPPERBACKUP_REPO_URL, KLIPPERBACKUP_DIR)
+            subprocess.run(
+                ["git", "clone", str(KLIPPERBACKUP_REPO_URL), str(KLIPPERBACKUP_DIR)]
+            )
             subprocess.run(["chmod", "+x", str(KLIPPERBACKUP_DIR / "install.sh")])
         subprocess.run([str(KLIPPERBACKUP_DIR / "install.sh")])
 
     def update_extension(self, **kwargs) -> None:
-        if not check_file_exist(KLIPPERBACKUP_DIR):
+        extension_installed = check_file_exist(KLIPPERBACKUP_DIR)
+        if not extension_installed:
             Logger.print_info("Extension does not seem to be installed! Skipping ...")
-            return
-        subprocess.run([str(KLIPPERBACKUP_DIR / "install.sh"), "check_updates"])
+            remove_extension()
+        else:
+            subprocess.run([str(KLIPPERBACKUP_DIR / "install.sh"), "check_updates"])

kiauh/extensions/mainsail_theme_installer/mainsail_theme_installer_extension.py

@@ -12,8 +12,7 @@ import csv
 import shutil
 import textwrap
 import urllib.request
-from dataclasses import dataclass
-from typing import Any, Dict, List, Type, Union
+from typing import List, Type, TypedDict, Union
 
 from components.klipper.klipper import Klipper
 from components.klipper.klipper_dialogs import (
@@ -22,18 +21,16 @@ from components.klipper.klipper_dialogs import (
 )
 from core.constants import COLOR_CYAN, COLOR_YELLOW, RESET_FORMAT
 from core.instance_manager.base_instance import BaseInstance
-from core.instance_type import InstanceType
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import Logger
 from core.menus import Option
 from core.menus.base_menu import BaseMenu
 from extensions.base_extension import BaseExtension
 from utils.git_utils import git_clone_wrapper
 from utils.input_utils import get_selection_input
-from utils.instance_utils import get_instances
 
 
-@dataclass
-class ThemeData:
+class ThemeData(TypedDict):
     name: str
     short_note: str
     author: str
@@ -42,7 +39,8 @@ class ThemeData:
 
 # noinspection PyMethodMayBeStatic
 class MainsailThemeInstallerExtension(BaseExtension):
-    instances: List[Klipper] = get_instances(Klipper)
+    im = InstanceManager(Klipper)
+    instances: List[Klipper] = im.instances
 
     def install_extension(self, **kwargs) -> None:
         MainsailThemeInstallMenu(self.instances).run()
@@ -93,7 +91,7 @@ class MainsailThemeInstallMenu(BaseMenu):
 
     def set_options(self) -> None:
         self.options = {
-            f"{index}": Option(self.install_theme, opt_index=f"{index}")
+            f"{index}": Option(self.install_theme, False, opt_index=f"{index}")
             for index in range(len(self.themes))
         }
 
@@ -104,45 +102,36 @@ class MainsailThemeInstallMenu(BaseMenu):
         count = 62 - len(color) - len(RESET_FORMAT)
         menu = textwrap.dedent(
             f"""
-            ╔═══════════════════════════════════════════════════════╗
-            ║ {color}{header:~^{count}}{RESET_FORMAT} ║
-            ╟───────────────────────────────────────────────────────╢
-            ║ {line1:<62} ║
-            ║ https://docs.mainsail.xyz/theming/themes              ║
-            ╟───────────────────────────────────────────────────────╢
+            /=======================================================\\
+            | {color}{header:~^{count}}{RESET_FORMAT} |
+            |-------------------------------------------------------|
+            | {line1:<62} |
+            | https://docs.mainsail.xyz/theming/themes              |
+            |-------------------------------------------------------|
             """
         )[1:]
         for i, theme in enumerate(self.themes):
-            j: str = f" {i}" if i < 10 else f"{i}"
-            row: str = f"{j}) [{theme.name}]"
-            menu += f"║ {row:<53} ║\n"
+            i = f" {i}" if i < 10 else f"{i}"
+            row = f"{i}) [{theme.get('name')}]"
+            menu += f"| {row:<53} |\n"
         print(menu, end="")
 
     def load_themes(self) -> List[ThemeData]:
         with urllib.request.urlopen(self.THEMES_URL) as response:
             themes: List[ThemeData] = []
-            content: str = response.read().decode()
-            csv_data: List[str] = content.splitlines()
-            fieldnames = ["name", "short_note", "author", "repo"]
-            csv_reader = csv.DictReader(csv_data, fieldnames=fieldnames, delimiter=",")
-            next(csv_reader)  # skip the header of the csv file
+            csv_data: str = response.read().decode().splitlines()
+            csv_reader = csv.DictReader(csv_data, delimiter=",")
             for row in csv_reader:
-                row: Dict[str, str]  # type: ignore
-                theme: ThemeData = ThemeData(**row)
-                themes.append(theme)
+                row: ThemeData = row
+                themes.append(row)
 
         return themes
 
-    def install_theme(self, **kwargs: Any):
-        opt_index: str | None = kwargs.get("opt_index", None)
-
-        if not opt_index:
-            raise ValueError("No option index provided")
-
-        index: int = int(opt_index)
+    def install_theme(self, **kwargs):
+        index = int(kwargs.get("opt_index"))
         theme_data: ThemeData = self.themes[index]
-        theme_author: str = theme_data.author
-        theme_repo: str = theme_data.repo
+        theme_author: str = theme_data.get("author")
+        theme_repo: str = theme_data.get("repo")
         theme_repo_url: str = f"https://github.com/{theme_author}/{theme_repo}"
 
         print_instance_overview(
@@ -160,13 +149,13 @@ class MainsailThemeInstallMenu(BaseMenu):
         for printer in printer_list:
             git_clone_wrapper(theme_repo_url, printer.cfg_dir.joinpath(".theme"))
 
-        if len(theme_data.short_note) > 1:
+        if len(theme_data.get("short_note", "")) > 1:
             Logger.print_warn("Info from the creator:", prefix=False, start="\n")
-            Logger.print_info(theme_data.short_note, prefix=False, end="\n\n")
+            Logger.print_info(theme_data.get("short_note"), prefix=False, end="\n\n")
 
 
 def get_printer_selection(
-    instances: List[InstanceType], is_install: bool
+    instances: List[BaseInstance], is_install: bool
 ) -> Union[List[BaseInstance], None]:
     options = [str(i) for i in range(len(instances))]
     options.extend(["a", "b"])

kiauh/extensions/obico/moonraker_obico.py

@@ -8,12 +8,10 @@
 # ======================================================================= #
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
 from subprocess import CalledProcessError, run
 
-from components.moonraker.moonraker import Moonraker
-from core.constants import CURRENT_USER
 from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
 from core.submodules.simple_config_parser.src.simple_config_parser.simple_config_parser import (
@@ -29,32 +27,24 @@ from extensions.obico import (
     OBICO_LOG_NAME,
     OBICO_SERVICE_TEMPLATE,
 )
-from utils.fs_utils import create_folders
-from utils.sys_utils import get_service_file_path
 
 
 # noinspection PyMethodMayBeStatic
-@dataclass(repr=True)
-class MoonrakerObico:
-    suffix: str
-    base: BaseInstance = field(init=False, repr=False)
-    service_file_path: Path = field(init=False)
-    log_file_name: str = OBICO_LOG_NAME
+@dataclass
+class MoonrakerObico(BaseInstance):
     dir: Path = OBICO_DIR
     env_dir: Path = OBICO_ENV_DIR
-    data_dir: Path = field(init=False)
-    cfg_file: Path = field(init=False)
+    cfg_file: Path | None = None
+    log: Path | None = None
     is_linked: bool = False
 
-    def __post_init__(self):
-        self.base: BaseInstance = BaseInstance(Moonraker, self.suffix)
-        self.base.log_file_name = self.log_file_name
+    def __init__(self, suffix: str = ""):
+        super().__init__(suffix=suffix)
 
-        self.service_file_path: Path = get_service_file_path(
-            MoonrakerObico, self.suffix
-        )
-        self.data_dir: Path = self.base.data_dir
-        self.cfg_file = self.base.cfg_dir.joinpath(OBICO_CFG_NAME)
+    def __post_init__(self):
+        super().__post_init__()
+        self.cfg_file = self.cfg_dir.joinpath(OBICO_CFG_NAME)
+        self.log = self.log_dir.joinpath(OBICO_LOG_NAME)
         self.is_linked: bool = self._check_link_status()
 
     def create(self) -> None:
@@ -63,13 +53,13 @@ class MoonrakerObico:
         Logger.print_status("Creating new Obico for Klipper Instance ...")
 
         try:
-            create_folders(self.base.base_folders)
+            self.create_folders()
             create_service_file(
-                name=self.service_file_path.name,
+                name=self.get_service_file_name(extension=True),
                 content=self._prep_service_file_content(),
             )
             create_env_file(
-                path=self.base.sysd_dir.joinpath(OBICO_ENV_FILE_NAME),
+                path=self.sysd_dir.joinpath(OBICO_ENV_FILE_NAME),
                 content=self._prep_env_file_content(),
             )
 
@@ -80,9 +70,24 @@ class MoonrakerObico:
             Logger.print_error(f"Error creating env file: {e}")
             raise
 
+    def delete(self) -> None:
+        service_file: str = self.get_service_file_name(extension=True)
+        service_file_path: Path = self.get_service_file_path()
+
+        Logger.print_status(f"Deleting Obico for Klipper Instance: {service_file}")
+
+        try:
+            command = ["sudo", "rm", "-f", service_file_path.as_posix()]
+            run(command, check=True)
+            self.delete_logfiles(OBICO_LOG_NAME)
+            Logger.print_ok(f"Service file deleted: {service_file_path}")
+        except CalledProcessError as e:
+            Logger.print_error(f"Error deleting service file: {e}")
+            raise
+
     def link(self) -> None:
         Logger.print_status(
-            f"Linking instance for printer {self.data_dir.name} to the Obico server ..."
+            f"Linking instance for printer {self.data_dir_name} to the Obico server ..."
         )
         try:
             cmd = [f"{OBICO_LINK_SCRIPT} -q -c {self.cfg_file}"]
@@ -105,7 +110,7 @@ class MoonrakerObico:
 
         service_content = template_content.replace(
             "%USER%",
-            CURRENT_USER,
+            self.user,
         )
         service_content = service_content.replace(
             "%OBICO_DIR%",
@@ -117,7 +122,7 @@ class MoonrakerObico:
         )
         service_content = service_content.replace(
             "%ENV_FILE%",
-            self.base.sysd_dir.joinpath(OBICO_ENV_FILE_NAME).as_posix(),
+            self.sysd_dir.joinpath(OBICO_ENV_FILE_NAME).as_posix(),
         )
         return service_content
 
@@ -132,7 +137,7 @@ class MoonrakerObico:
             raise
         env_file_content = env_template_file_content.replace(
             "%CFG%",
-            f"{self.base.cfg_dir}/{self.cfg_file}",
+            f"{self.cfg_dir}/{self.cfg_file}",
         )
         return env_file_content
 

kiauh/extensions/obico/moonraker_obico_extension.py

@@ -38,10 +38,8 @@ from utils.config_utils import (
 from utils.fs_utils import run_remove_routines
 from utils.git_utils import git_clone_wrapper, git_pull_wrapper
 from utils.input_utils import get_confirm, get_selection_input, get_string_input
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     cmd_sysctl_manage,
-    cmd_sysctl_service,
     create_python_venv,
     install_python_requirements,
     parse_packages_from_file,
@@ -62,7 +60,8 @@ class ObicoExtension(BaseExtension):
         # if obico is already installed, ask if the user wants to repair an
         # incomplete installation or link to the obico server
         force_clone = False
-        obico_instances: List[MoonrakerObico] = get_instances(MoonrakerObico)
+        obico_im = InstanceManager(MoonrakerObico)
+        obico_instances: List[MoonrakerObico] = obico_im.instances
         if obico_instances:
             self._print_is_already_installed()
             options = ["l", "r", "b"]
@@ -81,8 +80,10 @@ class ObicoExtension(BaseExtension):
                 force_clone = True
 
         # let the user confirm installation
-        kl_instances: List[Klipper] = get_instances(Klipper)
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
+        kl_im = InstanceManager(Klipper)
+        kl_instances: List[Klipper] = kl_im.instances
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
         self._print_moonraker_instances(mr_instances)
         if not get_confirm(
             "Continue Obico for Klipper installation?",
@@ -100,13 +101,14 @@ class ObicoExtension(BaseExtension):
 
             # create obico instances
             for moonraker in mr_instances:
-                instance = MoonrakerObico(suffix=moonraker.suffix)
-                instance.create()
+                current_instance = MoonrakerObico(suffix=moonraker.suffix)
 
-                cmd_sysctl_service(instance.service_file_path.name, "enable")
+                obico_im.current_instance = current_instance
+                obico_im.create_instance()
+                obico_im.enable_instance()
 
                 # create obico config
-                self._create_obico_cfg(instance, moonraker)
+                self._create_obico_cfg(current_instance, moonraker)
 
                 # create obico macros
                 self._create_obico_macros_cfg(moonraker)
@@ -114,17 +116,17 @@ class ObicoExtension(BaseExtension):
                 # create obico update manager
                 self._create_obico_update_manager_cfg(moonraker)
 
-                cmd_sysctl_service(instance.service_file_path.name, "start")
+                obico_im.start_instance()
 
             cmd_sysctl_manage("daemon-reload")
 
             # add to klippers config
             self._patch_printer_cfg(kl_instances)
-            InstanceManager.restart_all(kl_instances)
+            kl_im.restart_all_instance()
 
             # add to moonraker update manager
             self._patch_moonraker_conf(mr_instances)
-            InstanceManager.restart_all(mr_instances)
+            mr_im.restart_all_instance()
 
             # check linking of / ask for linking instances
             self._check_and_opt_link_instances()
@@ -141,13 +143,13 @@ class ObicoExtension(BaseExtension):
     def update_extension(self, **kwargs) -> None:
         Logger.print_status("Updating Obico for Klipper ...")
         try:
-            instances = get_instances(MoonrakerObico)
-            InstanceManager.stop_all(instances)
+            tb_im = InstanceManager(MoonrakerObico)
+            tb_im.stop_all_instance()
 
             git_pull_wrapper(OBICO_REPO, OBICO_DIR)
             self._install_dependencies()
 
-            InstanceManager.start_all(instances)
+            tb_im.start_all_instance()
             Logger.print_ok("Obico for Klipper successfully updated!")
 
         except Exception as e:
@@ -155,13 +157,15 @@ class ObicoExtension(BaseExtension):
 
     def remove_extension(self, **kwargs) -> None:
         Logger.print_status("Removing Obico for Klipper ...")
-
-        kl_instances: List[Klipper] = get_instances(Klipper)
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
-        ob_instances: List[MoonrakerObico] = get_instances(MoonrakerObico)
+        kl_im = InstanceManager(Klipper)
+        kl_instances: List[Klipper] = kl_im.instances
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
+        ob_im = InstanceManager(MoonrakerObico)
+        ob_instances: List[MoonrakerObico] = ob_im.instances
 
         try:
-            self._remove_obico_instances(ob_instances)
+            self._remove_obico_instances(ob_im, ob_instances)
             self._remove_obico_dir()
             self._remove_obico_env()
             remove_config_section(f"include {OBICO_MACROS_CFG_NAME}", kl_instances)
@@ -193,8 +197,8 @@ class ObicoExtension(BaseExtension):
             ],
         )
 
-    def _print_moonraker_instances(self, mr_instances: List[Moonraker]) -> None:
-        mr_names = [f"● {moonraker.data_dir.name}" for moonraker in mr_instances]
+    def _print_moonraker_instances(self, mr_instances) -> None:
+        mr_names = [f"● {moonraker.data_dir_name}" for moonraker in mr_instances]
         if len(mr_names) > 1:
             Logger.print_dialog(
                 DialogType.INFO,
@@ -239,24 +243,24 @@ class ObicoExtension(BaseExtension):
         if create_python_venv(OBICO_ENV_DIR):
             install_python_requirements(OBICO_ENV_DIR, OBICO_REQ_FILE)
 
-    def _create_obico_macros_cfg(self, moonraker: Moonraker) -> None:
+    def _create_obico_macros_cfg(self, moonraker) -> None:
         macros_cfg = OBICO_DIR.joinpath(f"include_cfgs/{OBICO_MACROS_CFG_NAME}")
-        macros_target = moonraker.base.cfg_dir.joinpath(OBICO_MACROS_CFG_NAME)
+        macros_target = moonraker.cfg_dir.joinpath(OBICO_MACROS_CFG_NAME)
         if not macros_target.exists():
             shutil.copy(macros_cfg, macros_target)
         else:
             Logger.print_info(
-                f"Obico's '{OBICO_MACROS_CFG_NAME}' in {moonraker.base.cfg_dir} already exists! Skipped ..."
+                f"Obico's '{OBICO_MACROS_CFG_NAME}' in {moonraker.cfg_dir} already exists! Skipped ..."
             )
 
-    def _create_obico_update_manager_cfg(self, moonraker: Moonraker) -> None:
+    def _create_obico_update_manager_cfg(self, moonraker) -> None:
         update_cfg = OBICO_DIR.joinpath(OBICO_UPDATE_CFG_SAMPLE_NAME)
-        update_cfg_target = moonraker.base.cfg_dir.joinpath(OBICO_UPDATE_CFG_NAME)
+        update_cfg_target = moonraker.cfg_dir.joinpath(OBICO_UPDATE_CFG_NAME)
         if not update_cfg_target.exists():
             shutil.copy(update_cfg, update_cfg_target)
         else:
             Logger.print_info(
-                f"Obico's '{OBICO_UPDATE_CFG_NAME}' in {moonraker.base.cfg_dir} already exists! Skipped ..."
+                f"Obico's '{OBICO_UPDATE_CFG_NAME}' in {moonraker.cfg_dir} already exists! Skipped ..."
             )
 
     def _create_obico_cfg(
@@ -276,7 +280,7 @@ class ObicoExtension(BaseExtension):
             self._patch_obico_cfg(moonraker, current_instance)
         else:
             Logger.print_info(
-                f"Obico config in {current_instance.base.cfg_dir} already exists! Skipped ..."
+                f"Obico config in {current_instance.cfg_dir} already exists! Skipped ..."
             )
 
     def _patch_obico_cfg(self, moonraker: Moonraker, obico: MoonrakerObico) -> None:
@@ -284,11 +288,7 @@ class ObicoExtension(BaseExtension):
         scp.read(obico.cfg_file)
         scp.set("server", "url", self.server_url)
         scp.set("moonraker", "port", str(moonraker.port))
-        scp.set(
-            "logging",
-            "path",
-            obico.base.log_dir.joinpath(obico.log_file_name).as_posix(),
-        )
+        scp.set("logging", "path", obico.log.as_posix())
         scp.write(obico.cfg_file)
 
     def _patch_printer_cfg(self, klipper: List[Klipper]) -> None:
@@ -307,8 +307,8 @@ class ObicoExtension(BaseExtension):
 
     def _check_and_opt_link_instances(self) -> None:
         Logger.print_status("Checking link status of Obico instances ...")
-
-        ob_instances: List[MoonrakerObico] = get_instances(MoonrakerObico)
+        ob_im = InstanceManager(MoonrakerObico)
+        ob_instances: List[MoonrakerObico] = ob_im.instances
         unlinked_instances: List[MoonrakerObico] = [
             obico for obico in ob_instances if not obico.is_linked
         ]
@@ -318,7 +318,7 @@ class ObicoExtension(BaseExtension):
                 [
                     "The Obico instances for the following printers are not "
                     "linked to the server:",
-                    *[f"● {obico.data_dir.name}" for obico in unlinked_instances],
+                    *[f"● {obico.data_dir_name}" for obico in unlinked_instances],
                     "\n\n",
                     "It will take only 10 seconds to link the printer to the Obico server.",
                     "For more information visit:",
@@ -336,6 +336,7 @@ class ObicoExtension(BaseExtension):
 
     def _remove_obico_instances(
         self,
+        instance_manager: InstanceManager,
         instance_list: List[MoonrakerObico],
     ) -> None:
         if not instance_list:
@@ -344,9 +345,14 @@ class ObicoExtension(BaseExtension):
 
         for instance in instance_list:
             Logger.print_status(
-                f"Removing instance {instance.service_file_path.stem} ..."
+                f"Removing instance {instance.get_service_file_name()} ..."
             )
-            InstanceManager.remove(instance)
+            instance_manager.current_instance = instance
+            instance_manager.stop_instance()
+            instance_manager.disable_instance()
+            instance_manager.delete_instance()
+
+        cmd_sysctl_manage("daemon-reload")
 
     def _remove_obico_dir(self) -> None:
         Logger.print_status("Removing Obico for Klipper directory ...")

kiauh/extensions/pretty_gcode/pretty_gcode_extension.py

@@ -9,12 +9,12 @@
 import shutil
 from pathlib import Path
 
-from components.webui_client.client_utils import create_nginx_cfg
 from core.constants import NGINX_SITES_AVAILABLE, NGINX_SITES_ENABLED
 from core.logger import DialogType, Logger
 from extensions.base_extension import BaseExtension
 from utils.common import check_install_dependencies
 from utils.fs_utils import (
+    create_nginx_cfg,
     remove_file,
 )
 from utils.git_utils import git_clone_wrapper, git_pull_wrapper
@@ -51,11 +51,14 @@ class PrettyGcodeExtension(BaseExtension):
         check_install_dependencies({"nginx"})
 
         try:
+            # remove any existing pgc dir
             if PGC_DIR.exists():
                 shutil.rmtree(PGC_DIR)
 
+            # clone pgc repo
             git_clone_wrapper(PGC_REPO, PGC_DIR)
 
+            # copy pgc conf
             create_nginx_cfg(
                 "PrettyGCode for Klipper",
                 cfg_name=PGC_CONF,

kiauh/extensions/telegram_bot/moonraker_telegram_bot.py

@@ -8,12 +8,10 @@
 # ======================================================================= #
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from pathlib import Path
-from subprocess import CalledProcessError
+from subprocess import CalledProcessError, run
 
-from components.moonraker.moonraker import Moonraker
-from core.constants import CURRENT_USER
 from core.instance_manager.base_instance import BaseInstance
 from core.logger import Logger
 from extensions.telegram_bot import (
@@ -25,31 +23,23 @@ from extensions.telegram_bot import (
     TG_BOT_LOG_NAME,
     TG_BOT_SERVICE_TEMPLATE,
 )
-from utils.fs_utils import create_folders
-from utils.sys_utils import get_service_file_path
 
 
 # noinspection PyMethodMayBeStatic
-@dataclass(repr=True)
-class MoonrakerTelegramBot:
-    suffix: str
-    base: BaseInstance = field(init=False, repr=False)
-    service_file_path: Path = field(init=False)
-    log_file_name: str = TG_BOT_LOG_NAME
+@dataclass
+class MoonrakerTelegramBot(BaseInstance):
     bot_dir: Path = TG_BOT_DIR
     env_dir: Path = TG_BOT_ENV
-    data_dir: Path = field(init=False)
-    cfg_file: Path = field(init=False)
+    cfg_file: Path | None = None
+    log: Path | None = None
+
+    def __init__(self, suffix: str = ""):
+        super().__init__(suffix=suffix)
 
     def __post_init__(self):
-        self.base: BaseInstance = BaseInstance(Moonraker, self.suffix)
-        self.base.log_file_name = self.log_file_name
-
-        self.service_file_path: Path = get_service_file_path(
-            MoonrakerTelegramBot, self.suffix
-        )
-        self.data_dir: Path = self.base.data_dir
-        self.cfg_file = self.base.cfg_dir.joinpath(TG_BOT_CFG_NAME)
+        super().__post_init__()
+        self.cfg_file = self.cfg_dir.joinpath(TG_BOT_CFG_NAME)
+        self.log = self.log_dir.joinpath(TG_BOT_LOG_NAME)
 
     def create(self) -> None:
         from utils.sys_utils import create_env_file, create_service_file
@@ -57,13 +47,13 @@ class MoonrakerTelegramBot:
         Logger.print_status("Creating new Moonraker Telegram Bot Instance ...")
 
         try:
-            create_folders(self.base.base_folders)
+            self.create_folders()
             create_service_file(
-                name=self.service_file_path.name,
+                name=self.get_service_file_name(extension=True),
                 content=self._prep_service_file_content(),
             )
             create_env_file(
-                path=self.base.sysd_dir.joinpath(TG_BOT_ENV_FILE_NAME),
+                path=self.sysd_dir.joinpath(TG_BOT_ENV_FILE_NAME),
                 content=self._prep_env_file_content(),
             )
 
@@ -74,6 +64,20 @@ class MoonrakerTelegramBot:
             Logger.print_error(f"Error creating env file: {e}")
             raise
 
+    def delete(self) -> None:
+        service_file: str = self.get_service_file_name(extension=True)
+        service_file_path: Path = self.get_service_file_path()
+
+        Logger.print_status(f"Deleting Moonraker Telegram Bot Instance: {service_file}")
+
+        try:
+            command = ["sudo", "rm", "-f", service_file_path.as_posix()]
+            run(command, check=True)
+            Logger.print_ok(f"Service file deleted: {service_file_path}")
+        except CalledProcessError as e:
+            Logger.print_error(f"Error deleting service file: {e}")
+            raise
+
     def _prep_service_file_content(self) -> str:
         template = TG_BOT_SERVICE_TEMPLATE
 
@@ -86,7 +90,7 @@ class MoonrakerTelegramBot:
 
         service_content = template_content.replace(
             "%USER%",
-            CURRENT_USER,
+            self.user,
         )
         service_content = service_content.replace(
             "%TELEGRAM_BOT_DIR%",
@@ -98,7 +102,7 @@ class MoonrakerTelegramBot:
         )
         service_content = service_content.replace(
             "%ENV_FILE%",
-            self.base.sysd_dir.joinpath(TG_BOT_ENV_FILE_NAME).as_posix(),
+            self.sysd_dir.joinpath(TG_BOT_ENV_FILE_NAME).as_posix(),
         )
         return service_content
 
@@ -118,10 +122,10 @@ class MoonrakerTelegramBot:
         )
         env_file_content = env_file_content.replace(
             "%CFG%",
-            f"{self.base.cfg_dir}/printer.cfg",
+            f"{self.cfg_dir}/printer.cfg",
         )
         env_file_content = env_file_content.replace(
             "%LOG%",
-            self.base.log_dir.joinpath(self.log_file_name).as_posix(),
+            self.log.as_posix() if self.log else "",
         )
         return env_file_content

kiauh/extensions/telegram_bot/moonraker_telegram_bot_extension.py

@@ -25,10 +25,8 @@ from utils.config_utils import add_config_section, remove_config_section
 from utils.fs_utils import remove_file
 from utils.git_utils import git_clone_wrapper, git_pull_wrapper
 from utils.input_utils import get_confirm
-from utils.instance_utils import get_instances
 from utils.sys_utils import (
     cmd_sysctl_manage,
-    cmd_sysctl_service,
     create_python_venv,
     install_python_requirements,
     parse_packages_from_file,
@@ -39,8 +37,8 @@ from utils.sys_utils import (
 class TelegramBotExtension(BaseExtension):
     def install_extension(self, **kwargs) -> None:
         Logger.print_status("Installing Moonraker Telegram Bot ...")
-
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
         if not mr_instances:
             Logger.print_dialog(
                 DialogType.WARNING,
@@ -52,9 +50,7 @@ class TelegramBotExtension(BaseExtension):
             )
             return
 
-        instance_names = [
-            f"● {instance.service_file_path.name}" for instance in mr_instances
-        ]
+        instance_names = [f"● {instance.data_dir_name}" for instance in mr_instances]
         Logger.print_dialog(
             DialogType.INFO,
             [
@@ -79,28 +75,30 @@ class TelegramBotExtension(BaseExtension):
 
             # create and start services / create bot configs
             show_config_dialog = False
+            tb_im = InstanceManager(MoonrakerTelegramBot)
             tb_names = [mr_i.suffix for mr_i in mr_instances]
             for name in tb_names:
-                instance = MoonrakerTelegramBot(suffix=name)
-                instance.create()
+                current_instance = MoonrakerTelegramBot(suffix=name)
 
-                cmd_sysctl_service(instance.service_file_path.name, "enable")
+                tb_im.current_instance = current_instance
+                tb_im.create_instance()
+                tb_im.enable_instance()
 
                 if create_example_cfg:
                     Logger.print_status(
-                        f"Creating Telegram Bot config in {instance.base.cfg_dir} ..."
+                        f"Creating Telegram Bot config in {current_instance.cfg_dir} ..."
                     )
                     template = TG_BOT_DIR.joinpath("scripts/base_install_template")
-                    target_file = instance.cfg_file
+                    target_file = current_instance.cfg_file
                     if not target_file.exists():
                         show_config_dialog = True
                         run(["cp", template, target_file], check=True)
                     else:
                         Logger.print_info(
-                            f"Telegram Bot config in {instance.base.cfg_dir} already exists! Skipped ..."
+                            f"Telegram Bot config in {current_instance.cfg_dir} already exists! Skipped ..."
                         )
 
-                cmd_sysctl_service(instance.service_file_path.name, "start")
+                tb_im.start_instance()
 
             cmd_sysctl_manage("daemon-reload")
 
@@ -108,7 +106,7 @@ class TelegramBotExtension(BaseExtension):
             self._patch_bot_update_manager(mr_instances)
 
             # restart moonraker
-            InstanceManager.restart_all(mr_instances)
+            mr_im.restart_all_instance()
 
             if show_config_dialog:
                 Logger.print_dialog(
@@ -120,7 +118,6 @@ class TelegramBotExtension(BaseExtension):
                         "following wiki page for further information:",
                         "https://github.com/nlef/moonraker-telegram-bot/wiki",
                     ],
-                    margin_bottom=1,
                 )
 
             Logger.print_ok("Telegram Bot installation complete!")
@@ -131,23 +128,23 @@ class TelegramBotExtension(BaseExtension):
 
     def update_extension(self, **kwargs) -> None:
         Logger.print_status("Updating Moonraker Telegram Bot ...")
-
-        instances = get_instances(MoonrakerTelegramBot)
-        InstanceManager.stop_all(instances)
+        tb_im = InstanceManager(MoonrakerTelegramBot)
+        tb_im.stop_all_instance()
 
         git_pull_wrapper(TG_BOT_REPO, TG_BOT_DIR)
         self._install_dependencies()
 
-        InstanceManager.start_all(instances)
+        tb_im.start_all_instance()
 
     def remove_extension(self, **kwargs) -> None:
         Logger.print_status("Removing Moonraker Telegram Bot ...")
-
-        mr_instances: List[Moonraker] = get_instances(Moonraker)
-        tb_instances: List[MoonrakerTelegramBot] = get_instances(MoonrakerTelegramBot)
+        mr_im = InstanceManager(Moonraker)
+        mr_instances: List[Moonraker] = mr_im.instances
+        tb_im = InstanceManager(MoonrakerTelegramBot)
+        tb_instances: List[MoonrakerTelegramBot] = tb_im.instances
 
         try:
-            self._remove_bot_instances(tb_instances)
+            self._remove_bot_instances(tb_im, tb_instances)
             self._remove_bot_dir()
             self._remove_bot_env()
             remove_config_section("update_manager moonraker-telegram-bot", mr_instances)
@@ -184,13 +181,19 @@ class TelegramBotExtension(BaseExtension):
 
     def _remove_bot_instances(
         self,
+        instance_manager: InstanceManager,
         instance_list: List[MoonrakerTelegramBot],
     ) -> None:
         for instance in instance_list:
             Logger.print_status(
-                f"Removing instance {instance.service_file_path.stem} ..."
+                f"Removing instance {instance.get_service_file_name()} ..."
             )
-            InstanceManager.remove(instance)
+            instance_manager.current_instance = instance
+            instance_manager.stop_instance()
+            instance_manager.disable_instance()
+            instance_manager.delete_instance()
+
+        cmd_sysctl_manage("daemon-reload")
 
     def _remove_bot_dir(self) -> None:
         if not TG_BOT_DIR.exists():
@@ -215,7 +218,7 @@ class TelegramBotExtension(BaseExtension):
     def _delete_bot_logs(self, instances: List[MoonrakerTelegramBot]) -> None:
         all_logfiles = []
         for instance in instances:
-            all_logfiles = list(instance.base.log_dir.glob("telegram_bot.log*"))
+            all_logfiles = list(instance.log_dir.glob("telegram_bot.log*"))
         if not all_logfiles:
             Logger.print_info("No Moonraker Telegram Bot logs found. Skipped ...")
             return

kiauh/procedures/system.py

@@ -35,6 +35,8 @@ def change_system_hostname() -> None:
             "browser.",
         ],
         custom_title="CHANGE SYSTEM HOSTNAME",
+        padding_top=0,
+        padding_bottom=0,
     )
     if not get_confirm("Do you want to change the hostname?", default_choice=False):
         return
@@ -48,6 +50,8 @@ def change_system_hostname() -> None:
             "● Any special characters",
             "● No leading or trailing '-'",
         ],
+        padding_top=0,
+        padding_bottom=0,
     )
     hostname = get_string_input(
         "Enter the new hostname",

kiauh/utils/common.py

@@ -11,7 +11,7 @@ from __future__ import annotations
 import re
 from datetime import datetime
 from pathlib import Path
-from typing import Dict, List, Literal, Optional, Set
+from typing import Dict, List, Literal, Optional, Set, Type
 
 from components.klipper.klipper import Klipper
 from core.constants import (
@@ -20,15 +20,11 @@ from core.constants import (
     PRINTER_CFG_BACKUP_DIR,
     RESET_FORMAT,
 )
+from core.instance_manager.base_instance import BaseInstance
+from core.instance_manager.instance_manager import InstanceManager
 from core.logger import DialogType, Logger
 from core.types import ComponentStatus, StatusCode
-from utils.git_utils import (
-    get_local_commit,
-    get_local_tags,
-    get_remote_commit,
-    get_repo_name,
-)
-from utils.instance_utils import get_instances
+from utils.git_utils import get_local_commit, get_remote_commit, get_repo_name
 from utils.sys_utils import (
     check_package_install,
     install_system_packages,
@@ -36,14 +32,6 @@ from utils.sys_utils import (
 )
 
 
-def get_kiauh_version() -> str:
-    """
-    Helper method to get the current KIAUH version by reading the latest tag
-    :return: string of the latest tag
-    """
-    return get_local_tags(Path(__file__).parent.parent)[-1]
-
-
 def convert_camelcase_to_kebabcase(name: str) -> str:
     return re.sub(r"(?<!^)(?=[A-Z])", "-", name).lower()
 
@@ -89,7 +77,7 @@ def check_install_dependencies(
 def get_install_status(
     repo_dir: Path,
     env_dir: Optional[Path] = None,
-    instance_type: type | None = None,
+    instance_type: Optional[Type[BaseInstance]] = None,
     files: Optional[List[Path]] = None,
 ) -> ComponentStatus:
     """
@@ -100,16 +88,15 @@ def get_install_status(
     :param files: List of optional files to check for existence
     :return: Dictionary with status string, statuscode and instance count
     """
-    from utils.instance_utils import get_instances
-
     checks = [repo_dir.exists()]
 
     if env_dir is not None:
         checks.append(env_dir.exists())
 
+    im = InstanceManager(instance_type)
     instances = 0
     if instance_type is not None:
-        instances = len(get_instances(instance_type))
+        instances = len(im.instances)
         checks.append(instances > 0)
 
     if files is not None:
@@ -137,14 +124,15 @@ def backup_printer_config_dir() -> None:
     # local import to prevent circular import
     from core.backup_manager.backup_manager import BackupManager
 
-    instances: List[Klipper] = get_instances(Klipper)
+    im = InstanceManager(Klipper)
+    instances: List[Klipper] = im.instances
     bm = BackupManager()
 
     for instance in instances:
-        name = f"config-{instance.data_dir.name}"
+        name = f"config-{instance.data_dir_name}"
         bm.backup_directory(
             name,
-            source=instance.base.cfg_dir,
+            source=instance.cfg_dir,
             target=PRINTER_CFG_BACKUP_DIR,
         )
 
@@ -157,7 +145,8 @@ def moonraker_exists(name: str = "") -> bool:
     """
     from components.moonraker.moonraker import Moonraker
 
-    mr_instances: List[Moonraker] = get_instances(Moonraker)
+    mr_im = InstanceManager(Moonraker)
+    mr_instances: List[Moonraker] = mr_im.instances
 
     info = (
         f"{name} requires Moonraker to be installed"

kiauh/utils/config_utils.py

@@ -6,25 +6,25 @@
 #                                                                         #
 #  This file may be distributed under the terms of the GNU GPLv3 license  #
 # ======================================================================= #
-from __future__ import annotations
-
 import tempfile
 from pathlib import Path
-from typing import List, Tuple
+from typing import List, Optional, Tuple, TypeVar
 
-from core.instance_type import InstanceType
+from components.klipper.klipper import Klipper
+from components.moonraker.moonraker import Moonraker
 from core.logger import Logger
 from core.submodules.simple_config_parser.src.simple_config_parser.simple_config_parser import (
     SimpleConfigParser,
 )
 
+B = TypeVar("B", Klipper, Moonraker)
 ConfigOption = Tuple[str, str]
 
 
 def add_config_section(
     section: str,
-    instances: List[InstanceType],
-    options: List[ConfigOption] | None = None,
+    instances: List[B],
+    options: Optional[List[ConfigOption]] = None,
 ) -> None:
     for instance in instances:
         cfg_file = instance.cfg_file
@@ -49,7 +49,7 @@ def add_config_section(
         scp.write(cfg_file)
 
 
-def add_config_section_at_top(section: str, instances: List[InstanceType]) -> None:
+def add_config_section_at_top(section: str, instances: List[B]) -> None:
     # TODO: this could be implemented natively in SimpleConfigParser
     for instance in instances:
         tmp_cfg = tempfile.NamedTemporaryFile(mode="w", delete=False)
@@ -70,7 +70,7 @@ def add_config_section_at_top(section: str, instances: List[InstanceType]) -> No
         tmp_cfg_path.rename(cfg_file)
 
 
-def remove_config_section(section: str, instances: List[InstanceType]) -> None:
+def remove_config_section(section: str, instances: List[B]) -> None:
     for instance in instances:
         cfg_file = instance.cfg_file
         Logger.print_status(f"Remove section '[{section}]' from '{cfg_file}' ...")

kiauh/utils/fs_utils.py

@@ -8,13 +8,10 @@
 #                                                                         #
 #  This file may be distributed under the terms of the GNU GPLv3 license  #
 # ======================================================================= #
-from __future__ import annotations
 
-import re
 import shutil
 from pathlib import Path
 from subprocess import DEVNULL, PIPE, CalledProcessError, check_output, run
-from typing import List
 from zipfile import ZipFile
 
 from core.decorators import deprecated
@@ -106,37 +103,3 @@ def unzip(filepath: Path, target_dir: Path) -> None:
     """
     with ZipFile(filepath, "r") as _zip:
         _zip.extractall(target_dir)
-
-
-def create_folders(dirs: List[Path]) -> None:
-    try:
-        for _dir in dirs:
-            if _dir.exists():
-                continue
-            _dir.mkdir(exist_ok=True)
-            Logger.print_ok(f"Created directory '{_dir}'!")
-    except OSError as e:
-        Logger.print_error(f"Error creating directories: {e}")
-        raise
-
-
-def get_data_dir(instance_type: type, suffix: str) -> Path:
-    from utils.sys_utils import get_service_file_path
-
-    # if the service file exists, we read the data dir path from it
-    # this also ensures compatibility with pre v6.0.0 instances
-    service_file_path: Path = get_service_file_path(instance_type, suffix)
-    if service_file_path and service_file_path.exists():
-        with open(service_file_path, "r") as service_file:
-            lines = service_file.readlines()
-            for line in lines:
-                pattern = r"^EnvironmentFile=(.+)(/systemd/.+\.env)"
-                match = re.search(pattern, line)
-                if match:
-                    return Path(match.group(1))
-
-    if suffix != "":
-        # this is the new data dir naming scheme introduced in v6.0.0
-        return Path.home().joinpath(f"printer_{suffix}_data")
-
-    return Path.home().joinpath("printer_data")

kiauh/utils/git_utils.py

@@ -9,11 +9,10 @@ from pathlib import Path
 from subprocess import DEVNULL, PIPE, CalledProcessError, check_output, run
 from typing import List, Type
 
+from core.instance_manager.base_instance import BaseInstance
 from core.instance_manager.instance_manager import InstanceManager
-from core.instance_type import InstanceType
 from core.logger import Logger
 from utils.input_utils import get_confirm, get_number_input
-from utils.instance_utils import get_instances
 
 
 def git_clone_wrapper(
@@ -84,38 +83,7 @@ def get_repo_name(repo: Path) -> str | None:
         return None
 
 
-def get_local_tags(repo_path: Path, _filter: str | None = None) -> List[str]:
-    """
-    Get all tags of a local Git repository
-    :param repo_path: Path to the local Git repository
-    :param _filter: Optional filter to filter the tags by
-    :return: List of tags
-    """
-    try:
-        cmd = ["git", "tag", "-l"]
-
-        if _filter is not None:
-            cmd.append(f"'${_filter}'")
-
-        result: str = check_output(
-            cmd,
-            stderr=DEVNULL,
-            cwd=repo_path.as_posix(),
-        ).decode(encoding="utf-8")
-
-        tags = result.split("\n")
-        return tags[:-1]
-
-    except CalledProcessError:
-        return []
-
-
-def get_remote_tags(repo_path: str) -> List[str]:
-    """
-    Gets the tags of a GitHub repostiory
-    :param repo_path: path of the GitHub repository - e.g. `<owner>/<name>`
-    :return: List of tags
-    """
+def get_tags(repo_path: str) -> List[str]:
     try:
         url = f"https://api.github.com/repos/{repo_path}/tags"
         with urllib.request.urlopen(url) as r:
@@ -133,14 +101,14 @@ def get_remote_tags(repo_path: str) -> List[str]:
         raise
 
 
-def get_latest_remote_tag(repo_path: str) -> str:
+def get_latest_tag(repo_path: str) -> str:
     """
     Gets the latest stable tag of a GitHub repostiory
     :param repo_path: path of the GitHub repository - e.g. `<owner>/<name>`
     :return: tag or empty string
     """
     try:
-        if len(latest_tag := get_remote_tags(repo_path)) > 0:
+        if len(latest_tag := get_tags(repo_path)) > 0:
             return latest_tag[0]
         else:
             return ""
@@ -155,10 +123,7 @@ def get_latest_unstable_tag(repo_path: str) -> str:
     :return: tag or empty string
     """
     try:
-        if (
-            len(unstable_tags := [t for t in get_remote_tags(repo_path) if "-" in t])
-            > 0
-        ):
+        if len(unstable_tags := [t for t in get_tags(repo_path) if "-" in t]) > 0:
             return unstable_tags[0]
         else:
             return ""
@@ -167,34 +132,6 @@ def get_latest_unstable_tag(repo_path: str) -> str:
         raise
 
 
-def compare_semver_tags(tag1: str, tag2: str) -> bool:
-    """
-    Compare two semver version strings.
-    Does not support comparing pre-release versions (e.g. 1.0.0-rc.1, 1.0.0-beta.1)
-    :param tag1: First version string
-    :param tag2: Second version string
-    :return: True if tag1 is greater than tag2, False otherwise
-    """
-    if tag1 == tag2:
-        return False
-
-    def parse_version(v):
-        return list(map(int, v[1:].split(".")))
-
-    tag1_parts = parse_version(tag1)
-    tag2_parts = parse_version(tag2)
-
-    max_len = max(len(tag1_parts), len(tag2_parts))
-    tag1_parts += [0] * (max_len - len(tag1_parts))
-    tag2_parts += [0] * (max_len - len(tag2_parts))
-
-    for part1, part2 in zip(tag1_parts, tag2_parts):
-        if part1 != part2:
-            return part1 > part2
-
-    return False
-
-
 def get_local_commit(repo: Path) -> str | None:
     if not repo.exists() or not repo.joinpath(".git").exists():
         return None
@@ -259,15 +196,15 @@ def git_cmd_pull(target_dir: Path) -> None:
         raise
 
 
-def rollback_repository(repo_dir: Path, instance: Type[InstanceType]) -> None:
+def rollback_repository(repo_dir: Path, instance: Type[BaseInstance]) -> None:
     q1 = "How many commits do you want to roll back"
     amount = get_number_input(q1, 1, allow_go_back=True)
 
-    instances = get_instances(instance)
+    im = InstanceManager(instance)
 
     Logger.print_warn("Do not continue if you have ongoing prints!", start="\n")
     Logger.print_warn(
-        f"All currently running {instance.__name__} services will be stopped!"
+        f"All currently running {im.instance_type.__name__} services will be stopped!"
     )
     if not get_confirm(
         f"Roll back {amount} commit{'s' if amount > 1 else ''}",
@@ -277,7 +214,7 @@ def rollback_repository(repo_dir: Path, instance: Type[InstanceType]) -> None:
         Logger.print_info("Aborting roll back ...")
         return
 
-    InstanceManager.stop_all(instances)
+    im.stop_all_instance()
 
     try:
         cmd = ["git", "reset", "--hard", f"HEAD~{amount}"]
@@ -286,4 +223,4 @@ def rollback_repository(repo_dir: Path, instance: Type[InstanceType]) -> None:
     except CalledProcessError as e:
         Logger.print_error(f"An error occured during repo rollback:\n{e}")
 
-    InstanceManager.start_all(instances)
+    im.start_all_instance()

kiauh/utils/instance_utils.py

@@ -1,56 +0,0 @@
-# ======================================================================= #
-#  Copyright (C) 2020 - 2024 Dominik Willner <th33xitus@gmail.com>        #
-#                                                                         #
-#  This file is part of KIAUH - Klipper Installation And Update Helper    #
-#  https://github.com/dw-0/kiauh                                          #
-#                                                                         #
-#  This file may be distributed under the terms of the GNU GPLv3 license  #
-# ======================================================================= #
-from __future__ import annotations
-
-import re
-from pathlib import Path
-from typing import List
-
-from core.constants import SYSTEMD
-from core.instance_manager.base_instance import SUFFIX_BLACKLIST
-from core.instance_type import InstanceType
-
-
-def get_instances(instance_type: type) -> List[InstanceType]:
-    from utils.common import convert_camelcase_to_kebabcase
-
-    if not isinstance(instance_type, type):
-        raise ValueError("instance_type must be a class")
-
-    name = convert_camelcase_to_kebabcase(instance_type.__name__)
-    pattern = re.compile(f"^{name}(-[0-9a-zA-Z]+)?.service$")
-
-    service_list = [
-        Path(SYSTEMD, service)
-        for service in SYSTEMD.iterdir()
-        if pattern.search(service.name)
-        and not any(s in service.name for s in SUFFIX_BLACKLIST)
-    ]
-
-    instance_list = [
-        instance_type(get_instance_suffix(name, service)) for service in service_list
-    ]
-
-    def _sort_instance_list(suffix: int | str | None):
-        if suffix is None:
-            return
-        elif isinstance(suffix, str) and suffix.isdigit():
-            return f"{int(suffix):04}"
-        else:
-            return suffix
-
-    return sorted(instance_list, key=lambda x: _sort_instance_list(x.suffix))
-
-
-def get_instance_suffix(name: str, file_path: Path) -> str:
-    # to get the suffix of the instance, we remove the name of the instance from
-    # the file name, if the remaining part an empty string we return it
-    # otherwise there is and hyphen left, and we return the part after the hyphen
-    suffix = file_path.stem[len(name) :]
-    return suffix[1:] if suffix else ""

kiauh/utils/sys_utils.py

@@ -511,18 +511,3 @@ def remove_system_service(service_name: str) -> None:
     except Exception as e:
         Logger.print_error(f"Error removing {service_name}: {e}")
         raise
-
-
-def get_service_file_path(instance_type: type, suffix: str) -> Path:
-    from utils.common import convert_camelcase_to_kebabcase
-
-    if not isinstance(instance_type, type):
-        raise ValueError("instance_type must be a class")
-
-    name: str = convert_camelcase_to_kebabcase(instance_type.__name__)
-    if suffix != "":
-        name += f"-{suffix}"
-
-    file_path: Path = SYSTEMD.joinpath(f"{name}.service")
-
-    return file_path

scripts/ui/main_menu.sh

@@ -40,7 +40,7 @@ function main_ui() {
 function get_kiauh_version() {
   local version
   cd "${KIAUH_SRCDIR}"
-  version="$(git tag -l 'v5*' | tail -1)"
+  version="$(git describe HEAD --always --tags | cut -d "-" -f 1,2)"
   echo "${version}"
 }