Bump version: 1.1.2b0 → 1.1.3b0

fix filters positive float

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.0.10b16
+current_version = 1.1.3b0
 parse = (?P<major>\d+)(\.(?P<minor>\d+))(\.(?P<patch>\d+))(?P<release>[bf]*)(?P<build>\d*)
 commit = True
 tag = True

custom_components/mega/__init__.py

@@ -1,6 +1,7 @@
 """The mega integration."""
 import asyncio
 import logging
+import typing
 from functools import partial
 
 import voluptuous as vol
@@ -17,7 +18,8 @@ from .const import DOMAIN, CONF_INVERT, CONF_RELOAD, PLATFORMS, CONF_PORTS, CONF
     CONF_MQTT_INPUTS, CONF_HTTP, CONF_RESPONSE_TEMPLATE, CONF_ACTION, CONF_GET_VALUE, CONF_ALLOW_HOSTS, \
     CONF_CONV_TEMPLATE, CONF_ALL, CONF_FORCE_D, CONF_DEF_RESPONSE, CONF_FORCE_I2C_SCAN, CONF_HEX_TO_FLOAT, \
     RGB_COMBINATIONS, CONF_WS28XX, CONF_ORDER, CONF_SMOOTH, CONF_LED, CONF_WHITE_SEP, CONF_CHIP, CONF_RANGE, \
-    CONF_FILTER_VALUES, CONF_FILTER_SCALE, CONF_FILTER_LOW, CONF_FILTER_HIGH
+    CONF_FILTER_VALUES, CONF_FILTER_SCALE, CONF_FILTER_LOW, CONF_FILTER_HIGH, CONF_FILL_NA, CONF_MEGA_ID, CONF_ADDR, \
+    CONF_1WBUS
 from .hub import MegaD
 from .config_flow import ConfigFlow
 from .http import MegaView
@@ -52,6 +54,10 @@ LED_LIGHT = \
 
 CUSTOMIZE_PORT = {
     vol.Optional(CONF_SKIP, description='исключить порт из сканирования', default=False): bool,
+    vol.Optional(CONF_FILL_NA, default='last'): vol.Any(
+      'last',
+      'none'
+    ),
     vol.Optional(CONF_RANGE, description='диапазон диммирования'): [
         vol.Range(0, 255),
         vol.Range(0, 255),
@@ -79,10 +85,10 @@ CUSTOMIZE_PORT = {
     vol.Optional(CONF_VALUE_TEMPLATE): cv.template,
     vol.Optional(CONF_FORCE_I2C_SCAN): bool,
     vol.Optional(CONF_HEX_TO_FLOAT): bool,
-    vol.Optional(CONF_FILTER_VALUES): [cv.positive_float],
+    vol.Optional(CONF_FILTER_VALUES): [vol.Coerce(float)],
-    vol.Optional(CONF_FILTER_SCALE): cv.positive_float,
+    vol.Optional(CONF_FILTER_SCALE): vol.Coerce(float),
-    vol.Optional(CONF_FILTER_LOW): cv.positive_float,
+    vol.Optional(CONF_FILTER_LOW): vol.Coerce(float),
-    vol.Optional(CONF_FILTER_HIGH): cv.positive_float,
+    vol.Optional(CONF_FILTER_HIGH): vol.Coerce(float),
     vol.Optional(CONF_SMOOTH): cv.time_period_seconds,
     # vol.Optional(CONF_RANGE): vol.ExactSequence([int, int]), TODO: сделать отбрасывание "плохих" значений
     vol.Optional(str): {
@@ -103,6 +109,11 @@ def extender(x):
     else:
         raise ValueError('must has "e" in port name')
 
+OWBUS = vol.Schema({
+    vol.Required(CONF_PORT): vol.Any(vol.Coerce(int), vol.Coerce(str)),
+    vol.Required(CONF_MEGA_ID): vol.Coerce(str),
+    vol.Required(CONF_ADDR): [str],
+})
 
 CONFIG_SCHEMA = vol.Schema(
     {
@@ -129,7 +140,8 @@ CONFIG_SCHEMA = vol.Schema(
                 vol.Optional(CONF_FILTER_SCALE): cv.positive_float,
                 vol.Optional(CONF_FILTER_LOW): cv.positive_float,
                 vol.Optional(CONF_FILTER_HIGH): cv.positive_float,
-            }
+            },
+            vol.Optional(CONF_1WBUS): [OWBUS]
         }
     },
     extra=vol.ALLOW_EXTRA,

custom_components/mega/config_flow.py

@@ -63,7 +63,7 @@ async def validate_input(hass: core.HomeAssistant, data):
 class ConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
     """Handle a config flow for mega."""
 
-    VERSION = 25
+    VERSION = 26
     CONNECTION_CLASS = config_entries.CONN_CLASS_ASSUMED
 
     async def async_step_user(self, user_input=None):

custom_components/mega/const.py

@@ -45,10 +45,13 @@ CONF_SMOOTH = 'smooth'
 CONF_WHITE_SEP = 'white_sep'
 CONF_CHIP = 'chip'
 CONF_RANGE = 'range'
+CONF_FILL_NA = 'fill_na'
 CONF_FILTER_VALUES = 'filter_values'
 CONF_FILTER_SCALE = 'filter_scale'
 CONF_FILTER_LOW = 'filter_low'
 CONF_FILTER_HIGH = 'filter_high'
+CONF_1WBUS = '1wbus'
+CONF_ADDR = 'addr'
 PLATFORMS = [
     "light",
     "switch",

custom_components/mega/entities.py

@@ -86,7 +86,6 @@ class BaseMegaEntity(CoordinatorEntity, RestoreEntity):
             self.mega.ds2413_ports |= {self.port}
         super().__init__(coordinator=mega.updater)
 
-
     @property
     def is_ws(self):
         return False
@@ -130,11 +129,7 @@ class BaseMegaEntity(CoordinatorEntity, RestoreEntity):
         if self.hass is None or self.entity_id is None:
             return {}
         if self._customize is None:
-
             c_entity_id = self.hass.data.get(DOMAIN, {}).get(CONF_CUSTOM).get('entities', {}).get(self.entity_id, {})
-            self.lg.debug(
-                'customize %s with %s', self.entity_id, c_entity_id
-            )
             c = self.hass.data.get(DOMAIN, {}).get(CONF_CUSTOM) or {}
             c = c.get(self._mega_id) or {}
             c = c.get(self.port) or {}
@@ -166,15 +161,12 @@ class BaseMegaEntity(CoordinatorEntity, RestoreEntity):
             ],
             "name": f'{self._mega_id} port {pt_idx}' if not isinstance(self.port, list) else f'{self._mega_id} {pt_idx}',
             "manufacturer": 'ab-log.ru',
-            # "model": self.light.productname,
             "sw_version": self.mega.fw,
             "via_device": (DOMAIN, self._mega_id),
         }
 
     @property
     def lg(self) -> logging.Logger:
-        # if self._lg is None:
-        #     self._lg = self.mega.lg.getChild(self._name or self.unique_id)
         return _LOGGER
 
     @property
@@ -431,6 +423,8 @@ class MegaOutPort(MegaPushEntity):
         ))
 
     def _calc_brightness(self, brightness):
+        if brightness is None:
+            brightness = 0
         pct = brightness / 255
         pct = max((0, pct))
         pct = min((pct, 1))
@@ -440,6 +434,8 @@ class MegaOutPort(MegaPushEntity):
         return brightness
 
     def _cal_reverse_brightness(self, brightness):
+        if brightness is None:
+            brightness = 0
         l, h = self.range
         d = h - l
         pct = (brightness - l) / d

custom_components/mega/http.py

@@ -134,7 +134,8 @@ class MegaView(HomeAssistantView):
                         if ret == 'd' and act:
                             await hub.request(cmd=act.replace(':3', f':{v}'))
                         ret = 'd' if hub.force_d else ''
-            elif port in hub.binary_sensors:
+            else:
+            # elif port in hub.binary_sensors:
                 hub.values[port] = data
                 for cb in self.callbacks[hub.id][port]:
                     cb(data)

custom_components/mega/hub.py

@@ -427,7 +427,7 @@ class MegaD:
     def subscribe(self, port, callback):
         port = int_ignore(port)
         self.lg.debug(
-            f'subscribe %s %s', port, str(callback)
+            f'subscribe %s', port,
         )
         self.http.callbacks[self.id][port].append(callback)
 

custom_components/mega/i2c.py

@@ -1,4 +1,5 @@
-from dataclasses import dataclass, field
+import typing
+from dataclasses import dataclass, field, astuple
 from urllib.parse import parse_qsl, urlparse
 from bs4 import BeautifulSoup
 from homeassistant.const import (
@@ -15,7 +16,15 @@ from homeassistant.const import (
 )
 from collections import namedtuple
 
-DeviceType = namedtuple('DeviceType', 'device_class,unit_of_measurement,suffix')
+# DeviceType = namedtuple('DeviceType', 'device_class,unit_of_measurement,suffix')
+
+@dataclass
+class DeviceType:
+
+    device_class: typing.Optional[str] = None
+    unit_of_measurement: typing.Optional[str] = None
+    suffix: typing.Optional[str] = None
+    delay: typing.Optional[float] = None
 
 
 def parse_scan_page(page: str):
@@ -32,39 +41,40 @@ def parse_scan_page(page: str):
             continue
         classes = i2c_classes.get(dev, [])
         for i, c in enumerate(classes):
+            _params = params.copy()
             if c is Skip:
                 continue
             elif c is Request:
-                req.append(params)
+                req.append(_params)
                 continue
             elif isinstance(c, Request):
                 if c.delay:
-                    params = params.copy()
+                    _params['delay'] = c.delay
-                    params['delay'] = c.delay
+                req.append(_params)
-                req.append(params)
                 continue
             elif isinstance(c, DeviceType):
-                c, m, suffix = c
+                c, m, suffix, delay = astuple(c)
+                if delay is not None:
+                    _params['delay'] = delay
             else:
                 continue
             suffix = suffix or c
-            if 'addr' in params:
+            if 'addr' in _params:
-                suffix += f"_{params['addr']}" if suffix else str(params['addr'])
+                suffix += f"_{_params['addr']}" if suffix else str(_params['addr'])
             if suffix:
                 _dev = f'{dev}_{suffix}'
             else:
                 _dev = dev
-            params = params.copy()
             if i > 0:
-                params['i2c_par'] = i
+                _params['i2c_par'] = i
 
             ret.append({
                 'id_suffix': _dev,
                 'device_class': c,
-                'params': params,
+                'params': _params,
                 'unit_of_measurement': m,
             })
-            req.append(params)
+            req.append(_params)
     return req, ret
 
 
@@ -83,7 +93,7 @@ i2c_classes = {
         DeviceType(DEVICE_CLASS_TEMPERATURE, TEMP_CELSIUS, None),
     ],
     'sht31': [
-        DeviceType(DEVICE_CLASS_HUMIDITY, PERCENTAGE, None),
+        DeviceType(DEVICE_CLASS_HUMIDITY, PERCENTAGE, None, delay=1.5),
         DeviceType(DEVICE_CLASS_TEMPERATURE, TEMP_CELSIUS, None),
     ],
     'max44009': [
@@ -115,7 +125,7 @@ i2c_classes = {
     ],
     'ptsensor': [
         Skip,
-        Request(delay=1),  # запрос на измерение
+        Request(delay=3),  # запрос на измерение
         DeviceType(DEVICE_CLASS_PRESSURE, PRESSURE_BAR, None),
         DeviceType(DEVICE_CLASS_TEMPERATURE, TEMP_CELSIUS, None),
     ],

custom_components/mega/manifest.json

@@ -15,5 +15,5 @@
     "@andvikt"
   ],
   "issue_tracker": "https://github.com/andvikt/mega_hacs/issues",
-  "version": "v1.0.10b16"
+  "version": "v1.1.3b0"
 }

custom_components/mega/sensor.py

@@ -6,7 +6,7 @@ import struct
 from homeassistant.components.sensor import (
     PLATFORM_SCHEMA as SENSOR_SCHEMA,
     DEVICE_CLASS_TEMPERATURE,
-    DEVICE_CLASS_HUMIDITY
+    DEVICE_CLASS_HUMIDITY, SensorEntity
 )
 from homeassistant.config_entries import ConfigEntry
 from homeassistant.const import (
@@ -21,7 +21,7 @@ from homeassistant.core import HomeAssistant
 from homeassistant.helpers.template import Template
 from .entities import MegaPushEntity
 from .const import CONF_KEY, TEMP, HUM, W1, W1BUS, CONF_CONV_TEMPLATE, CONF_HEX_TO_FLOAT, DOMAIN, CONF_CUSTOM, \
-    CONF_SKIP, CONF_FILTER_VALUES, CONF_FILTER_SCALE, CONF_FILTER_LOW, CONF_FILTER_HIGH
+    CONF_SKIP, CONF_FILTER_VALUES, CONF_FILTER_SCALE, CONF_FILTER_LOW, CONF_FILTER_HIGH, CONF_FILL_NA
 from .hub import MegaD
 import re
 
@@ -108,32 +108,34 @@ async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry, asyn
     async_add_devices(devices)
 
 
-class FilterBadValues(MegaPushEntity):
+class FilterBadValues(MegaPushEntity, SensorEntity):
 
     def __init__(self, *args, **kwargs):
         self._prev_value = None
         super().__init__(*args, **kwargs)
 
     def filter_value(self, value):
-        self.lg.debug(
+        try:
-            'value=%s filter_low=%s filter_high=%s filter_scale=%s prev_value=%s filter_values=%s',
+            if value \
-            value, self.filter_low, self.filter_high, self.filter_scale, self._prev_value, self.filter_values
+                    in self.filter_values \
-        )
+               or (self.filter_low is not None and value < self.filter_low) \
-        self.lg.debug(f'{self.customize} {self.entity_id}')
+               or (self.filter_high is not None and value > self.filter_high) \
-        if value \
+               or (
-                in self.filter_values \
+                    self._prev_value is not None
-           or (self.filter_low is not None and value < self.filter_low) \
+                    and self.filter_scale is not None
-           or (self.filter_high is not None and value > self.filter_high) \
+                    and (
-           or (
+                        abs(value - self._prev_value) / self._prev_value > self.filter_scale
-                self._prev_value is not None
+                    )
-                and self.filter_scale is not None
+                ):
-                and (
+                if self.fill_na == 'last':
-                    abs(value - self._prev_value) / self._prev_value > self.filter_scale
+                    value = self._prev_value
-                )
+                else:
-            ):
+                    value = None
-            value = self._prev_value
+            self._prev_value = value
-        self._prev_value = value
+            return value
-        return value
+        except Exception as exc:
+            lg.exception(f'while parsing value')
+            return None
 
     @property
     def filter_values(self):
@@ -151,6 +153,10 @@ class FilterBadValues(MegaPushEntity):
     def filter_high(self):
         return self.customize.get(CONF_FILTER_HIGH, self.mega.customize.get(CONF_FILTER_HIGH, None))
 
+    @property
+    def fill_na(self):
+        return self.customize.get(CONF_FILL_NA, 'last')
+
 
 class MegaI2C(FilterBadValues):
 
@@ -169,7 +175,12 @@ class MegaI2C(FilterBadValues):
 
     @property
     def customize(self):
-        return super().customize.get(self.id_suffix, {}) or {}
+        ret = super().customize
+        _old = ret.get(self.id_suffix)
+        if _old is not None:
+            ret = ret.copy()
+            ret.update(_old)
+        return ret
 
     @property
     def extra_state_attributes(self):
@@ -184,28 +195,32 @@ class MegaI2C(FilterBadValues):
         return self._device_class
 
     @property
-    def unit_of_measurement(self):
+    def native_unit_of_measurement(self):
         return self._unit_of_measurement
 
     @property
-    def state(self):
+    def native_value(self):
-        # self.lg.debug(f'get % all states: %', self._params, self.mega.values)
-        ret = self.mega.values.get(self._params)
-        if self.customize.get(CONF_HEX_TO_FLOAT):
-            try:
-                ret = struct.unpack('!f', bytes.fromhex(ret))[0]
-            except:
-                self.lg.warning(f'could not convert {ret} form hex to float')
-        tmpl: Template = self.customize.get(CONF_CONV_TEMPLATE, self.customize.get(CONF_VALUE_TEMPLATE))
         try:
-            ret = float(ret)
+            ret = self.mega.values.get(self._params)
-            if tmpl is not None and self.hass is not None:
+            if self.customize.get(CONF_HEX_TO_FLOAT):
-                tmpl.hass = self.hass
+                try:
-                ret = tmpl.async_render({'value': ret})
+                    ret = struct.unpack('!f', bytes.fromhex(ret))[0]
-        except:
+                except:
-            ret = ret
+                    self.lg.warning(f'could not convert {ret} form hex to float')
-        ret = self.filter_value(ret)
+            tmpl: Template = self.customize.get(CONF_CONV_TEMPLATE, self.customize.get(CONF_VALUE_TEMPLATE))
-        return str(ret)
+            try:
+                ret = float(ret)
+                if tmpl is not None and self.hass is not None:
+                    tmpl.hass = self.hass
+                    ret = tmpl.async_render({'value': ret})
+            except:
+                ret = ret
+            ret = self.filter_value(ret)
+            if ret is not None:
+                return str(ret)
+        except Exception:
+            lg.exception('while getting value')
+            return None
 
     @property
     def device_class(self):
@@ -230,7 +245,6 @@ class Mega1WSensor(FilterBadValues):
         """
         super().__init__(*args, **kwargs)
         self.key = key
-        lg.debug(f'my key: {key}')
         self._value = None
         self._device_class = device_class
         self._unit_of_measurement = unit_of_measurement
@@ -238,7 +252,7 @@ class Mega1WSensor(FilterBadValues):
         self.prev_value = None
 
     @property
-    def unit_of_measurement(self):
+    def native_unit_of_measurement(self):
         _u = self.customize.get(CONF_UNIT_OF_MEASUREMENT, None)
         if _u is None:
             return self._unit_of_measurement
@@ -269,46 +283,53 @@ class Mega1WSensor(FilterBadValues):
             return self._device_class
 
     @property
-    def state(self):
+    def native_value(self):
-        ret = None
+        try:
-        if not hasattr(self, 'key'):
+            ret = None
-            return None
+            if not hasattr(self, 'key'):
-        if self.key:
+                return None
-            try:
+            if self.key:
-                ret = self.mega.values.get(self.port, {})
+                try:
-                if isinstance(ret, dict):
+                    ret = self.mega.values.get(self.port, {})
-                    ret = ret.get('value', {})
                     if isinstance(ret, dict):
-                        ret = ret.get(self.key)
+                        ret = ret.get('value', {})
-            except:
+                        if isinstance(ret, dict):
-                self.lg.error(self.mega.values.get(self.port, {}).get('value', {}))
+                            ret = ret.get(self.key)
-                return
+                except:
-        else:
+                    self.lg.error(self.mega.values.get(self.port, {}).get('value', {}))
-            ret = self.mega.values.get(self.port, {}).get('value')
+                    return
-        if ret is None and self._state is not None:
+            else:
-            ret = self._state.state
+                ret = self.mega.values.get(self.port, {}).get('value')
-        try:
+            if ret is None and self.fill_na == 'fill_na' and self.prev_value is not None:
-            ret = float(ret)
+                ret = self.prev_value
-            ret = str(ret)
+            elif ret is None and self.fill_na == 'fill_na' and self._state is not None:
-        except:
+                ret = self._state.state
-            self.lg.warning(f'could not convert to float "{ret}"')
-            ret = self.prev_value
-        if self.customize.get(CONF_HEX_TO_FLOAT):
             try:
-                ret = struct.unpack('!f', bytes.fromhex(ret))[0]
+                ret = float(ret)
+                ret = str(ret)
             except:
-                self.lg.warning(f'could not convert {ret} form hex to float')
+                self.lg.debug(f'could not convert to float "{ret}"')
-        tmpl: Template = self.customize.get(CONF_CONV_TEMPLATE, self.customize.get(CONF_VALUE_TEMPLATE))
+                ret = self.prev_value
-        try:
+            if self.customize.get(CONF_HEX_TO_FLOAT):
-            ret = float(ret)
+                try:
-            if tmpl is not None and self.hass is not None:
+                    ret = struct.unpack('!f', bytes.fromhex(ret))[0]
-                tmpl.hass = self.hass
+                except:
-                ret = tmpl.async_render({'value': ret})
+                    self.lg.warning(f'could not convert {ret} form hex to float')
-        except:
+            tmpl: Template = self.customize.get(CONF_CONV_TEMPLATE, self.customize.get(CONF_VALUE_TEMPLATE))
-            pass
+            try:
-        ret = self.filter_value(ret)
+                ret = float(ret)
-        self.prev_value = ret
+                if tmpl is not None and self.hass is not None:
-        return str(ret)
+                    tmpl.hass = self.hass
+                    ret = tmpl.async_render({'value': ret})
+            except:
+                pass
+            ret = self.filter_value(ret)
+            self.prev_value = ret
+            if ret is not None:
+                return str(ret)
+        except Exception:
+            lg.exception('while parsing state')
+            return None
 
     @property
     def name(self):
@@ -317,8 +338,8 @@ class Mega1WSensor(FilterBadValues):
         if isinstance(c, dict):
             try:
                 c = c.get(self.key)
-            except AttributeError:
+            except:
-                lg.debug(dir(self))
+                pass
         return c or n
 
 

custom_components/mega/tools.py

@@ -50,6 +50,10 @@ class PriorityLock(asyncio.Lock):
         finally:
             self.release()
 
+    @property
+    def _loop(self):
+        return asyncio.get_event_loop()
+
     async def acquire(self, priority=0) -> bool:
         """Acquire a lock.
 

docs/yaml.md

@@ -1,6 +1,25 @@
 С помощью yaml-конфигурации можно кастомизировать ваши устройства.
 
 ## Основное
+
+!!! note "Альтернативная адресация" 
+    Начиная с v1.1.0 большинство параметров объектов можно записывать в более простой и понятной форме:
+    ```yaml
+    mega: # название интеграции
+      entities:
+        sensor.some_sensor: #entity_id как в интерфейсе HA
+          filter_low: 20
+          filter_high: 40
+    ```
+    Рекомендуется пользоваться именно этим способом, тк он более логичный и простой.
+    
+    Некоторые параметры по своей логике (влияют на entity_id) не могут быть записаны таким образом, среди них:
+    - domain
+    - skip
+    - name
+    
+    Остальные параметры можно записывать используя новый entities
+
 Конфиг записывается стандартным образом в файл `configuration.yaml`, начинаем с 
 указания названия интеграции:
 ```yaml hl_lines="1"
@@ -62,8 +81,11 @@ mega:
 !!! note ""
     - **smooth** (float, 0): программное плавное диммирование. Это поле отвечает за кол-во секунд, за которое яркость
     диммера набирает от 0 до 100%
-    - **limits** (list[int, int], [0, 255]), *начиная с версии 1.1.0*: границы диммирования в абсолютных единицах контроллера. При диммировании 1%
+    - **range** (list[int, int], [0, 255]), *начиная с версии 1.1.0*: границы диммирования в абсолютных единицах 0..255. При диммировании 1%
     будет равен левой границе, 100% - правой.
+    ```yaml
+    range: [20, 200]
+    ```
 [Подробнее про плавное диммирование](smooth.md)
 ### MegaD-16R-XT, MegaD-16PWM
 Порты расширителей MegaD-16R-XT, MegaD-16PWM конфигурируются аналогично обычным реле и диммерам, но адресация порта 
@@ -165,6 +187,8 @@ some_led2:
     - **filter_scale** (float, none): значение отклонения от текущего значения, которое будет считаться выбросом и отфильтруется, например если
     установить 1, то это означает, что при росте показателя сенсора на 100% и больше или падении на 100% и больше, такое значение не будет отображаться.
     [Доступно так же глобальное значение](#filter_scale)
+    - **fill_na** (str, last): чем заполнять пропуски, по-умолчанию last, что означает последнее значение, можно так же поставить none-тогда будут пропуски (разрывы на графике).
+
 При этом есть так же особенности адресации, так для сенсора на одном порте с одним значением:
 ```yaml
 36:

mkdocs.yml

@@ -22,7 +22,7 @@ nav:
   - Конфигурация:
     - В интерфейсе: settings.md
     - Настройка обратной связи: http.md
-    - YAML-конфиг: yaml.md
+    - Кастомизация: yaml.md
     - i2c: i2c.md
     - Плавные переходы: smooth.md
   - Автоматизация: