From 6f59fd06aad4ea78104cb71dccb82ea7a2b1878d Mon Sep 17 00:00:00 2001
From: dw-0 <th33xitus@gmail.com>
Date: Fri, 2 May 2025 20:08:32 +0200
Subject: [PATCH] fix: do not upgrade pip before installing packages (#680)

pip 25 seems to introduce some compatibility issues.

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
---
 kiauh/utils/sys_utils.py | 6 ------
 scripts/klipper.sh       | 1 -
 scripts/moonraker.sh     | 1 -
 3 files changed, 8 deletions(-)

diff --git a/kiauh/utils/sys_utils.py b/kiauh/utils/sys_utils.py
index add3ef2..80d069c 100644
--- a/kiauh/utils/sys_utils.py
+++ b/kiauh/utils/sys_utils.py
@@ -184,9 +184,6 @@ def install_python_requirements(target: Path, requirements: Path) -> None:
     :return: None
     """
     try:
-        # always update pip before installing requirements
-        update_python_pip(target)
-
         Logger.print_status("Installing Python requirements ...")
         command = [
             target.joinpath("bin/pip").as_posix(),
@@ -216,9 +213,6 @@ def install_python_packages(target: Path, packages: List[str]) -> None:
     :return: None
     """
     try:
-        # always update pip before installing requirements
-        update_python_pip(target)
-
         Logger.print_status("Installing Python requirements ...")
         command = [
             target.joinpath("bin/pip").as_posix(),
diff --git a/scripts/klipper.sh b/scripts/klipper.sh
index fb205a1..a7eef70 100644
--- a/scripts/klipper.sh
+++ b/scripts/klipper.sh
@@ -280,7 +280,6 @@ function create_klipper_virtualenv() {
   status_msg "Installing $("python${python_version}" -V) virtual environment..."
 
   if virtualenv -p "python${python_version}" "${KLIPPY_ENV}"; then
-    (( python_version == 3 )) && "${KLIPPY_ENV}"/bin/pip install -U pip
     "${KLIPPY_ENV}"/bin/pip install -r "${KLIPPER_DIR}"/scripts/klippy-requirements.txt
   else
     log_error "failure while creating python3 klippy-env"
diff --git a/scripts/moonraker.sh b/scripts/moonraker.sh
index 9752697..7c4d8bd 100644
--- a/scripts/moonraker.sh
+++ b/scripts/moonraker.sh
@@ -336,7 +336,6 @@ function create_moonraker_virtualenv() {
   [[ -d ${MOONRAKER_ENV} ]] && rm -rf "${MOONRAKER_ENV}"
 
   if virtualenv -p /usr/bin/python3 "${MOONRAKER_ENV}"; then
-    "${MOONRAKER_ENV}"/bin/pip install -U pip
     "${MOONRAKER_ENV}"/bin/pip install -r "${MOONRAKER_DIR}/scripts/moonraker-requirements.txt"
   else
     log_error "failure while creating python3 moonraker-env"