From 33113e72e9a45ac1a4020d409b5932e60e4c77eb Mon Sep 17 00:00:00 2001 From: dw-0 Date: Sat, 31 May 2025 17:44:02 +0200 Subject: [PATCH] fix: exception raised on pip warning (#688) pip seems to write to stderr on warnings, caused by retries. even if the process exits with 0. Signed-off-by: Dominik Willner --- kiauh/utils/sys_utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kiauh/utils/sys_utils.py b/kiauh/utils/sys_utils.py index 80d069c..626342e 100644 --- a/kiauh/utils/sys_utils.py +++ b/kiauh/utils/sys_utils.py @@ -193,7 +193,7 @@ def install_python_requirements(target: Path, requirements: Path) -> None: ] result = run(command, stderr=PIPE, text=True) - if result.returncode != 0 or result.stderr: + if result.returncode != 0: Logger.print_error(f"{result.stderr}", False) raise VenvCreationFailedException("Installing Python requirements failed!") @@ -222,7 +222,7 @@ def install_python_packages(target: Path, packages: List[str]) -> None: command.append(pkg) result = run(command, stderr=PIPE, text=True) - if result.returncode != 0 or result.stderr: + if result.returncode != 0: Logger.print_error(f"{result.stderr}", False) raise VenvCreationFailedException("Installing Python requirements failed!")