fix: changed default value of slave max modulation to 0

src/OpenThermTask.h

@@ -554,6 +554,9 @@ protected:
             Sensors::Type::OT_BURNER_STARTS, vars.slave.stats.burnerStarts,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive burner starts"));
         }
       }
 
@@ -566,6 +569,9 @@ protected:
             Sensors::Type::OT_DHW_BURNER_STARTS, vars.slave.stats.dhwBurnerStarts,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive DHW burner starts"));
         }
       }
 
@@ -578,6 +584,9 @@ protected:
             Sensors::Type::OT_HEATING_PUMP_STARTS, vars.slave.stats.heatingPumpStarts,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive heating pump starts"));
         }
       }
 
@@ -590,6 +599,9 @@ protected:
             Sensors::Type::OT_DHW_PUMP_STARTS, vars.slave.stats.dhwPumpStarts,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive DHW pump starts"));
         }
       }
 
@@ -602,6 +614,9 @@ protected:
             Sensors::Type::OT_BURNER_HOURS, vars.slave.stats.burnerHours,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive burner hours"));
         }
       }
 
@@ -614,6 +629,9 @@ protected:
             Sensors::Type::OT_DHW_BURNER_HOURS, vars.slave.stats.dhwBurnerHours,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive DHW burner hours"));
         }
       }
 
@@ -626,6 +644,9 @@ protected:
             Sensors::Type::OT_HEATING_PUMP_HOURS, vars.slave.stats.heatingPumpHours,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive heating pump hours"));
         }
       }
 
@@ -638,6 +659,9 @@ protected:
             Sensors::Type::OT_DHW_PUMP_HOURS, vars.slave.stats.dhwPumpHours,
             Sensors::ValueType::PRIMARY, true, true
           );
+
+        } else {
+          Log.swarningln(FPSTR(L_OT), F("Failed receive DHW pump hours"));
         }
       }
 
@@ -1418,9 +1442,8 @@ protected:
   }
 
   bool setDayAndMonth(const struct tm *ptm) {
-    const unsigned int request = ((ptm->tm_mon + 1) & 0xFF << 8) 
-      | (ptm->tm_mday & 0xFF);
-    
+    const uint8_t month = (ptm->tm_mon + 1) & 0xFF;
+    const unsigned int request = (month << 8) | (ptm->tm_mday & 0xFF);
     const unsigned long response = this->instance->sendRequest(CustomOpenTherm::buildRequest(
       OpenThermRequestType::WRITE_DATA,
       OpenThermMessageID::Date,

src/Settings.h

@@ -328,7 +328,7 @@ struct Variables {
     struct {
       uint8_t current = 0;
       uint8_t min = 0;
-      uint8_t max = 100;
+      uint8_t max = 0;
     } modulation;
 
     struct {

src_data/pages/dashboard.html

@@ -261,16 +261,16 @@
 
           <details>
             <summary><b data-i18n>dashboard.section.diag</b></summary>
-            <pre><b>Vendor:</b>             <span class="sVendor"></span>
-<b>Member ID:</b>          <span class="sMemberId"></span>
-<b>Flags:</b>              <span class="sFlags"></span>
-<b>Type:</b>               <span class="sType"></span>
-<b>AppVersion:</b>         <span class="sAppVersion"></span>
-<b>OT version:</b>         <span class="sProtocolVersion"></span>
-<b>Modulation limits:</b>  <span class="sModMin"></span>...<span class="sAbsModMax"></span> %, curr. max: <span class="sModMax"></span> %
-<b>Power limits:</b>       <span class="sPowerMin"></span>...<span class="sPowerMax"></span> kW
-<b>Heating limits:</b>     <span class="sHeatMinTemp"></span>...<span class="sHeatMaxTemp"></span> <span class="tempUnit"></span>
-<b>DHW limits:</b>         <span class="sDhwMinTemp"></span>...<span class="sDhwMaxTemp"></span> <span class="tempUnit"></span></pre>
+            <pre><b>Vendor:</b>         <span class="sVendor"></span>
+<b>Member ID:</b>      <span class="sMemberId"></span>
+<b>Flags:</b>          <span class="sFlags"></span>
+<b>Type:</b>           <span class="sType"></span>
+<b>AppVersion:</b>     <span class="sAppVersion"></span>
+<b>OT version:</b>     <span class="sProtocolVersion"></span>
+<b>Modulation:</b>     min: <span class="sModMin"></span> %, curr. max: <span class="sModMax"></span> %
+<b>Power limits:</b>   <span class="sPowerMin"></span>...<span class="sPowerMax"></span> kW
+<b>Heating limits:</b> <span class="sHeatMinTemp"></span>...<span class="sHeatMaxTemp"></span> <span class="tempUnit"></span>
+<b>DHW limits:</b>     <span class="sDhwMinTemp"></span>...<span class="sDhwMaxTemp"></span> <span class="tempUnit"></span></pre>
           </details>
         </div>
       </article>
@@ -508,7 +508,6 @@
             setValue('.tempUnit', temperatureUnit(unitSystem));
             setValue('.pressureUnit', pressureUnit(unitSystem));
             setValue('.volumeUnit', volumeUnit(unitSystem));
-            setValue('.sAbsModMax', result.opentherm.maxModulation);
 
           } catch (error) {
             console.log(error);