mirror of
https://github.com/Laxilef/OTGateway.git
synced 2025-12-10 18:24:27 +05:00
feat: added software overheating protection
This commit is contained in:
@@ -171,10 +171,13 @@ protected:
|
||||
vars.master.heating.enabled = this->isReady()
|
||||
&& (settings.heating.enabled || vars.emergency.state)
|
||||
&& vars.cascadeControl.input
|
||||
&& !vars.master.heating.blocking;
|
||||
&& !vars.master.heating.blocking
|
||||
&& !vars.master.heating.overheat;
|
||||
|
||||
// DHW settings
|
||||
vars.master.dhw.enabled = settings.opentherm.options.dhwSupport && settings.dhw.enabled;
|
||||
vars.master.dhw.enabled = settings.opentherm.options.dhwSupport
|
||||
&& settings.dhw.enabled
|
||||
&& !vars.master.dhw.overheat;
|
||||
vars.master.dhw.targetTemp = settings.dhw.target;
|
||||
|
||||
// CH2 settings
|
||||
@@ -1313,6 +1316,76 @@ protected:
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
// Heating overheat control
|
||||
if (settings.heating.overheatHighTemp > 0 && settings.heating.overheatLowTemp > 0) {
|
||||
float highTemp = max({
|
||||
vars.slave.heating.currentTemp,
|
||||
vars.slave.heating.returnTemp,
|
||||
vars.slave.heatExchangerTemp
|
||||
});
|
||||
|
||||
if (vars.master.heating.overheat) {
|
||||
if ((float) settings.heating.overheatLowTemp - highTemp + 0.0001f >= 0.0f) {
|
||||
vars.master.heating.overheat = false;
|
||||
|
||||
Log.sinfoln(
|
||||
FPSTR(L_OT_HEATING), F("Overheating not detected. Current high temp: %.2f, threshold (low): %hhu"),
|
||||
highTemp, settings.heating.overheatLowTemp
|
||||
);
|
||||
}
|
||||
|
||||
} else if (vars.slave.heating.active) {
|
||||
if (highTemp - (float) settings.heating.overheatHighTemp + 0.0001f >= 0.0f) {
|
||||
vars.master.heating.overheat = true;
|
||||
|
||||
Log.swarningln(
|
||||
FPSTR(L_OT_HEATING), F("Overheating detected! Current high temp: %.2f, threshold (high): %hhu"),
|
||||
highTemp, settings.heating.overheatHighTemp
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
} else if (vars.master.heating.overheat) {
|
||||
vars.master.heating.overheat = false;
|
||||
}
|
||||
|
||||
// DHW overheat control
|
||||
if (settings.dhw.overheatHighTemp > 0 && settings.dhw.overheatLowTemp > 0) {
|
||||
float highTemp = max({
|
||||
vars.slave.heating.currentTemp,
|
||||
vars.slave.heating.returnTemp,
|
||||
vars.slave.heatExchangerTemp,
|
||||
vars.slave.dhw.currentTemp,
|
||||
vars.slave.dhw.currentTemp2,
|
||||
vars.slave.dhw.returnTemp
|
||||
});
|
||||
|
||||
if (vars.master.dhw.overheat) {
|
||||
if ((float) settings.dhw.overheatLowTemp - highTemp + 0.0001f >= 0.0f) {
|
||||
vars.master.dhw.overheat = false;
|
||||
|
||||
Log.sinfoln(
|
||||
FPSTR(L_OT_DHW), F("Overheating not detected. Current high temp: %.2f, threshold (low): %hhu"),
|
||||
highTemp, settings.dhw.overheatLowTemp
|
||||
);
|
||||
}
|
||||
|
||||
} else if (vars.slave.dhw.active) {
|
||||
if (highTemp - (float) settings.dhw.overheatHighTemp + 0.0001f >= 0.0f) {
|
||||
vars.master.dhw.overheat = true;
|
||||
|
||||
Log.swarningln(
|
||||
FPSTR(L_OT_DHW), F("Overheating detected! Current high temp: %.2f, threshold (high): %hhu"),
|
||||
highTemp, settings.dhw.overheatHighTemp
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
} else if (vars.master.dhw.overheat) {
|
||||
vars.master.dhw.overheat = false;
|
||||
}
|
||||
}
|
||||
|
||||
void initialize() {
|
||||
|
||||
@@ -108,6 +108,8 @@ struct Settings {
|
||||
byte minTemp = DEFAULT_HEATING_MIN_TEMP;
|
||||
byte maxTemp = DEFAULT_HEATING_MAX_TEMP;
|
||||
uint8_t maxModulation = 100;
|
||||
uint8_t overheatHighTemp = 95;
|
||||
uint8_t overheatLowTemp = 90;
|
||||
} heating;
|
||||
|
||||
struct {
|
||||
@@ -116,6 +118,8 @@ struct Settings {
|
||||
byte minTemp = DEFAULT_DHW_MIN_TEMP;
|
||||
byte maxTemp = DEFAULT_DHW_MAX_TEMP;
|
||||
uint8_t maxModulation = 100;
|
||||
uint8_t overheatHighTemp = 95;
|
||||
uint8_t overheatLowTemp = 90;
|
||||
} dhw;
|
||||
|
||||
struct {
|
||||
@@ -280,6 +284,7 @@ struct Variables {
|
||||
bool blocking = false;
|
||||
bool enabled = false;
|
||||
bool indoorTempControl = false;
|
||||
bool overheat = false;
|
||||
float setpointTemp = 0.0f;
|
||||
float targetTemp = 0.0f;
|
||||
float currentTemp = 0.0f;
|
||||
@@ -292,6 +297,7 @@ struct Variables {
|
||||
|
||||
struct {
|
||||
bool enabled = false;
|
||||
bool overheat = false;
|
||||
float targetTemp = 0.0f;
|
||||
float currentTemp = 0.0f;
|
||||
float returnTemp = 0.0f;
|
||||
|
||||
@@ -150,6 +150,9 @@ const char S_OPTIONS[] PROGMEM = "options";
|
||||
const char S_OUTDOOR_TEMP[] PROGMEM = "outdoorTemp";
|
||||
const char S_OUT_GPIO[] PROGMEM = "outGpio";
|
||||
const char S_OUTPUT[] PROGMEM = "output";
|
||||
const char S_OVERHEAT[] PROGMEM = "overheat";
|
||||
const char S_OVERHEAT_HIGH_TEMP[] PROGMEM = "overheatHighTemp";
|
||||
const char S_OVERHEAT_LOW_TEMP[] PROGMEM = "overheatLowTemp";
|
||||
const char S_PASSWORD[] PROGMEM = "password";
|
||||
const char S_PID[] PROGMEM = "pid";
|
||||
const char S_PORT[] PROGMEM = "port";
|
||||
|
||||
52
src/utils.h
52
src/utils.h
@@ -495,6 +495,8 @@ void settingsToJson(const Settings& src, JsonVariant dst, bool safe = false) {
|
||||
heating[FPSTR(S_MIN_TEMP)] = src.heating.minTemp;
|
||||
heating[FPSTR(S_MAX_TEMP)] = src.heating.maxTemp;
|
||||
heating[FPSTR(S_MAX_MODULATION)] = src.heating.maxModulation;
|
||||
heating[FPSTR(S_OVERHEAT_HIGH_TEMP)] = src.heating.overheatHighTemp;
|
||||
heating[FPSTR(S_OVERHEAT_LOW_TEMP)] = src.heating.overheatLowTemp;
|
||||
|
||||
auto dhw = dst[FPSTR(S_DHW)].to<JsonObject>();
|
||||
dhw[FPSTR(S_ENABLED)] = src.dhw.enabled;
|
||||
@@ -502,6 +504,8 @@ void settingsToJson(const Settings& src, JsonVariant dst, bool safe = false) {
|
||||
dhw[FPSTR(S_MIN_TEMP)] = src.dhw.minTemp;
|
||||
dhw[FPSTR(S_MAX_TEMP)] = src.dhw.maxTemp;
|
||||
dhw[FPSTR(S_MAX_MODULATION)] = src.dhw.maxModulation;
|
||||
dhw[FPSTR(S_OVERHEAT_HIGH_TEMP)] = src.dhw.overheatHighTemp;
|
||||
dhw[FPSTR(S_OVERHEAT_LOW_TEMP)] = src.dhw.overheatLowTemp;
|
||||
|
||||
auto equitherm = dst[FPSTR(S_EQUITHERM)].to<JsonObject>();
|
||||
equitherm[FPSTR(S_ENABLED)] = src.equitherm.enabled;
|
||||
@@ -1342,6 +1346,29 @@ bool jsonToSettings(const JsonVariantConst src, Settings& dst, bool safe = false
|
||||
}
|
||||
}
|
||||
|
||||
if (!src[FPSTR(S_HEATING)][FPSTR(S_OVERHEAT_HIGH_TEMP)].isNull()) {
|
||||
unsigned char value = src[FPSTR(S_HEATING)][FPSTR(S_OVERHEAT_HIGH_TEMP)].as<unsigned char>();
|
||||
|
||||
if (isValidTemp(value, dst.system.unitSystem, 0.0f, 100.0f) && value != dst.heating.overheatHighTemp) {
|
||||
dst.heating.overheatHighTemp = value;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (!src[FPSTR(S_HEATING)][FPSTR(S_OVERHEAT_LOW_TEMP)].isNull()) {
|
||||
unsigned char value = src[FPSTR(S_HEATING)][FPSTR(S_OVERHEAT_LOW_TEMP)].as<unsigned char>();
|
||||
|
||||
if (isValidTemp(value, dst.system.unitSystem, 0.0f, 99.0f) && value != dst.heating.overheatLowTemp) {
|
||||
dst.heating.overheatLowTemp = value;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (dst.heating.overheatHighTemp < dst.heating.overheatLowTemp) {
|
||||
dst.heating.overheatHighTemp = dst.heating.overheatLowTemp;
|
||||
changed = true;
|
||||
}
|
||||
|
||||
|
||||
// dhw
|
||||
if (src[FPSTR(S_DHW)][FPSTR(S_ENABLED)].is<bool>()) {
|
||||
@@ -1385,6 +1412,29 @@ bool jsonToSettings(const JsonVariantConst src, Settings& dst, bool safe = false
|
||||
}
|
||||
}
|
||||
|
||||
if (!src[FPSTR(S_DHW)][FPSTR(S_OVERHEAT_HIGH_TEMP)].isNull()) {
|
||||
unsigned char value = src[FPSTR(S_DHW)][FPSTR(S_OVERHEAT_HIGH_TEMP)].as<unsigned char>();
|
||||
|
||||
if (isValidTemp(value, dst.system.unitSystem, 0.0f, 100.0f) && value != dst.dhw.overheatHighTemp) {
|
||||
dst.dhw.overheatHighTemp = value;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (!src[FPSTR(S_DHW)][FPSTR(S_OVERHEAT_LOW_TEMP)].isNull()) {
|
||||
unsigned char value = src[FPSTR(S_DHW)][FPSTR(S_OVERHEAT_LOW_TEMP)].as<unsigned char>();
|
||||
|
||||
if (isValidTemp(value, dst.system.unitSystem, 0.0f, 99.0f) && value != dst.dhw.overheatLowTemp) {
|
||||
dst.dhw.overheatLowTemp = value;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (dst.dhw.overheatHighTemp < dst.dhw.overheatLowTemp) {
|
||||
dst.dhw.overheatHighTemp = dst.dhw.overheatLowTemp;
|
||||
changed = true;
|
||||
}
|
||||
|
||||
|
||||
if (!safe) {
|
||||
// external pump
|
||||
@@ -2016,6 +2066,7 @@ void varsToJson(const Variables& src, JsonVariant dst) {
|
||||
mHeating[FPSTR(S_ENABLED)] = src.master.heating.enabled;
|
||||
mHeating[FPSTR(S_BLOCKING)] = src.master.heating.blocking;
|
||||
mHeating[FPSTR(S_INDOOR_TEMP_CONTROL)] = src.master.heating.indoorTempControl;
|
||||
mHeating[FPSTR(S_OVERHEAT)] = src.master.heating.overheat;
|
||||
mHeating[FPSTR(S_SETPOINT_TEMP)] = roundf(src.master.heating.setpointTemp, 2);
|
||||
mHeating[FPSTR(S_TARGET_TEMP)] = roundf(src.master.heating.targetTemp, 2);
|
||||
mHeating[FPSTR(S_CURRENT_TEMP)] = roundf(src.master.heating.currentTemp, 2);
|
||||
@@ -2027,6 +2078,7 @@ void varsToJson(const Variables& src, JsonVariant dst) {
|
||||
|
||||
auto mDhw = master[FPSTR(S_DHW)].to<JsonObject>();
|
||||
mDhw[FPSTR(S_ENABLED)] = src.master.dhw.enabled;
|
||||
mDhw[FPSTR(S_OVERHEAT)] = src.master.dhw.overheat;
|
||||
mDhw[FPSTR(S_TARGET_TEMP)] = roundf(src.master.dhw.targetTemp, 2);
|
||||
mDhw[FPSTR(S_CURRENT_TEMP)] = roundf(src.master.dhw.currentTemp, 2);
|
||||
mDhw[FPSTR(S_RETURN_TEMP)] = roundf(src.master.dhw.returnTemp, 2);
|
||||
|
||||
Reference in New Issue
Block a user