refactor: more logs; improved sensor of current boiler power: added settings min & max boiler power

This commit is contained in:
Yurii
2024-10-15 02:10:46 +03:00
parent dc62f99b7d
commit a9e97c15ad
10 changed files with 235 additions and 103 deletions

View File

@@ -872,38 +872,15 @@ public:
return this->publish(this->getTopic(FPSTR(HA_ENTITY_BINARY_SENSOR), F("diagnostic")).c_str(), doc); return this->publish(this->getTopic(FPSTR(HA_ENTITY_BINARY_SENSOR), F("diagnostic")).c_str(), doc);
} }
bool publishSensorMaxPower(bool enabledByDefault = true) { bool publishSensorPower(bool enabledByDefault = true) {
JsonDocument doc; JsonDocument doc;
doc[FPSTR(HA_AVAILABILITY)][0][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("status")); doc[FPSTR(HA_AVAILABILITY)][0][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("status"));
doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("state")); doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("state"));
doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_VALUE_TEMPLATE)] = F("{{ iif(value_json.states.otStatus, 'online', 'offline') }}"); doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_VALUE_TEMPLATE)] = F("{{ iif(value_json.states.otStatus, 'online', 'offline') }}");
doc[FPSTR(HA_AVAILABILITY_MODE)] = F("all"); doc[FPSTR(HA_AVAILABILITY_MODE)] = F("all");
doc[FPSTR(HA_ENABLED_BY_DEFAULT)] = enabledByDefault; doc[FPSTR(HA_ENABLED_BY_DEFAULT)] = enabledByDefault;
doc[FPSTR(HA_UNIQUE_ID)] = this->getObjectId(F("max_power")); doc[FPSTR(HA_UNIQUE_ID)] = this->getObjectId(F("power"));
doc[FPSTR(HA_OBJECT_ID)] = this->getObjectId(F("max_power")); doc[FPSTR(HA_OBJECT_ID)] = this->getObjectId(F("power"));
doc[FPSTR(HA_ENTITY_CATEGORY)] = F("diagnostic");
doc[FPSTR(HA_DEVICE_CLASS)] = F("power");
doc[FPSTR(HA_STATE_CLASS)] = F("measurement");
doc[FPSTR(HA_UNIT_OF_MEASUREMENT)] = F("kW");
doc[FPSTR(HA_NAME)] = F("Max power");
doc[FPSTR(HA_ICON)] = F("mdi:chart-bar");
doc[FPSTR(HA_STATE_TOPIC)] = this->getDeviceTopic(F("state"));
doc[FPSTR(HA_VALUE_TEMPLATE)] = F("{{ value_json.sensors.maxPower|float(0)|round(2) }}");
doc[FPSTR(HA_EXPIRE_AFTER)] = 120;
doc.shrinkToFit();
return this->publish(this->getTopic(FPSTR(HA_ENTITY_SENSOR), F("max_power")).c_str(), doc);
}
bool publishSensorCurrentPower(bool enabledByDefault = true) {
JsonDocument doc;
doc[FPSTR(HA_AVAILABILITY)][0][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("status"));
doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_TOPIC)] = this->getDeviceTopic(F("state"));
doc[FPSTR(HA_AVAILABILITY)][1][FPSTR(HA_VALUE_TEMPLATE)] = F("{{ iif(value_json.states.otStatus, 'online', 'offline') }}");
doc[FPSTR(HA_AVAILABILITY_MODE)] = F("all");
doc[FPSTR(HA_ENABLED_BY_DEFAULT)] = enabledByDefault;
doc[FPSTR(HA_UNIQUE_ID)] = this->getObjectId(F("current_power"));
doc[FPSTR(HA_OBJECT_ID)] = this->getObjectId(F("current_power"));
doc[FPSTR(HA_ENTITY_CATEGORY)] = F("diagnostic"); doc[FPSTR(HA_ENTITY_CATEGORY)] = F("diagnostic");
doc[FPSTR(HA_DEVICE_CLASS)] = F("power"); doc[FPSTR(HA_DEVICE_CLASS)] = F("power");
doc[FPSTR(HA_STATE_CLASS)] = F("measurement"); doc[FPSTR(HA_STATE_CLASS)] = F("measurement");
@@ -911,11 +888,11 @@ public:
doc[FPSTR(HA_NAME)] = F("Current power"); doc[FPSTR(HA_NAME)] = F("Current power");
doc[FPSTR(HA_ICON)] = F("mdi:chart-bar"); doc[FPSTR(HA_ICON)] = F("mdi:chart-bar");
doc[FPSTR(HA_STATE_TOPIC)] = this->getDeviceTopic(F("state")); doc[FPSTR(HA_STATE_TOPIC)] = this->getDeviceTopic(F("state"));
doc[FPSTR(HA_VALUE_TEMPLATE)] = F("{{ value_json.sensors.currentPower|float(0)|round(2) }}"); doc[FPSTR(HA_VALUE_TEMPLATE)] = F("{{ value_json.sensors.power|float(0)|round(2) }}");
doc[FPSTR(HA_EXPIRE_AFTER)] = 120; doc[FPSTR(HA_EXPIRE_AFTER)] = 120;
doc.shrinkToFit(); doc.shrinkToFit();
return this->publish(this->getTopic(FPSTR(HA_ENTITY_SENSOR), F("current_power")).c_str(), doc); return this->publish(this->getTopic(FPSTR(HA_ENTITY_SENSOR), F("power")).c_str(), doc);
} }
bool publishSensorFaultCode(bool enabledByDefault = true) { bool publishSensorFaultCode(bool enabledByDefault = true) {

View File

@@ -357,8 +357,7 @@ protected:
// sensors // sensors
this->haHelper->publishSensorModulation(false); this->haHelper->publishSensorModulation(false);
this->haHelper->publishSensorPressure(settings.system.unitSystem, false); this->haHelper->publishSensorPressure(settings.system.unitSystem, false);
this->haHelper->publishSensorMaxPower(false); this->haHelper->publishSensorPower();
this->haHelper->publishSensorCurrentPower();
this->haHelper->publishSensorFaultCode(); this->haHelper->publishSensorFaultCode();
this->haHelper->publishSensorDiagnosticCode(); this->haHelper->publishSensorDiagnosticCode();
this->haHelper->publishSensorRssi(false); this->haHelper->publishSensorRssi(false);

View File

@@ -254,32 +254,43 @@ protected:
// These parameters will be updated every minute // These parameters will be updated every minute
if (millis() - this->prevUpdateNonEssentialVars > 60000) { if (millis() - this->prevUpdateNonEssentialVars > 60000) {
if (this->updateMinModulationLevel()) { if (this->updateMinModulationLevel()) {
Log.straceln(FPSTR(L_OT), F("Min modulation: %u%%, boiler max power: %u kW"), vars.parameters.minModulation, vars.sensors.maxPower); Log.snoticeln(
FPSTR(L_OT),
F("Received min modulation: %hhu%%, max power: %hhu kW"),
vars.parameters.minModulation,
vars.parameters.maxPower
);
if (vars.parameters.minModulation > settings.heating.maxModulation) { if (settings.heating.maxModulation < vars.parameters.minModulation) {
settings.heating.maxModulation = vars.parameters.minModulation; settings.heating.maxModulation = vars.parameters.minModulation;
fsSettings.update(); fsSettings.update();
Log.snoticeln(FPSTR(L_OT_DHW), F("Updated min modulation: %hhu"), settings.heating.maxModulation); Log.swarningln(FPSTR(L_SETTINGS_OT), F("Updated min modulation: %hhu%%"), settings.heating.maxModulation);
}
if (fabsf(settings.opentherm.maxPower) < 0.1f && vars.parameters.maxPower > 0) {
settings.opentherm.maxPower = vars.parameters.maxPower;
fsSettings.update();
Log.swarningln(FPSTR(L_SETTINGS_OT), F("Updated max power: %.2f kW"), settings.opentherm.maxPower);
} }
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Failed get min modulation & max power")); Log.swarningln(FPSTR(L_OT), F("Failed receive min modulation and max power"));
} }
if (!heatingEnabled && settings.opentherm.modulationSyncWithHeating) { if (!heatingEnabled && settings.opentherm.modulationSyncWithHeating) {
if (this->setMaxModulationLevel(0)) { if (this->setMaxModulationLevel(0)) {
Log.snoticeln(FPSTR(L_OT_HEATING), F("Set max modulation 0% (off)")); Log.snoticeln(FPSTR(L_OT_HEATING), F("Set max modulation: 0% (off)"));
} else { } else {
Log.swarningln(FPSTR(L_OT_HEATING), F("Failed set max modulation 0% (off)")); Log.swarningln(FPSTR(L_OT_HEATING), F("Failed set max modulation: 0% (off)"));
} }
} else { } else {
if (this->setMaxModulationLevel(settings.heating.maxModulation)) { if (this->setMaxModulationLevel(settings.heating.maxModulation)) {
Log.snoticeln(FPSTR(L_OT_HEATING), F("Set max modulation %hhu%%"), settings.heating.maxModulation); Log.snoticeln(FPSTR(L_OT_HEATING), F("Set max modulation: %hhu%%"), settings.heating.maxModulation);
} else { } else {
Log.swarningln(FPSTR(L_OT_HEATING), F("Failed set max modulation %hhu%%"), settings.heating.maxModulation); Log.swarningln(FPSTR(L_OT_HEATING), F("Failed set max modulation: %hhu%%"), settings.heating.maxModulation);
} }
} }
@@ -287,23 +298,30 @@ protected:
// Get DHW min/max temp (if necessary) // Get DHW min/max temp (if necessary)
if (settings.opentherm.dhwPresent && settings.opentherm.getMinMaxTemp) { if (settings.opentherm.dhwPresent && settings.opentherm.getMinMaxTemp) {
if (this->updateMinMaxDhwTemp()) { if (this->updateMinMaxDhwTemp()) {
Log.snoticeln(
FPSTR(L_OT_DHW),
F("Received min temp: %hhu, max temp: %hhu"),
vars.parameters.dhwMinTemp,
vars.parameters.dhwMaxTemp
);
if (settings.dhw.minTemp < vars.parameters.dhwMinTemp) { if (settings.dhw.minTemp < vars.parameters.dhwMinTemp) {
settings.dhw.minTemp = vars.parameters.dhwMinTemp; settings.dhw.minTemp = vars.parameters.dhwMinTemp;
fsSettings.update(); fsSettings.update();
Log.snoticeln(FPSTR(L_OT_DHW), F("Updated min temp: %hhu"), settings.dhw.minTemp); Log.swarningln(FPSTR(L_SETTINGS_DHW), F("Updated min temp: %hhu"), settings.dhw.minTemp);
} }
if (settings.dhw.maxTemp > vars.parameters.dhwMaxTemp) { if (settings.dhw.maxTemp > vars.parameters.dhwMaxTemp) {
settings.dhw.maxTemp = vars.parameters.dhwMaxTemp; settings.dhw.maxTemp = vars.parameters.dhwMaxTemp;
fsSettings.update(); fsSettings.update();
Log.snoticeln(FPSTR(L_OT_DHW), F("Updated max temp: %hhu"), settings.dhw.maxTemp); Log.swarningln(FPSTR(L_SETTINGS_DHW), F("Updated max temp: %hhu"), settings.dhw.maxTemp);
} }
} else { } else {
vars.parameters.dhwMinTemp = convertTemp(DEFAULT_DHW_MIN_TEMP, UnitSystem::METRIC, settings.system.unitSystem); vars.parameters.dhwMinTemp = convertTemp(DEFAULT_DHW_MIN_TEMP, UnitSystem::METRIC, settings.system.unitSystem);
vars.parameters.dhwMaxTemp = convertTemp(DEFAULT_DHW_MAX_TEMP, UnitSystem::METRIC, settings.system.unitSystem); vars.parameters.dhwMaxTemp = convertTemp(DEFAULT_DHW_MAX_TEMP, UnitSystem::METRIC, settings.system.unitSystem);
Log.swarningln(FPSTR(L_OT_DHW), F("Failed get min/max temp")); Log.swarningln(FPSTR(L_OT_DHW), F("Failed receive min/max temp"));
} }
if (settings.dhw.minTemp >= settings.dhw.maxTemp) { if (settings.dhw.minTemp >= settings.dhw.maxTemp) {
@@ -317,23 +335,30 @@ protected:
// Get heating min/max temp // Get heating min/max temp
if (settings.opentherm.getMinMaxTemp) { if (settings.opentherm.getMinMaxTemp) {
if (this->updateMinMaxHeatingTemp()) { if (this->updateMinMaxHeatingTemp()) {
Log.snoticeln(
FPSTR(L_OT_HEATING),
F("Received min temp: %hhu, max temp: %hhu"),
vars.parameters.heatingMinTemp,
vars.parameters.heatingMaxTemp
);
if (settings.heating.minTemp < vars.parameters.heatingMinTemp) { if (settings.heating.minTemp < vars.parameters.heatingMinTemp) {
settings.heating.minTemp = vars.parameters.heatingMinTemp; settings.heating.minTemp = vars.parameters.heatingMinTemp;
fsSettings.update(); fsSettings.update();
Log.snoticeln(FPSTR(L_OT_HEATING), F("Updated min temp: %hhu"), settings.heating.minTemp); Log.swarningln(FPSTR(L_SETTINGS_HEATING), F("Updated min temp: %hhu"), settings.heating.minTemp);
} }
if (settings.heating.maxTemp > vars.parameters.heatingMaxTemp) { if (settings.heating.maxTemp > vars.parameters.heatingMaxTemp) {
settings.heating.maxTemp = vars.parameters.heatingMaxTemp; settings.heating.maxTemp = vars.parameters.heatingMaxTemp;
fsSettings.update(); fsSettings.update();
Log.snoticeln(FPSTR(L_OT_HEATING), F("Updated max temp: %hhu"), settings.heating.maxTemp); Log.swarningln(FPSTR(L_SETTINGS_HEATING), F("Updated max temp: %hhu"), settings.heating.maxTemp);
} }
} else { } else {
vars.parameters.heatingMinTemp = convertTemp(DEFAULT_HEATING_MIN_TEMP, UnitSystem::METRIC, settings.system.unitSystem); vars.parameters.heatingMinTemp = convertTemp(DEFAULT_HEATING_MIN_TEMP, UnitSystem::METRIC, settings.system.unitSystem);
vars.parameters.heatingMaxTemp = convertTemp(DEFAULT_HEATING_MAX_TEMP, UnitSystem::METRIC, settings.system.unitSystem); vars.parameters.heatingMaxTemp = convertTemp(DEFAULT_HEATING_MAX_TEMP, UnitSystem::METRIC, settings.system.unitSystem);
Log.swarningln(FPSTR(L_OT_HEATING), F("Failed get min/max temp")); Log.swarningln(FPSTR(L_OT_HEATING), F("Failed receive min/max temp"));
} }
} }
@@ -345,7 +370,19 @@ protected:
// Get fault code (if necessary) // Get fault code (if necessary)
if (vars.states.fault) { if (vars.states.fault) {
this->updateFaultCode(); if (this->updateFaultCode()) {
Log.snoticeln(
FPSTR(L_OT),
F("Received fault code: %hhu%% (0x%02X)"),
vars.sensors.faultCode,
vars.sensors.faultCode
);
} else {
vars.sensors.faultCode = 0;
Log.swarningln(FPSTR(L_OT), F("Failed receive fault code"));
}
} else if (vars.sensors.faultCode != 0) { } else if (vars.sensors.faultCode != 0) {
vars.sensors.faultCode = 0; vars.sensors.faultCode = 0;
@@ -353,7 +390,19 @@ protected:
// Get diagnostic code (if necessary) // Get diagnostic code (if necessary)
if (vars.states.fault || vars.states.diagnostic) { if (vars.states.fault || vars.states.diagnostic) {
this->updateDiagCode(); if (this->updateDiagCode()) {
Log.snoticeln(
FPSTR(L_OT),
F("Received diag code: %hhu%% (0x%02X)"),
vars.sensors.diagnosticCode,
vars.sensors.diagnosticCode
);
} else {
vars.sensors.diagnosticCode = 0;
Log.swarningln(FPSTR(L_OT), F("Failed receive diag code"));
}
} else if (vars.sensors.diagnosticCode != 0) { } else if (vars.sensors.diagnosticCode != 0) {
vars.sensors.diagnosticCode = 0; vars.sensors.diagnosticCode = 0;
@@ -364,11 +413,21 @@ protected:
if (!settings.opentherm.filterNumValues.enable) { if (!settings.opentherm.filterNumValues.enable) {
// Get outdoor temp (if necessary) // Get outdoor temp (if necessary)
if (settings.sensors.outdoor.type == SensorType::BOILER) { if (settings.sensors.outdoor.type == SensorType::BOILER) {
this->updateOutdoorTemp(); if (this->updateOutdoorTemp()) {
Log.snoticeln(FPSTR(L_OT), F("Received outdoor temp: %.2f"), vars.temperatures.outdoor);
} else {
Log.swarningln(FPSTR(L_OT), F("Failed receive outdoor temp"));
}
} }
// Get pressure // Get pressure
this->updatePressure(); if (this->updatePressure()) {
Log.snoticeln(FPSTR(L_OT), F("Received pressure: %.2f"), vars.sensors.pressure);
} else {
Log.swarningln(FPSTR(L_OT), F("Failed receive pressure"));
}
} }
this->prevUpdateNonEssentialVars = millis(); this->prevUpdateNonEssentialVars = millis();
@@ -376,28 +435,52 @@ protected:
// Get current modulation level (if necessary) // Get current modulation level (if necessary)
if (vars.states.flame && this->updateModulationLevel()) { if (vars.states.flame) {
vars.sensors.currentPower = vars.sensors.maxPower > 0 if (this->updateModulationLevel()) {
? vars.sensors.maxPower * (vars.sensors.modulation / 100) if (settings.opentherm.maxPower > 0.1f) {
: 0; float modulatedPower = settings.opentherm.maxPower - settings.opentherm.minPower;
vars.sensors.power = settings.opentherm.minPower + (modulatedPower / 100.0f * vars.sensors.modulation);
Log.sverboseln(
FPSTR(L_OT_DHW), } else {
F("Current modulation level: %.2f%%, power: %.2f of %hhu kW"), vars.sensors.power = 0.0f;
vars.sensors.modulation, }
vars.sensors.currentPower,
vars.sensors.maxPower Log.snoticeln(
); FPSTR(L_OT),
F("Received modulation level: %.2f%%, power: %.2f of %.2f kW (min: %.2f kW)"),
vars.sensors.modulation,
vars.sensors.power,
settings.opentherm.maxPower,
settings.opentherm.minPower
);
} else {
vars.sensors.modulation = 0;
vars.sensors.power = 0;
Log.swarningln(FPSTR(L_OT), F("Failed receive modulation level"));
}
} else { } else {
vars.sensors.modulation = 0; vars.sensors.modulation = 0;
vars.sensors.currentPower = 0; vars.sensors.power = 0;
} }
// Update DHW sensors (if necessary) // Update DHW sensors (if necessary)
if (settings.opentherm.dhwPresent) { if (settings.opentherm.dhwPresent) {
this->updateDhwTemp(); if (this->updateDhwTemp()) {
this->updateDhwFlowRate(); Log.snoticeln(FPSTR(L_OT_DHW), F("Received temp: %.2f"), vars.temperatures.dhw);
} else {
Log.swarningln(FPSTR(L_OT_DHW), F("Failed receive temp"));
}
if (this->updateDhwFlowRate()) {
Log.snoticeln(FPSTR(L_OT_DHW), F("Received flow rate: %.2f"), vars.sensors.dhwFlowRate);
} else {
Log.swarningln(FPSTR(L_OT_DHW), F("Failed receive flow rate"));
}
} else { } else {
vars.temperatures.dhw = 0.0f; vars.temperatures.dhw = 0.0f;
@@ -405,24 +488,49 @@ protected:
} }
// Get current heating temp // Get current heating temp
this->updateHeatingTemp(); if (this->updateHeatingTemp()) {
Log.snoticeln(FPSTR(L_OT_HEATING), F("Received temp: %.2f"), vars.temperatures.heating);
} else {
Log.swarningln(FPSTR(L_OT_HEATING), F("Failed receive temp"));
}
// Get heating return temp // Get heating return temp
this->updateHeatingReturnTemp(); if (this->updateHeatingReturnTemp()) {
Log.snoticeln(FPSTR(L_OT_HEATING), F("Received return temp: %.2f"), vars.temperatures.heatingReturn);
} else {
Log.swarningln(FPSTR(L_OT_HEATING), F("Failed receive return temp"));
}
// Get exhaust temp // Get exhaust temp
this->updateExhaustTemp(); if (this->updateExhaustTemp()) {
Log.snoticeln(FPSTR(L_OT), F("Received exhaust temp: %.2f"), vars.temperatures.exhaust);
} else {
Log.swarningln(FPSTR(L_OT), F("Failed receive exhaust temp"));
}
// If filtering is enabled, these parameters // If filtering is enabled, these parameters
// must be updated every time. // must be updated every time.
if (settings.opentherm.filterNumValues.enable) { if (settings.opentherm.filterNumValues.enable) {
// Get outdoor temp (if necessary) // Get outdoor temp (if necessary)
if (settings.sensors.outdoor.type == SensorType::BOILER) { if (settings.sensors.outdoor.type == SensorType::BOILER) {
this->updateOutdoorTemp(); if (this->updateOutdoorTemp()) {
Log.snoticeln(FPSTR(L_OT), F("Received outdoor temp: %.2f"), vars.temperatures.outdoor);
} else {
Log.swarningln(FPSTR(L_OT), F("Failed receive outdoor temp"));
}
} }
// Get pressure // Get pressure
this->updatePressure(); if (this->updatePressure()) {
Log.snoticeln(FPSTR(L_OT), F("Received pressure: %.2f"), vars.sensors.pressure);
} else {
Log.swarningln(FPSTR(L_OT), F("Failed receive pressure"));
}
} }
@@ -573,46 +681,46 @@ protected:
void initialize() { void initialize() {
// Not all boilers support these, only try once when the boiler becomes connected // Not all boilers support these, only try once when the boiler becomes connected
if (this->updateSlaveVersion()) { if (this->updateSlaveVersion()) {
Log.straceln(FPSTR(L_OT), F("Slave version: %u, type: %u"), vars.parameters.slaveVersion, vars.parameters.slaveType); Log.snoticeln(FPSTR(L_OT), F("Received slave version: %u, type: %u"), vars.parameters.slaveVersion, vars.parameters.slaveType);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Get slave version failed")); Log.swarningln(FPSTR(L_OT), F("Failed receive slave version"));
} }
// 0x013F // 0x013F
if (this->setMasterVersion(0x3F, 0x01)) { if (this->setMasterVersion(0x3F, 0x01)) {
Log.straceln(FPSTR(L_OT), F("Master version: %u, type: %u"), vars.parameters.masterVersion, vars.parameters.masterType); Log.snoticeln(FPSTR(L_OT), F("Set master version: %u, type: %u"), vars.parameters.masterVersion, vars.parameters.masterType);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Set master version failed")); Log.swarningln(FPSTR(L_OT), F("Failed set master version"));
} }
if (this->updateSlaveOtVersion()) { if (this->updateSlaveOtVersion()) {
Log.straceln(FPSTR(L_OT), F("Slave OT version: %f"), vars.parameters.slaveOtVersion); Log.snoticeln(FPSTR(L_OT), F("Received slave OT version: %f"), vars.parameters.slaveOtVersion);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Get slave OT version failed")); Log.swarningln(FPSTR(L_OT), F("Failed receive slave OT version"));
} }
if (this->setMasterOtVersion(2.2f)) { if (this->setMasterOtVersion(2.2f)) {
Log.straceln(FPSTR(L_OT), F("Master OT version: %f"), vars.parameters.masterOtVersion); Log.snoticeln(FPSTR(L_OT), F("Set master OT version: %f"), vars.parameters.masterOtVersion);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Set master OT version failed")); Log.swarningln(FPSTR(L_OT), F("Failed set master OT version"));
} }
if (this->updateSlaveConfig()) { if (this->updateSlaveConfig()) {
Log.straceln(FPSTR(L_OT), F("Slave member id: %u, flags: %u"), vars.parameters.slaveMemberId, vars.parameters.slaveFlags); Log.snoticeln(FPSTR(L_OT), F("Received slave member id: %u, flags: %u"), vars.parameters.slaveMemberId, vars.parameters.slaveFlags);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Get slave config failed")); Log.swarningln(FPSTR(L_OT), F("Failed receive slave config"));
} }
if (this->setMasterConfig(settings.opentherm.memberIdCode & 0xFF, (settings.opentherm.memberIdCode & 0xFFFF) >> 8)) { if (this->setMasterConfig(settings.opentherm.memberIdCode & 0xFF, (settings.opentherm.memberIdCode & 0xFFFF) >> 8)) {
Log.straceln(FPSTR(L_OT), F("Master member id: %u, flags: %u"), vars.parameters.masterMemberId, vars.parameters.masterFlags); Log.snoticeln(FPSTR(L_OT), F("Set master member id: %u, flags: %u"), vars.parameters.masterMemberId, vars.parameters.masterFlags);
} else { } else {
Log.swarningln(FPSTR(L_OT), F("Set master config failed")); Log.swarningln(FPSTR(L_OT), F("Failed set master config"));
} }
} }
@@ -1023,7 +1131,6 @@ protected:
)); ));
if (!CustomOpenTherm::isValidResponse(response)) { if (!CustomOpenTherm::isValidResponse(response)) {
vars.sensors.faultCode = 0;
return false; return false;
} }
@@ -1039,7 +1146,6 @@ protected:
)); ));
if (!CustomOpenTherm::isValidResponse(response)) { if (!CustomOpenTherm::isValidResponse(response)) {
vars.sensors.diagnosticCode = 0;
return false; return false;
} }
@@ -1059,6 +1165,10 @@ protected:
} }
float value = CustomOpenTherm::getFloat(response); float value = CustomOpenTherm::getFloat(response);
if (value < 0) {
return false;
}
if (settings.opentherm.filterNumValues.enable && fabs(vars.sensors.modulation) >= 0.1f) { if (settings.opentherm.filterNumValues.enable && fabs(vars.sensors.modulation) >= 0.1f) {
vars.sensors.modulation += (value - vars.sensors.modulation) * settings.opentherm.filterNumValues.factor; vars.sensors.modulation += (value - vars.sensors.modulation) * settings.opentherm.filterNumValues.factor;
@@ -1080,11 +1190,8 @@ protected:
return false; return false;
} }
byte minModulation = response & 0xFF; vars.parameters.minModulation = response & 0xFF;
byte maxPower = (response & 0xFFFF) >> 8; vars.parameters.maxPower = (response & 0xFFFF) >> 8;
vars.parameters.minModulation = minModulation;
vars.sensors.maxPower = maxPower;
return true; return true;
} }

View File

@@ -56,6 +56,8 @@ struct Settings {
unsigned int memberIdCode = 0; unsigned int memberIdCode = 0;
float pressureFactor = 1.0f; float pressureFactor = 1.0f;
float dhwFlowRateFactor = 1.0f; float dhwFlowRateFactor = 1.0f;
float minPower = 0.0f;
float maxPower = 0.0f;
bool dhwPresent = true; bool dhwPresent = true;
bool summerWinterMode = false; bool summerWinterMode = false;
bool heatingCh2Enabled = true; bool heatingCh2Enabled = true;
@@ -174,8 +176,7 @@ struct Variables {
float modulation = 0.0f; float modulation = 0.0f;
float pressure = 0.0f; float pressure = 0.0f;
float dhwFlowRate = 0.0f; float dhwFlowRate = 0.0f;
byte maxPower = 0; float power = 0.0f;
float currentPower = 0.0f;
byte faultCode = 0; byte faultCode = 0;
unsigned short diagnosticCode = 0; unsigned short diagnosticCode = 0;
int8_t rssi = 0; int8_t rssi = 0;
@@ -214,6 +215,7 @@ struct Variables {
byte dhwMaxTemp = DEFAULT_DHW_MAX_TEMP; byte dhwMaxTemp = DEFAULT_DHW_MAX_TEMP;
byte minModulation = 0; byte minModulation = 0;
byte maxModulation = 0; byte maxModulation = 0;
uint8_t maxPower = 0;
uint8_t slaveMemberId = 0; uint8_t slaveMemberId = 0;
uint8_t slaveFlags = 0; uint8_t slaveFlags = 0;
uint8_t slaveType = 0; uint8_t slaveType = 0;

View File

@@ -4,6 +4,9 @@
#endif #endif
const char L_SETTINGS[] PROGMEM = "SETTINGS"; const char L_SETTINGS[] PROGMEM = "SETTINGS";
const char L_SETTINGS_OT[] PROGMEM = "SETTINGS.OT";
const char L_SETTINGS_DHW[] PROGMEM = "SETTINGS.DHW";
const char L_SETTINGS_HEATING[] PROGMEM = "SETTINGS.HEATING";
const char L_NETWORK[] PROGMEM = "NETWORK"; const char L_NETWORK[] PROGMEM = "NETWORK";
const char L_NETWORK_SETTINGS[] PROGMEM = "NETWORK.SETTINGS"; const char L_NETWORK_SETTINGS[] PROGMEM = "NETWORK.SETTINGS";
const char L_PORTAL_WEBSERVER[] PROGMEM = "PORTAL.WEBSERVER"; const char L_PORTAL_WEBSERVER[] PROGMEM = "PORTAL.WEBSERVER";

View File

@@ -347,6 +347,8 @@ void settingsToJson(const Settings& src, JsonVariant dst, bool safe = false) {
dst["opentherm"]["memberIdCode"] = src.opentherm.memberIdCode; dst["opentherm"]["memberIdCode"] = src.opentherm.memberIdCode;
dst["opentherm"]["pressureFactor"] = roundd(src.opentherm.pressureFactor, 2); dst["opentherm"]["pressureFactor"] = roundd(src.opentherm.pressureFactor, 2);
dst["opentherm"]["dhwFlowRateFactor"] = roundd(src.opentherm.dhwFlowRateFactor, 2); dst["opentherm"]["dhwFlowRateFactor"] = roundd(src.opentherm.dhwFlowRateFactor, 2);
dst["opentherm"]["minPower"] = roundd(src.opentherm.minPower, 2);
dst["opentherm"]["maxPower"] = roundd(src.opentherm.maxPower, 2);
dst["opentherm"]["dhwPresent"] = src.opentherm.dhwPresent; dst["opentherm"]["dhwPresent"] = src.opentherm.dhwPresent;
dst["opentherm"]["summerWinterMode"] = src.opentherm.summerWinterMode; dst["opentherm"]["summerWinterMode"] = src.opentherm.summerWinterMode;
dst["opentherm"]["heatingCh2Enabled"] = src.opentherm.heatingCh2Enabled; dst["opentherm"]["heatingCh2Enabled"] = src.opentherm.heatingCh2Enabled;
@@ -716,6 +718,24 @@ bool jsonToSettings(const JsonVariantConst src, Settings& dst, bool safe = false
} }
} }
if (!src["opentherm"]["minPower"].isNull()) {
float value = src["opentherm"]["minPower"].as<float>();
if (value >= 0 && value <= 1000 && fabs(value - dst.opentherm.minPower) > 0.0001f) {
dst.opentherm.minPower = roundd(value, 2);
changed = true;
}
}
if (!src["opentherm"]["maxPower"].isNull()) {
float value = src["opentherm"]["maxPower"].as<float>();
if (value >= 0 && value <= 1000 && fabs(value - dst.opentherm.maxPower) > 0.0001f) {
dst.opentherm.maxPower = roundd(value, 2);
changed = true;
}
}
if (src["opentherm"]["filterNumValues"]["enable"].is<bool>()) { if (src["opentherm"]["filterNumValues"]["enable"].is<bool>()) {
bool value = src["opentherm"]["filterNumValues"]["enable"].as<bool>(); bool value = src["opentherm"]["filterNumValues"]["enable"].as<bool>();
@@ -1546,8 +1566,7 @@ void varsToJson(const Variables& src, JsonVariant dst) {
dst["sensors"]["modulation"] = roundd(src.sensors.modulation, 2); dst["sensors"]["modulation"] = roundd(src.sensors.modulation, 2);
dst["sensors"]["pressure"] = roundd(src.sensors.pressure, 2); dst["sensors"]["pressure"] = roundd(src.sensors.pressure, 2);
dst["sensors"]["dhwFlowRate"] = roundd(src.sensors.dhwFlowRate, 2); dst["sensors"]["dhwFlowRate"] = roundd(src.sensors.dhwFlowRate, 2);
dst["sensors"]["maxPower"] = src.sensors.maxPower; dst["sensors"]["power"] = roundd(src.sensors.power, 2);
dst["sensors"]["currentPower"] = roundd(src.sensors.currentPower, 2);
dst["sensors"]["faultCode"] = src.sensors.faultCode; dst["sensors"]["faultCode"] = src.sensors.faultCode;
dst["sensors"]["diagnosticCode"] = src.sensors.diagnosticCode; dst["sensors"]["diagnosticCode"] = src.sensors.diagnosticCode;
dst["sensors"]["rssi"] = src.sensors.rssi; dst["sensors"]["rssi"] = src.sensors.rssi;

View File

@@ -100,8 +100,7 @@
"modulation": "Modulation", "modulation": "Modulation",
"pressure": "Pressure", "pressure": "Pressure",
"dhwFlowRate": "DHW flow rate", "dhwFlowRate": "DHW flow rate",
"maxPower": "Max power", "power": "Current power",
"currentPower": "Current power",
"faultCode": "Fault code", "faultCode": "Fault code",
"diagCode": "Diagnostic code", "diagCode": "Diagnostic code",
"indoorTemp": "Indoor temp", "indoorTemp": "Indoor temp",
@@ -272,6 +271,14 @@
"title": "Coeff. DHW flow rate correction", "title": "Coeff. DHW flow rate correction",
"note": "If the DHW flow rate displayed is <b>X10</b> from the real one, set the <b>0.1</b>." "note": "If the DHW flow rate displayed is <b>X10</b> from the real one, set the <b>0.1</b>."
}, },
"minPower": {
"title": "Min boiler power <small>(kW)</small>",
"note": "This value is at 0-1% boiler modulation level. Typically found in the boiler specification as \"minimum useful heat output\"."
},
"maxPower": {
"title": "Max boiler power <small>(kW)</small>",
"note": "<b>0</b> - try detect automatically. Typically found in the boiler specification as \"maximum useful heat output\"."
},
"fnv": { "fnv": {
"title": "Filtering numeric values", "title": "Filtering numeric values",
"enable": { "enable": {

View File

@@ -100,8 +100,7 @@
"modulation": "Уровень модуляции", "modulation": "Уровень модуляции",
"pressure": "Давление", "pressure": "Давление",
"dhwFlowRate": "Расход ГВС", "dhwFlowRate": "Расход ГВС",
"maxPower": "Макс. мощность", "power": "Текущая мощность",
"currentPower": "Текущая мощность",
"faultCode": "Код ошибки", "faultCode": "Код ошибки",
"diagCode": "Диагностический код", "diagCode": "Диагностический код",
"indoorTemp": "Внутренняя темп.", "indoorTemp": "Внутренняя темп.",
@@ -272,6 +271,14 @@
"title": "Коэфф. коррекции потока ГВС", "title": "Коэфф. коррекции потока ГВС",
"note": "Если поток ГВС отображается <b>Х10</b> от реального, установите значение <b>0.1</b>." "note": "Если поток ГВС отображается <b>Х10</b> от реального, установите значение <b>0.1</b>."
}, },
"minPower": {
"title": "Мин. мощность котла <small>(кВ)</small>",
"note": "Это значение соответствует уровню модуляции котла 01%. Обычно можно найти в спецификации котла как \"минимальная полезная тепловая мощность\"."
},
"maxPower": {
"title": "Макс. мощность котла <small>(кВ)</small>",
"note": "<b>0</b> - попробовать определить автоматически. Обычно можно найти в спецификации котла как \"максимальная полезная тепловая мощность\"."
},
"fnv": { "fnv": {
"title": "Фильтрация числовых значений", "title": "Фильтрация числовых значений",
"enable": { "enable": {

View File

@@ -159,12 +159,8 @@
<td><b id="ot-dhw-flow-rate"></b> <span class="volume-unit"></span>/min</td> <td><b id="ot-dhw-flow-rate"></b> <span class="volume-unit"></span>/min</td>
</tr> </tr>
<tr> <tr>
<th scope="row" data-i18n>dashboard.state.maxPower</th> <th scope="row" data-i18n>dashboard.state.power</th>
<td><b id="ot-max-power"></b> <span data-i18n>kw</span></td> <td><b id="ot-power"></b> <span data-i18n>kw</span></td>
</tr>
<tr>
<th scope="row" data-i18n>dashboard.state.currentPower</th>
<td><b id="ot-current-power"></b> <span data-i18n>kw</span></td>
</tr> </tr>
<tr> <tr>
<th scope="row" data-i18n>dashboard.state.faultCode</th> <th scope="row" data-i18n>dashboard.state.faultCode</th>
@@ -442,8 +438,7 @@
setValue('#ot-modulation', result.sensors.modulation); setValue('#ot-modulation', result.sensors.modulation);
setValue('#ot-pressure', result.sensors.pressure); setValue('#ot-pressure', result.sensors.pressure);
setValue('#ot-dhw-flow-rate', result.sensors.dhwFlowRate); setValue('#ot-dhw-flow-rate', result.sensors.dhwFlowRate);
setValue('#ot-max-power', result.sensors.maxPower); setValue('#ot-power', result.sensors.power);
setValue('#ot-current-power', result.sensors.currentPower);
setValue( setValue(
'#ot-fault-code', '#ot-fault-code',
result.sensors.faultCode result.sensors.faultCode

View File

@@ -415,6 +415,20 @@
</label> </label>
</div> </div>
<div class="grid">
<label for="opentherm-min-power">
<span data-i18n>settings.ot.minPower.title</span>
<input type="number" inputmode="numeric" id="opentherm-min-power" name="opentherm[minPower]" min="0" max="1000" step="0.1">
<small data-i18n>settings.ot.minPower.note</small>
</label>
<label for="opentherm-max-power">
<span data-i18n>settings.ot.maxPower.title</span>
<input type="number" inputmode="numeric" id="opentherm-max-power" name="opentherm[maxPower]" min="0" max="1000" step="0.1">
<small data-i18n>settings.ot.maxPower.note</small>
</label>
</div>
<fieldset> <fieldset>
<legend data-i18n>settings.section.ot.options</legend> <legend data-i18n>settings.section.ot.options</legend>
<label for="opentherm-dhw-present"> <label for="opentherm-dhw-present">
@@ -768,6 +782,8 @@
setInputValue('#opentherm-member-id-code', data.opentherm.memberIdCode); setInputValue('#opentherm-member-id-code', data.opentherm.memberIdCode);
setInputValue('#opentherm-pressure-factor', data.opentherm.pressureFactor); setInputValue('#opentherm-pressure-factor', data.opentherm.pressureFactor);
setInputValue('#opentherm-dhw-fr-factor', data.opentherm.dhwFlowRateFactor); setInputValue('#opentherm-dhw-fr-factor', data.opentherm.dhwFlowRateFactor);
setInputValue('#opentherm-min-power', data.opentherm.minPower);
setInputValue('#opentherm-max-power', data.opentherm.maxPower);
setCheckboxValue('#opentherm-dhw-present', data.opentherm.dhwPresent); setCheckboxValue('#opentherm-dhw-present', data.opentherm.dhwPresent);
setCheckboxValue('#opentherm-sw-mode', data.opentherm.summerWinterMode); setCheckboxValue('#opentherm-sw-mode', data.opentherm.summerWinterMode);
setCheckboxValue('#opentherm-heating-ch2-enabled', data.opentherm.heatingCh2Enabled); setCheckboxValue('#opentherm-heating-ch2-enabled', data.opentherm.heatingCh2Enabled);