jeka/OTGateway
1
0
Fork 0
mirror of https://github.com/Laxilef/OTGateway.git synced 2025-12-10 18:24:27 +05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: migrating from Telnet to WebSerial for remote logging

Browse Source
This commit is contained in:
Yurii
2025-11-06 13:29:59 +03:00
parent 192f4ee18b
commit 1d7f85f462
17 changed files with 75 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/MainTask.h
View File

@@ -6,7 +6,6 @@ extern NetworkMgr* network;
extern MqttTask* tMqtt;
extern OpenThermTask* tOt;
extern FileData fsNetworkSettings, fsSettings, fsSensorsSettings;
extern ESPTelnetStream* telnetStream;
class MainTask : public Task {
@@ -40,7 +39,6 @@ protected:
PumpStartReason extPumpStartReason = PumpStartReason::NONE;
unsigned long externalPumpStartTime = 0;
bool ntpStarted = false;
bool telnetStarted = false;
bool emergencyDetected = false;
unsigned long emergencyFlipTime = 0;
bool freezeDetected = false;
@@ -106,9 +104,9 @@ protected:
vars.network.connected = network->isConnected();
vars.network.rssi = network->isConnected() ? WiFi.RSSI() : 0;
if (settings.system.logLevel >= TinyLogger::Level::SILENT && settings.system.logLevel <= TinyLogger::Level::VERBOSE) {
if (settings.system.logLevel >= TinyLoggerLevel::SILENT && settings.system.logLevel <= TinyLoggerLevel::VERBOSE) {
if (Log.getLevel() != settings.system.logLevel) {
Log.setLevel(static_cast<TinyLogger::Level>(settings.system.logLevel));
Log.setLevel(static_cast<TinyLoggerLevel>(settings.system.logLevel));
}
}
@@ -123,11 +121,6 @@ protected:
}
}
if (!this->telnetStarted && telnetStream != nullptr) {
telnetStream->begin(23, false);
this->telnetStarted = true;
}
if (settings.mqtt.enabled && !tMqtt->isEnabled()) {
tMqtt->enable();
@@ -142,11 +135,6 @@ protected:
this->ntpStarted = false;
}
if (this->telnetStarted) {
telnetStream->stop();
this->telnetStarted = false;
}
if (tMqtt->isEnabled()) {
tMqtt->disable();
}
@@ -160,23 +148,10 @@ protected:
}
this->ledStatus();
// telnet
if (this->telnetStarted) {
this->yield();
telnetStream->loop();
this->yield();
}
// anti memory leak
for (Stream* stream : Log.getStreams()) {
while (stream->available() > 0) {
stream->read();
#ifdef ARDUINO_ARCH_ESP8266
::optimistic_yield(1000);
#endif
}
while (Serial.available() > 0) {
Serial.read();
}
// heap info
@@ -215,7 +190,7 @@ protected:
vars.states.restarting = true;
}
if (settings.system.logLevel < TinyLogger::Level::VERBOSE) {
if (settings.system.logLevel < TinyLoggerLevel::VERBOSE) {
return;
}

2
src/MqttTask.h
View File

@@ -416,7 +416,7 @@ protected:
return;
}
if (settings.system.logLevel >= TinyLogger::Level::TRACE) {
if (settings.system.logLevel >= TinyLoggerLevel::TRACE) {
Log.strace(FPSTR(L_MQTT_MSG), F("Topic: %s\r\n> "), topic.c_str());
if (Log.lock()) {
for (size_t i = 0; i < length; i++) {

6
src/PortalTask.h
View File

@@ -13,6 +13,7 @@ using namespace NetworkUtils;
extern NetworkMgr* network;
extern FileData fsNetworkSettings, fsSettings, fsSensorsSettings;
extern MqttTask* tMqtt;
extern WebSerial* webSerial;
class PortalTask : public LeanTask {
@@ -76,6 +77,11 @@ protected:
return request->requestAuthentication(AsyncAuthType::AUTH_BASIC, PROJECT_NAME, "Authentication failed");
});
// web serial
if (webSerial != nullptr) {
webSerial->begin(this->webServer);
}
// index page
this->webServer->on("/", HTTP_GET, [](AsyncWebServerRequest *request) {
request->redirect("/index.html");

5
src/Settings.h
View File

@@ -32,9 +32,8 @@ struct Settings {
} serial;
struct {
bool enabled = DEFAULT_TELNET_ENABLED;
unsigned short port = DEFAULT_TELNET_PORT;
} telnet;
bool enabled = DEFAULT_WEBSERIAL_ENABLED;
} webSerial;
struct {
char server[49] = "pool.ntp.org";

10
src/defines.h
View File

@@ -42,12 +42,8 @@
#define DEFAULT_SERIAL_BAUD 115200
#endif
#ifndef DEFAULT_TELNET_ENABLED
#define DEFAULT_TELNET_ENABLED true
#endif
#ifndef DEFAULT_TELNET_PORT
#define DEFAULT_TELNET_PORT 23
#ifndef DEFAULT_WEBSERIAL_ENABLED
#define DEFAULT_WEBSERIAL_ENABLED true
#endif
#ifndef USE_BLE
@@ -75,7 +71,7 @@
#endif
#ifndef DEFAULT_LOG_LEVEL
#define DEFAULT_LOG_LEVEL TinyLogger::Level::VERBOSE
#define DEFAULT_LOG_LEVEL TinyLoggerLevel::VERBOSE
#endif
#ifndef DEFAULT_STATUS_LED_GPIO

26
src/main.cpp
View File

@@ -2,7 +2,7 @@
#include <ArduinoJson.h>
#include <FileData.h>
#include <LittleFS.h>
#include <ESPTelnetStream.h>
#include <MycilaWebSerial.h>
#include "defines.h"
#include "strings.h"
@@ -34,7 +34,7 @@
using namespace NetworkUtils;
// Vars
ESPTelnetStream* telnetStream = nullptr;
WebSerial* webSerial = nullptr;
NetworkMgr* network = nullptr;
Sensors::Result sensorsResults[SENSORS_AMOUNT];
@@ -58,7 +58,7 @@ void setup() {
Sensors::results = sensorsResults;
LittleFS.begin();
Log.setLevel(TinyLogger::Level::VERBOSE);
Log.setLevel(TinyLoggerLevel::VERBOSE);
Log.setServiceTemplate("\033[1m[%s]\033[22m");
Log.setLevelTemplate("\033[1m[%s]\033[22m");
Log.setMsgPrefix("\033[m ");
@@ -76,7 +76,7 @@ void setup() {
#if ARDUINO_USB_MODE
Serial.setTxBufferSize(512);
#endif
Log.addStream(&Serial);
Log.addHandler(&Serial);
Log.print("\n\n\r");
//
@@ -160,24 +160,24 @@ void setup() {
// Logs settings
if (!settings.system.serial.enabled) {
Serial.end();
Log.clearStreams();
Log.clearHandlers();
} else if (settings.system.serial.baudrate != 115200) {
Serial.end();
Log.clearStreams();
Log.clearHandlers();
Serial.begin(settings.system.serial.baudrate);
Log.addStream(&Serial);
Log.addHandler(&Serial);
}
if (settings.system.telnet.enabled) {
telnetStream = new ESPTelnetStream;
telnetStream->setKeepAliveInterval(500);
Log.addStream(telnetStream);
if (settings.system.webSerial.enabled) {
webSerial = new WebSerial();
webSerial->setBuffer(100);
Log.addHandler(webSerial);
}
if (settings.system.logLevel >= TinyLogger::Level::SILENT && settings.system.logLevel <= TinyLogger::Level::VERBOSE) {
Log.setLevel(static_cast<TinyLogger::Level>(settings.system.logLevel));
if (settings.system.logLevel >= TinyLoggerLevel::SILENT && settings.system.logLevel <= TinyLoggerLevel::VERBOSE) {
Log.setLevel(static_cast<TinyLoggerLevel>(settings.system.logLevel));
}
//

2
src/strings.h
View File

@@ -198,7 +198,6 @@ const char S_SUMMER_WINTER_MODE[] PROGMEM = "summerWinterMode"
const char S_SYSTEM[] PROGMEM = "system";
const char S_TARGET[] PROGMEM = "target";
const char S_TARGET_TEMP[] PROGMEM = "targetTemp";
const char S_TELNET[] PROGMEM = "telnet";
const char S_TEMPERATURE[] PROGMEM = "temperature";
const char S_THRESHOLD_HIGH[] PROGMEM = "thresholdHigh";
const char S_THRESHOLD_LOW[] PROGMEM = "thresholdLow";
@@ -217,3 +216,4 @@ const char S_USE_DHCP[] PROGMEM = "useDhcp";
const char S_USER[] PROGMEM = "user";
const char S_VALUE[] PROGMEM = "value";
const char S_VERSION[] PROGMEM = "version";
const char S_WEBSERIAL[] PROGMEM = "webSerial";

24
src/utils.h
View File

@@ -425,9 +425,8 @@ void settingsToJson(const Settings& src, JsonVariant dst, bool safe = false) {
serial[FPSTR(S_ENABLED)] = src.system.serial.enabled;
serial[FPSTR(S_BAUDRATE)] = src.system.serial.baudrate;
auto telnet = system[FPSTR(S_TELNET)].to<JsonObject>();
telnet[FPSTR(S_ENABLED)] = src.system.telnet.enabled;
telnet[FPSTR(S_PORT)] = src.system.telnet.port;
auto webSerial = system[FPSTR(S_WEBSERIAL)].to<JsonObject>();
webSerial[FPSTR(S_ENABLED)] = src.system.webSerial.enabled;
auto ntp = system[FPSTR(S_NTP)].to<JsonObject>();
ntp[FPSTR(S_SERVER)] = src.system.ntp.server;
@@ -576,7 +575,7 @@ bool jsonToSettings(const JsonVariantConst src, Settings& dst, bool safe = false
if (!src[FPSTR(S_SYSTEM)][FPSTR(S_LOG_LEVEL)].isNull()) {
uint8_t value = src[FPSTR(S_SYSTEM)][FPSTR(S_LOG_LEVEL)].as<uint8_t>();
if (value != dst.system.logLevel && value >= TinyLogger::Level::SILENT && value <= TinyLogger::Level::VERBOSE) {
if (value != dst.system.logLevel && value >= TinyLoggerLevel::SILENT && value <= TinyLoggerLevel::VERBOSE) {
dst.system.logLevel = value;
changed = true;
}
@@ -602,20 +601,11 @@ bool jsonToSettings(const JsonVariantConst src, Settings& dst, bool safe = false
}
}
if (src[FPSTR(S_SYSTEM)][FPSTR(S_TELNET)][FPSTR(S_ENABLED)].is<bool>()) {
bool value = src[FPSTR(S_SYSTEM)][FPSTR(S_TELNET)][FPSTR(S_ENABLED)].as<bool>();
if (src[FPSTR(S_SYSTEM)][FPSTR(S_WEBSERIAL)][FPSTR(S_ENABLED)].is<bool>()) {
bool value = src[FPSTR(S_SYSTEM)][FPSTR(S_WEBSERIAL)][FPSTR(S_ENABLED)].as<bool>();
if (value != dst.system.telnet.enabled) {
dst.system.telnet.enabled = value;
changed = true;
}
}
if (!src[FPSTR(S_SYSTEM)][FPSTR(S_TELNET)][FPSTR(S_PORT)].isNull()) {
unsigned short value = src[FPSTR(S_SYSTEM)][FPSTR(S_TELNET)][FPSTR(S_PORT)].as<unsigned short>();
if (value > 0 && value <= 65535 && value != dst.system.telnet.port) {
dst.system.telnet.port = value;
if (value != dst.system.webSerial.enabled) {
dst.system.webSerial.enabled = value;
changed = true;
}
}